Skip to content

acpi: i386 tweaks

Gerd Hoffmann qemu-devel 10 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v10 Latest12 patches 3 repliesIn review
  2. v910 patches 8 repliesSuperseded
  3. v810 patches 7 repliesSuperseded
Earlier versions · 7
VersionPostedPatchesRepliesStatus
v79 patches5 repliesSuperseded
v616 patches10 repliesSuperseded
v515 patches15 repliesSuperseded
v413 patches12 repliesSuperseded
v315 patches22 repliesSuperseded
v212 patches22 repliesSuperseded
v16 patches9 repliesSuperseded

Changes in v10 from the cover letter

* move acpi test data update to separate commit.

Patches in v10 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/12qtest: allow DSDT acpi table changestests/qtest/bios-tables-test-allowed-diff.h+18 -00 replies
2/12acpi: bios-tables-test: show more context on asl diffstests/qtest/bios-tables-test.c+1 -10 replies
3/12acpi: move aml builder code for floppy devicehw/block/fdc.c hw/i386/acpi-build.c stubs/Makefile.objs +1 more+91 -830 replies
4/12floppy: make isa_fdc_get_drive_max_chs statichw/block/fdc.c include/hw/block/fdc.h+2 -40 replies
5/12floppy: move cmos_get_fd_drive_type() from pchw/block/fdc.c hw/i386/pc.c include/hw/block/fdc.h +1 more+26 -270 replies
6/12acpi: move aml builder code for i8042 (kbd+mouse) devicehw/i386/acpi-build.c hw/input/pckbd.c+31 -390 replies
7/12acpi: factor out fw_cfg_add_acpi_dsdt()hw/i386/acpi-build.c hw/i386/fw_cfg.c hw/i386/fw_cfg.h+30 -230 replies
8/12acpi: simplify build_isa_devices_aml()hw/i386/acpi-build.c+6 -100 replies
9/12acpi: drop serial/parallel enable bits from dsdthw/i386/acpi-build.c+0 -230 replies
10/12acpi: drop build_piix4_pm()hw/i386/acpi-build.c+0 -160 replies
11/12acpi: q35: drop _SB.PCI0.ISA.LPCD opregion.hw/i386/acpi-build.c+0 -110 replies
12/12tests/acpi: update expected data filestests/data/acpi/pc/DSDT tests/data/acpi/pc/DSDT.acpihmat tests/data/acpi/pc/DSDT.bridge +15 more+0 -02 replies

Reviews trailers per patch

10 of 12 patches have a Reviewed-by or Acked-by.

PatchIgor MammedovPhilippe Mathieu-DaudéJohn Snow
1/12
2/12R-b
3/12R-b
4/12R-b R-b A-b
5/12R-b A-b
6/12R-b R-b
7/12R-b R-b
8/12R-b R-b
9/12R-b
10/12R-b
11/12R-b
12/12

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v10 thread

Cover letter [PATCH v10 00/12] acpi: i386 tweaks

First batch of microvm patches, some generic acpi stuff. Split the acpi-build.c monster, specifically split the pc and q35 and pci bits into a separate file which we can skip building at some point in the future.

v2 changes: leave acpi-build.c largely as-is, move useful bits to other places to allow them being reused, specifically:

* move isa device generator functions to individual isa devices.
* move fw_cfg generator function to fw_cfg.c

v3 changes: fix rtc, support multiple lpt devices.

v4 changes:
* drop merged patches.
* split rtc crs change to separata patch.
* added two cleanup patches.
* picked up ack & review tags.

v5 changes:
* add comment for rtc crs update.
* add even more cleanup patches.
* picked up ack & review tags.

v6 changes:
* floppy: move cmos_get_fd_drive_type.
* picked up ack & review tags.

v7 changes:
* rebased to mst/pci branch, resolved stubs conflict.
* dropped patches already queued up in mst/pci.
* added missing sign-off.
* picked up ack & review tags.

v8 changes:
* (re-)add patch to allow acpi table changes

v9 changes:
* add asl changes to commit messages.
* update acpi test data.

v10 changes:
* move acpi test data update to separate commit.

take care,
Gerd

Gerd Hoffmann (12):
qtest: allow DSDT acpi table changes
acpi: bios-tables-test: show more context on asl diffs
acpi: move aml builder code for floppy device
floppy: make isa_fdc_get_drive_max_chs static
floppy: move cmos_get_fd_drive_type() from pc
acpi: move aml builder code for i8042 (kbd+mouse) device
acpi: factor out fw_cfg_add_acpi_dsdt()
acpi: simplify build_isa_devices_aml()
acpi: drop serial/parallel enable bits from dsdt
acpi: drop build_piix4_pm()
acpi: q35: drop _SB.PCI0.ISA.LPCD opregion. tests/acpi: update expected data files

 hw/i386/fw_cfg.h                            |   1 +
 include/hw/block/fdc.h                      |   3 +-
 include/hw/i386/pc.h                        |   1 -
 tests/qtest/bios-tables-test-allowed-diff.h |  18 ++
 hw/block/fdc.c                              | 111 ++++++++++-
 hw/i386/acpi-build.c                        | 210 +-------------------
 hw/i386/fw_cfg.c                            |  28 +++
 hw/i386/pc.c                                |  25 ---
 hw/input/pckbd.c                            |  31 +++
 stubs/cmos.c                                |   7 +
 tests/qtest/bios-tables-test.c              |   2 +-
 stubs/Makefile.objs                         |   1 +
 tests/data/acpi/pc/DSDT                     | Bin 5014 -> 4934 bytes
 tests/data/acpi/pc/DSDT.acpihmat            | Bin 6338 -> 6258 bytes
 tests/data/acpi/pc/DSDT.bridge              | Bin 6873 -> 6793 bytes
 tests/data/acpi/pc/DSDT.cphp                | Bin 5477 -> 5397 bytes
 tests/data/acpi/pc/DSDT.dimmpxm             | Bin 6667 -> 6587 bytes
 tests/data/acpi/pc/DSDT.ipmikcs             | Bin 5086 -> 5006 bytes
 tests/data/acpi/pc/DSDT.memhp               | Bin 6373 -> 6293 bytes
 tests/data/acpi/pc/DSDT.numamem             | Bin 5020 -> 4940 bytes
 tests/data/acpi/q35/DSDT                    | Bin 7752 -> 7678 bytes
 tests/data/acpi/q35/DSDT.acpihmat           | Bin 9076 -> 9002 bytes
 tests/data/acpi/q35/DSDT.bridge             | Bin 7769 -> 7695 bytes
 tests/data/acpi/q35/DSDT.cphp               | Bin 8215 -> 8141 bytes
 tests/data/acpi/q35/DSDT.dimmpxm            | Bin 9405 -> 9331 bytes
 tests/data/acpi/q35/DSDT.ipmibt             | Bin 7827 -> 7753 bytes
 tests/data/acpi/q35/DSDT.memhp              | Bin 9111 -> 9037 bytes
 tests/data/acpi/q35/DSDT.mmio64             | Bin 8882 -> 8808 bytes
 tests/data/acpi/q35/DSDT.numamem            | Bin 7758 -> 7684 bytes
 tests/data/acpi/q35/DSDT.tis                | Bin 8357 -> 8283 bytes
 30 files changed, 203 insertions(+), 235 deletions(-)
 create mode 100644 stubs/cmos.c
Signature · 1 line
2.18.4