C API: .needs_cmds and SAFE_RUN_CMD()
Get series with b4
b4 am 20200328034253.GA2720439@x230Versions newest first
- v1 Latest0 of 6 patches 0 repliesNew
Patches in v1 No applies recorded yet
None of the 6 patches the cover letter announces are in this archive.
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.
Cover letter [LTP] [PATCH 0/6] C API: .needs_cmds and SAFE_RUN_CMD()
Hi Xiao,
Quoted 6 lines · Petr Vorel
Quoted 2 lines
+ There is a double check (first in
.needs_cmds, then inSAFE_RUN_CMD()), maybe that's not needed.Hi Petr,
Quoted 8 lines
Why do you need the duplicate .needs_cmds flag?(it introduces the double check as you said)
Usually, all tests run commands by tst_run_cmd()/SAFE_RUN_CMD() and they can report TCONF
by passing
TST_RUN_CMD_CHECK_CMDso it is fair to be a part of tst_run_cmd()/SAFE_RUN_CMD().
Thanks for your review.
I guess Cyril will prefer .needs_cmds, as it can be parsed - metadata project:
https://people.kernel.org/metan/towards-parallel-kernel-test-runs
https://github.com/metan-ucw/ltp/tree/master/docparse
I put it there because some command might be run just under some condition (not always), thus not suitable for .needs_cmds, but still nice to have reliable check. But maybe I'm wrong.
Kind regards,
Petr