Skip to content

C API: .needs_cmds and SAFE_CMD()

Petr Vorel ltp 2 versions New

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest5 patches 0 repliesNew
  2. v10 of 6 patches 0 repliesSuperseded

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5lib: Rename tst_run_cmd*() to tst_cmd*()doc/test-writing-guidelines.txt include/tst_cmd.h lib/tst_cmd.c +16 more+41 -410 replies
2/5lib/tst_cmd_*(): Turn int pass_exit_val into enumdoc/test-writing-guidelines.txt include/tst_cmd.h lib/tst_cmd.c +11 more+48 -420 replies
3/5lib/tst_cmd_*(): Search for program in $PATHdoc/test-writing-guidelines.txt include/tst_cmd.h lib/tst_cmd.c+17 -50 replies
4/5lib: Implement SAFE_CMD() macro (new API only)doc/test-writing-guidelines.txt include/tst_safe_macros.h+21 -02 replies
4/5lib: Implement SAFE_CMD() macro (new API only)test-writing-guidelines.txt tst_safe_macros.h+3 -30 replies
5/5Use SAFE_CMD()doc/test-writing-guidelines.txt include/tst_safe_macros.h testcases/kernel/syscalls/add_key/add_key05.c +2 more+11 -321 reply
5/5Use SAFE_CMD()test-writing-guidelines.txt tst_safe_macros.h+4 -41 reply
5/5Use SAFE_CMD()+0 -00 replies
5/5Use SAFE_CMD()+0 -00 replies

Reviews trailers per patch

8 of 9 patches have a Reviewed-by or Acked-by.

PatchLi WangYang XuCyril Hrubis
1/5
2/5R-b R-b R-b
3/5R-b R-b R-b
4/5R-b R-b R-b
4/5R-b R-b R-b
5/5R-b R-b R-b
5/5R-b R-b R-b
5/5R-b R-b R-b
5/5R-b R-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v2 thread

Cover letter [LTP] [PATCH v2 0/5] C API: .needs_cmds and SAFE_CMD()

Hi,

just in case due massive rename I'm posting the changes.

Kind regards,
Petr

Petr Vorel (5):
lib: Rename tst_run_cmd*() to tst_cmd*() lib/tst_cmd_*(): Turn int pass_exit_val into enum lib/tst_cmd_*(): Search for program in $PATH
lib: Implement SAFE_CMD() macro (new API only) Use SAFE_CMD()

 doc/test-writing-guidelines.txt               | 20 +++---
 include/tst_cmd.h                             | 61 +++++++++++--------
 include/tst_safe_macros.h                     | 17 ++++++
 lib/{tst_run_cmd.c => tst_cmd.c}              | 32 ++++++----
 lib/tst_kernel.c                              |  3 +-
 lib/tst_mkfs.c                                |  2 +-
 lib/tst_module.c                              |  5 +-
 lib/tst_virt.c                                |  2 +-
 testcases/cve/stack_clash.c                   |  2 +-
 testcases/kernel/input/input_helper.c         |  4 +-
 testcases/kernel/syscalls/acct/acct02.c       |  2 +-
 testcases/kernel/syscalls/add_key/add_key05.c | 16 ++---
 .../copy_file_range/copy_file_range02.c       |  2 +-
 .../kernel/syscalls/quotactl/quotactl01.c     | 11 +---
 .../kernel/syscalls/quotactl/quotactl06.c     |  9 +--
 .../syscalls/setpriority/setpriority01.c      |  4 +-
 testcases/kernel/syscalls/swapon/libswapon.c  |  2 +-
 testcases/network/netstress/netstress.c       |  2 +-
 .../network/nfs/nfs_stress/nfs05_make_tree.c  |  6 +-
 tools/apicmds/ltpapicmd.c                     |  2 +-
 20 files changed, 111 insertions(+), 93 deletions(-)
 rename lib/{tst_run_cmd.c => tst_cmd.c} (86%)
Signature · 1 line
2.26.0