Skip to content

kernel-shark: Have "stop" button for multi-threaded searches

Yordan Karadzhov (VMware) linux-trace-devel 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest3 patches 2 repliesIn review
  2. v13 patches 7 repliesSuperseded

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3kernel-shark: Simplify the search methods in class KsTraceViewerkernel-shark/src/KsTraceViewer.cpp kernel-shark/src/KsTraceViewer.hpp+9 -81 reply
2/3kernel-shark: Change the mechanism of the multi-threaded searchkernel-shark/src/KsModels.cpp kernel-shark/src/KsModels.hpp kernel-shark/src/KsSearchFSM.hpp +1 more+183 -620 replies
3/3kernel-shark: Make the "stop search" button always visiblekernel-shark/src/KsSearchFSM.cpp+6 -51 reply

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.

Read the v2 thread

Cover letter [PATCH v2 0/3] kernel-shark: Have "stop" button for multi-threaded searches

So far "stop" button was available only during the single-threaded searches. In order to make the multi-threaded searches stoppable and restartable we are changing the searching mechanism making all searching threads to progress in the data in parallel.

Changes is v2:
- Fix of the deadlock in the multi-threaded searche that occurs when the total number of entries is exactly multiple of the number of entries to be searched before updating the progress bar.

Yordan Karadzhov (VMware) (3):
kernel-shark: Simplify the search methods in class KsTraceViewer
kernel-shark: Change the mechanism of the multi-threaded search
kernel-shark: Make the "stop search" button always visible

 kernel-shark/src/KsModels.cpp      |  89 ++++++++++++------
 kernel-shark/src/KsModels.hpp      |  16 ++--
 kernel-shark/src/KsSearchFSM.cpp   |  11 ++-
 kernel-shark/src/KsSearchFSM.hpp   |   5 +-
 kernel-shark/src/KsTraceViewer.cpp | 141 +++++++++++++++++++++++------
 kernel-shark/src/KsTraceViewer.hpp |   5 +-
 6 files changed, 195 insertions(+), 72 deletions(-)
Signature · 1 line
2.20.1