Skip to content

Netfilter/IPVS updates for net-next

Pablo Neira Ayuso netdev netfilter-devel 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest28 patches 1 replyIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/28netfilter: nf_tables: move nft_expr_clone() to nf_tables_api.cinclude/net/netfilter/nf_tables.h net/netfilter/nf_tables_api.c net/netfilter/nft_dynset.c+19 -170 replies
2/28netfilter: nf_tables: pass context to nft_set_destroy()net/netfilter/nf_tables_api.c+5 -50 replies
3/28netfilter: nf_tables: allow to specify stateful expression in set definitioninclude/net/netfilter/nf_tables.h include/uapi/linux/netfilter/nf_tables.h net/netfilter/nf_tables_api.c+52 -120 replies
4/28netfilter: nf_tables: fix double-free on set expression from the error pathnet/netfilter/nf_tables_api.c+1 -00 replies
5/28netfilter: nf_tables: add nft_set_elem_expr_destroy() and use itnet/netfilter/nf_tables_api.c+17 -110 replies
6/28netfilter: flowtable: fix NULL pointer dereference in tunnel offload supportnet/netfilter/nf_flow_table_offload.c+3 -30 replies
7/28netfilter: ctnetlink: Add missing annotation for ctnetlink_parse_nat_setup()net/netfilter/nf_conntrack_netlink.c+1 -00 replies
8/28netfilter: conntrack: Add missing annotations for nf_conntrack_all_lock() and nf_conntrack_all_unlock()net/netfilter/nf_conntrack_core.c+2 -00 replies
9/28ipvs: optimize tunnel dumps for icmp errorsnet/netfilter/ipvs/ip_vs_core.c+26 -200 replies
10/28netfilter: conntrack: export nf_ct_acct_update()include/net/netfilter/nf_conntrack_acct.h net/netfilter/nf_conntrack_core.c+9 -80 replies
11/28netfilter: nf_tables: add enum nft_flowtable_flags to uapiinclude/net/netfilter/nf_flow_table.h include/uapi/linux/netfilter/nf_tables.h net/netfilter/nf_tables_api.c+12 -20 replies
12/28netfilter: flowtable: add counter supportinclude/net/netfilter/nf_flow_table.h include/uapi/linux/netfilter/nf_tables.h net/netfilter/nf_flow_table_ip.c+12 -10 replies
13/28netfilter: flowtable: Fix incorrect tc_setup_type typeinclude/net/flow_offload.h net/core/flow_offload.c net/netfilter/nf_flow_table_offload.c +2 more+8 -70 replies
14/28netfilter: nf_tables: silence a RCU-list warning in nft_table_lookup()net/netfilter/nf_tables_api.c+2 -10 replies
15/28netfilter: flowtable: Use rw sem as flow block lockinclude/net/netfilter/nf_flow_table.h net/netfilter/nf_flow_table_core.c net/netfilter/nf_flow_table_offload.c+8 -90 replies
16/28netfilter: flowtable: Use work entry per offload commandnet/netfilter/nf_flow_table_offload.c+15 -310 replies
17/28netfilter: nf_queue: make nf_queue_entry_release_refs staticinclude/net/netfilter/nf_queue.h net/netfilter/nf_queue.c net/netfilter/nfnetlink_queue.c+11 -110 replies
18/28netfilter: nf_queue: place bridge physports into queue_entry structinclude/net/netfilter/nf_queue.h net/netfilter/nf_queue.c+27 -310 replies
19/28netfilter: nf_queue: do not release refcouts until nf_reinject is donenet/netfilter/nf_queue.c+2 -40 replies
20/28netfilter: nf_queue: prefer nf_queue_entry_freenet/netfilter/nf_queue.c+9 -180 replies
21/28netfilter: ctnetlink: be more strict when NF_CONNTRACK_MARK is not setnet/netfilter/nf_conntrack_netlink.c+1 -10 replies
22/28netfilter: nft_set_bitmap: initialize set element extension in lookupsnet/netfilter/nft_set_bitmap.c+1 -00 replies
23/28netfilter: nft_dynset: validate set expression definitionnet/netfilter/nft_dynset.c+7 -20 replies
24/28netfilter: nf_tables: skip set types that do not support for expressionsinclude/net/netfilter/nf_tables.h net/netfilter/nf_tables_api.c net/netfilter/nft_set_bitmap.c+7 -00 replies
25/28netfilter: conntrack: add nf_ct_acct_add()include/net/netfilter/nf_conntrack_acct.h net/netfilter/nf_conntrack_core.c+14 -40 replies
26/28netfilter: flowtable: add counter support in HW offloadnet/netfilter/nf_flow_table_offload.c+12 -00 replies
27/28netfilter: nft_exthdr: fix endianness of tcp option castnet/netfilter/nft_exthdr.c+3 -50 replies
28/28ipvs: fix uninitialized variable warningnet/netfilter/ipvs/ip_vs_core.c+1 -20 replies

Reviews trailers per patch

6 of 28 patches have a Reviewed-by or Acked-by.

PatchOz ShlomoFlorian WestphalJulian Anastasov
1/28
2/28
3/28
4/28
5/28
6/28
7/28
8/28
9/28A-b
10/28
11/28
12/28
13/28
14/28A-b
15/28R-b
16/28R-b
17/28
18/28
19/28
20/28
21/28
22/28
23/28
24/28
25/28
26/28
27/28A-b
28/28A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v1 thread

Cover letter [PATCH 00/28] Netfilter/IPVS updates for net-next

Hello David,

The following patchset contains Netfilter/IPVS updates for net-next:

1) Add support to specify a stateful expression in set definitions, this allows users to specify e.g. counters per set elements.

2) Flowtable software counter support.

3) Flowtable hardware offload counter support, from wenxu.

3) Parallelize flowtable hardware offload requests, from Paul Blakey. This includes a patch to add one work entry per offload command.

4) Several patches to rework nf_queue refcount handling, from Florian Westphal.

4) A few fixes for the flowtable tunnel offload: Fix crash if tunneling information is missing and set up indirect flow block as TC_SETUP_FT, patch from wenxu.

5) Stricter netlink attribute sanity check on filters, from Romain Bellan and Florent Fourcot.

5) Annotations to make sparse happy, from Jules Irenge.

6) Improve icmp errors in debugging information, from Haishuang Yan.

7) Fix warning in IPVS icmp error debugging, from Haishuang Yan.

8) Fix endianess issue in tcp extension header, from Sergey Marinkevich.

You can pull these changes from:

git://git.kernel.org/pub/scm/linux/kernel/git/pablo/nf-next.git

Thank you.

----------------------------------------------------------------

The following changes since commit 79e28519ac78dde6d38fe6ea22286af574f5c7db:

Merge tag 'mlx5-updates-2020-03-17' of git://git.kernel.org/pub/scm/linux/kernel/git/saeed/linux (2020-03-18 19:13:37 -0700)

are available in the git repository at:

git://git.kernel.org/pub/scm/linux/kernel/git/pablo/nf-next.git HEAD

for you to fetch changes up to e19680f8347ec0e335ae90801fbe42d85d7b385a:

ipvs: fix uninitialized variable warning (2020-03-30 21:17:53 +0200)

----------------------------------------------------------------
Florian Westphal (4):
netfilter: nf_queue: make nf_queue_entry_release_refs static
netfilter: nf_queue: place bridge physports into queue_entry struct
netfilter: nf_queue: do not release refcouts until nf_reinject is done
netfilter: nf_queue: prefer nf_queue_entry_free

Haishuang Yan (2):
ipvs: optimize tunnel dumps for icmp errors
ipvs: fix uninitialized variable warning

Jules Irenge (2):
netfilter: ctnetlink: Add missing annotation for ctnetlink_parse_nat_setup()
netfilter: conntrack: Add missing annotations for nf_conntrack_all_lock() and nf_conntrack_all_unlock()

Pablo Neira Ayuso (11):
netfilter: nf_tables: move nft_expr_clone() to nf_tables_api.c
netfilter: nf_tables: pass context to nft_set_destroy()
netfilter: nf_tables: allow to specify stateful expression in set definition
netfilter: nf_tables: fix double-free on set expression from the error path
netfilter: nf_tables: add nft_set_elem_expr_destroy() and use it
netfilter: conntrack: export nf_ct_acct_update()
netfilter: nf_tables: add enum nft_flowtable_flags to uapi
netfilter: flowtable: add counter support
netfilter: nft_set_bitmap: initialize set element extension in lookups
netfilter: nft_dynset: validate set expression definition
netfilter: nf_tables: skip set types that do not support for expressions

Paul Blakey (2):
netfilter: flowtable: Use rw sem as flow block lock
netfilter: flowtable: Use work entry per offload command

Qian Cai (1):
netfilter: nf_tables: silence a RCU-list warning in nft_table_lookup()

Romain Bellan (1):
netfilter: ctnetlink: be more strict when NF_CONNTRACK_MARK is not set

Sergey Marinkevich (1):
netfilter: nft_exthdr: fix endianness of tcp option cast

wenxu (4):
netfilter: flowtable: fix NULL pointer dereference in tunnel offload support
netfilter: flowtable: Fix incorrect tc_setup_type type
netfilter: conntrack: add nf_ct_acct_add()
netfilter: flowtable: add counter support in HW offload

 include/net/flow_offload.h                |   3 +-
 include/net/netfilter/nf_conntrack_acct.h |  11 +++
 include/net/netfilter/nf_flow_table.h     |   5 +-
 include/net/netfilter/nf_queue.h          |   7 +-
 include/net/netfilter/nf_tables.h         |   5 ++
 include/uapi/linux/netfilter/nf_tables.h  |  15 ++++
 net/core/flow_offload.c                   |   6 +-
 net/netfilter/ipvs/ip_vs_core.c           |  45 ++++++-----
 net/netfilter/nf_conntrack_core.c         |  18 +++--
 net/netfilter/nf_conntrack_netlink.c      |   3 +-
 net/netfilter/nf_flow_table_core.c        |  11 ++-
 net/netfilter/nf_flow_table_ip.c          |   7 ++
 net/netfilter/nf_flow_table_offload.c     |  70 ++++++++---------
 net/netfilter/nf_queue.c                  |  96 ++++++++++-------------
 net/netfilter/nf_tables_api.c             | 125 +++++++++++++++++++++++-------
 net/netfilter/nf_tables_offload.c         |   2 +-
 net/netfilter/nfnetlink_queue.c           |  10 +--
 net/netfilter/nft_dynset.c                |  26 ++-----
 net/netfilter/nft_exthdr.c                |   8 +-
 net/netfilter/nft_set_bitmap.c            |   3 +
 net/sched/cls_api.c                       |   2 +-
 21 files changed, 280 insertions(+), 198 deletions(-)