Skip to content

x86/ucode: Cleanup and fixes - Part 4/n (AMD)

Andrew Cooper xen-devel 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest11 patches 19 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/11x86/ucode/amd: Fix more potential buffer overruns with microcode parsingxen/arch/x86/cpu/microcode/amd.c+13 -140 replies
2/11x86/ucode/amd: Move check_final_patch_levels() to apply_microcode()xen/arch/x86/cpu/microcode/amd.c+38 -451 reply
3/11x86/ucode/amd: Don't use void * for microcode_patch->mpbxen/arch/x86/cpu/microcode/amd.c+2 -31 reply
4/11x86/ucode/amd: Collect CPUID.1.EAX in collect_cpu_info()xen/arch/x86/cpu/microcode/amd.c xen/include/asm-x86/microcode.h+4 -91 reply
5/11x86/ucode/amd: Overhaul the equivalent cpu table handling completelyxen/arch/x86/cpu/microcode/amd.c+64 -481 reply
6/11x86/ucode/amd: Move verify_patch_size() into get_ucode_from_buffer_amd()xen/arch/x86/cpu/microcode/amd.c+7 -111 reply
7/11x86/ucode/amd: Alter API for microcode_fits()xen/arch/x86/cpu/microcode/amd.c+9 -131 reply
8/11x86/ucode/amd: Rename bufsize to size in cpu_request_microcode()xen/arch/x86/cpu/microcode/amd.c+10 -112 replies
9/11x86/ucode/amd: Remove gratuitous memory allocations from cpu_request_microcode()xen/arch/x86/cpu/microcode/amd.c+47 -915 replies
10/11x86/ucode/amd: Fold structures togetherxen/arch/x86/cpu/microcode/amd.c+20 -501 reply
11/11x86/ucode/amd: Rework parsing logic in cpu_request_microcode()xen/arch/x86/cpu/microcode/amd.c+44 -1255 replies

Reviews trailers per patch

All 11 patches have a Reviewed-by or Acked-by.

PatchJan Beulich
1/11R-b
2/11R-b
3/11R-b
4/11R-b
5/11R-b
6/11R-b
7/11A-b
8/11A-b
9/11R-b
10/11R-b
11/11R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 00/11] x86/ucode: Cleanup and fixes - Part 4/n (AMD)

The first patch definitely needs backporting. Second is a good candidate as well. Everything else probably not.

This follows similar cleanup on the Intel side, removing gratuitous memory allocations (both interms of number, and indirection), and fixes several things to be more uniform (handling of cpu_sig->sig, and parsing of multiple containers.

Andrew Cooper (11):
x86/ucode/amd: Fix more potential buffer overruns with microcode parsing x86/ucode/amd: Move check_final_patch_levels() to apply_microcode() x86/ucode/amd: Don't use void * for microcode_patch->mpb x86/ucode/amd: Collect CPUID.1.EAX in collect_cpu_info() x86/ucode/amd: Overhaul the equivalent cpu table handling completely x86/ucode/amd: Move verify_patch_size() into get_ucode_from_buffer_amd() x86/ucode/amd: Alter API for microcode_fits()
x86/ucode/amd: Rename bufsize to size in cpu_request_microcode() x86/ucode/amd: Remove gratuitous memory allocations from cpu_request_microcode() x86/ucode/amd: Fold structures together
x86/ucode/amd: Rework parsing logic in cpu_request_microcode()

 xen/arch/x86/cpu/microcode/amd.c | 512 +++++++++++++--------------------------
 xen/include/asm-x86/microcode.h  |   2 +-
 2 files changed, 176 insertions(+), 338 deletions(-)
Signature · 1 line
2.11.0