qga: Restrict guest-file-read count to 10 MB to avoid crashes
Get series with b4
b4 am [email protected]Versions newest first
- v2 Latest4 patches 7 repliesIn review
Patches in v2 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/4 | Revert "prevent crash when executing guest-file-read with large count"qga/ | +1 | 2 replies | |
| 2/4 | qga: Extract guest_file_handle_find() to commands-common.hqga/ qga/ qga/ | +26 | 0 replies | |
| 3/4 | qga: Extract qmp_guest_file_read() to common commands.cqga/ qga/ qga/ +1 more | +34 | 0 replies | |
| 4/4 | qga: Restrict guest-file-read count to 10 MB to avoid crashesqga/ qga/ | +9 | 5 replies |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.
Cover letter [PATCH-for-5.0 v2 0/4] qga: Restrict guest-file-read count to 10 MB to avoid crashes
Fakhri Zulkifli reported BZ#1594054
https://bugzilla.redhat.com/show_bug.cgi?id=1594054
Dietmar Maurer noticed the fix from 807e2b6fce0 doesn't help as error_setg() also calls malloc().
Daniel Berrangé suggested a clever fix, restrict the guest-agent command size to avoid heap mayhem.
v1: https://www.mail-archive.com/[email protected]/msg691773.html
Philippe Mathieu-Daudé (4):
Revert "prevent crash when executing guest-file-read with large count"
qga: Extract guest_file_handle_find() to commands-common.h
qga: Extract qmp_guest_file_read() to common commands.c
qga: Restrict guest-file-read count to 10 MB to avoid crashes
qga/qapi-schema.json | 6 ++++-- qga/commands-common.h | 21 +++++++++++++++++++++ qga/commands-posix.c | 29 +++++++---------------------- qga/commands-win32.c | 35 ++++++++--------------------------- qga/commands.c | 29 +++++++++++++++++++++++++++++ 5 files changed, 69 insertions(+), 51 deletions(-) create mode 100644 qga/commands-common.h
Signature · 1 line
2.21.1