Skip to content

ip_frag: add a unit test for fragmentation

Aaron Conole dpdk-dev 6 versions – Applied

Status from this message: Applied, thanks

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v6 Latest3 patches 4 repliesApplied
  2. v53 patches 9 repliesSuperseded
  3. v43 patches 4 repliesSuperseded
Earlier versions · 3
VersionPostedPatchesRepliesStatus
v34 patches10 repliesSuperseded
v24 patches0 repliesSuperseded
v14 patches1 replySuperseded

Changes in v6 from the cover letter

- Coding style fixes
- Use named defines instead of bare MTU decimal values.

Patches in v6 Applied

#Subject and filesSizeRepliesApplied
1/3ip_frag: ensure minimum v4 fragmentation lengthlib/librte_ip_frag/rte_ipv4_fragmentation.c+10 -01 reply
2/3ip_frag: ensure minimum v6 fragmentation lengthlib/librte_ip_frag/rte_ipv6_fragmentation.c lib/librte_net/rte_ip.h+11 -01 reply
3/3ipfrag: add unit test caseMAINTAINERS app/test/meson.build app/test/test_ipfrag.c+265 -01 reply

Reviews trailers per patch

All 3 patches have a Reviewed-by or Acked-by.

PatchKonstantin AnanyevLukasz Wojciechowski
1/3A-b A-b A-b
2/3A-b A-b A-b
3/3T-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v6 thread

Cover letter [dpdk-dev] [PATCH v6 0/3] ip_frag: add a unit test for fragmentation

This adds a simple unit test for the ip fragmentation library and covers fragmenting ipv4 and ipv6. Additionally, some fixes are introduced, which are really just sanity rather than real issues in the field.

v5->v6:
- Coding style fixes
- Use named defines instead of bare MTU decimal values.

v4->v5:
- Address coding style comments in patch 3/3

v3->v4:
- Drop the frag header detection from ipv6 code
- Full parameter sanity checking in ipv4 and ipv6 code
- Convert from htons/htonl to rte_cpu_to_be_...

v2->v3:
- Remove c99-ism from 4/4

v1->v2:
- Fix patch 4/4 which had a missing assignment for pktid.

Aaron Conole (3):
ip_frag: ensure minimum v4 fragmentation length
ip_frag: ensure minimum v6 fragmentation length
ipfrag: add unit test case

 MAINTAINERS                                 |   1 +
 app/test/meson.build                        |   2 +
 app/test/test_ipfrag.c                      | 262 ++++++++++++++++++++
 lib/librte_ip_frag/rte_ipv4_fragmentation.c |  10 +
 lib/librte_ip_frag/rte_ipv6_fragmentation.c |   9 +
 lib/librte_net/rte_ip.h                     |   2 +
 6 files changed, 286 insertions(+)
 create mode 100644 app/test/test_ipfrag.c
Signature · 1 line
2.25.1