Skip to content

KVM: arm64: PSCI fixes

Marc Zyngier kvm kvmarm linux-arm-kernel 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest2 patches 7 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2KVM: arm64: PSCI: Narrow input registers when using 32bit functionsvirt/kvm/arm/psci.c+16 -02 replies
2/2KVM: arm64: PSCI: Forbid 64bit functions for 32bit guestsvirt/kvm/arm/psci.c+24 -02 replies

Reviews trailers per patch

All 2 patches have a Reviewed-by or Acked-by.

PatchChristoffer DallAlexandru Elisei
1/2R-b R-b
2/2R-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/2] KVM: arm64: PSCI fixes

Christoffer recently pointed out that we don't narrow the arguments to SMC32 PSCI functions called by a 64bit guest. This could result in a guest failing to boot its secondary CPUs if it had junk in the upper 32bits. Yes, this is silly, but the guest is allowed to do that. Duh.

Whist I was looking at this, it became apparent that we allow a 32bit guest to call 64bit functions, which the spec explicitly forbids. Oh well, another patch.

This has been lightly tested, but I feel that we could do with a new set of PSCI corner cases in KVM-unit-tests (hint, nudge... ;-).

Marc Zyngier (2):
KVM: arm64: PSCI: Narrow input registers when using 32bit functions
KVM: arm64: PSCI: Forbid 64bit functions for 32bit guests

 virt/kvm/arm/psci.c | 40 ++++++++++++++++++++++++++++++++++++++++
 1 file changed, 40 insertions(+)
Signature · 1 line
2.25.0