Skip to content

NFS: Fix a number of memory leaks and use-after-free

[email protected] linux-nfs 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest10 patches 2 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/10NFS: Fix a page leak in nfs_destroy_unlinked_subrequests()fs/nfs/write.c+1 -00 replies
2/10NFS: Fix races nfs_page_group_destroy() vs nfs_destroy_unlinked_subrequests()fs/nfs/pagelist.c fs/nfs/write.c include/linux/nfs_page.h+55 -240 replies
3/10NFS: Fix use-after-free issues in nfs_pageio_add_request()fs/nfs/pagelist.c+24 -240 replies
4/10NFS: Fix a request reference leak in nfs_direct_write_clear_reqs()fs/nfs/direct.c+1 -00 replies
5/10NFS: Fix memory leaks in nfs_pageio_stop_mirroring()fs/nfs/pagelist.c+8 -92 replies
6/10NFS: Remove the redundant function nfs_pgio_has_mirroring()fs/nfs/internal.h fs/nfs/pagelist.c+2 -110 replies
7/10NFS: Clean up nfs_lock_and_join_requests()fs/nfs/pagelist.c fs/nfs/write.c include/linux/nfs_page.h+95 -710 replies
8/10NFS: Reverse the submission order of requests in __nfs_pageio_add_request()fs/nfs/pagelist.c+64 -690 replies
9/10NFS: Refactor nfs_lock_and_join_requests()fs/nfs/pagelist.c fs/nfs/write.c include/linux/nfs_page.h+123 -680 replies
10/10NFS: Try to join page groups before an O_DIRECT retransmissionfs/nfs/direct.c fs/nfs/write.c include/linux/nfs_page.h+22 -10 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 00/10] NFS: Fix a number of memory leaks and use-after-free

From: Trond Myklebust <[email protected]>

When running xfstests with wsize=1024, a number of use-after-free issues and memory leaks can currently be hit. One of the more obvious leaks is seen when the generic/013 test fails due to the presence of sillyrenamed files that never go away.

After testing with kasan enabled, and adding some debugging code to detect leaked nfs_page and nfs_direct_req structures, I found a number of issues that appear to be fixed by the following patchset.

Trond Myklebust (10):
NFS: Fix a page leak in nfs_destroy_unlinked_subrequests()
NFS: Fix races nfs_page_group_destroy() vs
nfs_destroy_unlinked_subrequests()
NFS: Fix use-after-free issues in nfs_pageio_add_request()
NFS: Fix a request reference leak in nfs_direct_write_clear_reqs()
NFS: Fix memory leaks in nfs_pageio_stop_mirroring()
NFS: Remove the redundant function nfs_pgio_has_mirroring()
NFS: Clean up nfs_lock_and_join_requests()
NFS: Reverse the submission order of requests in

    __nfs_pageio_add_request()

NFS: Refactor nfs_lock_and_join_requests()
NFS: Try to join page groups before an O_DIRECT retransmission

 fs/nfs/direct.c          |  21 +++
 fs/nfs/internal.h        |   6 -
 fs/nfs/pagelist.c        | 350 +++++++++++++++++++++++++--------------
 fs/nfs/write.c           | 258 ++++++++++++++---------------
 include/linux/nfs_page.h |   5 +
 5 files changed, 379 insertions(+), 261 deletions(-)
Signature · 1 line
2.25.1