Skip to content

KVM: s390: vsie: fixes and cleanups

David Hildenbrand kvm linux-s390 lkml stable 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest5 patches 16 repliesIn review
  2. v15 patches 8 repliesSuperseded

Changes in v2 from the cover letter

- "KVM: s390: vsie: Fix region 1 ASCE sanity shadow address checks" -- Fix WARN_ON_ONCE
- "gmap_table_walk() simplifications"
-- Also init "table" directly

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5KVM: s390: vsie: Fix region 1 ASCE sanity shadow address checksarch/s390/mm/gmap.c+5 -18 replies
2/5KVM: s390: vsie: Fix delivery of addressing exceptionsarch/s390/kvm/vsie.c+1 -02 replies
3/5KVM: s390: vsie: Fix possible race when shadowing region 3 tablesarch/s390/mm/gmap.c+1 -01 reply
4/5KVM: s390: vsie: Move conditional reschedulearch/s390/kvm/vsie.c+1 -22 replies
5/5KVM: s390: vsie: gmap_table_walk() simplificationsarch/s390/mm/gmap.c+5 -52 replies

Reviews trailers per patch

All 5 patches have a Reviewed-by or Acked-by.

PatchJanosch FrankChristian BorntraegerClaudio Imbrenda
1/5T-b R-b R-b
2/5R-b
3/5R-b
4/5R-b R-b
5/5R-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v2 thread

Cover letter [PATCH v2 0/5] KVM: s390: vsie: fixes and cleanups

Some vsie/gmap fixes and two cleanups/improvements.

Patch #1 fixes an issue reported by Janosch. It was never observed so far, because KVM usually doesn't use a region 1 table for it's guest (unless memory would be exceeding something like 16 EB, which isn't even supported by the HW). Older QEMU+KVM or other hypervisors can trigger this.

Patch #2 fixes a code path that probably was never taken and will most probably not be taken very often in the future - unless somebody really messes up the page tables for a guest (or writes a test for it). At some point, a test case for this would be nice.

Patch #3 fixes a rare possible race. Don't think this is stable material.

Gave it some testing with my limited access to somewhat-fast s390x machines. Booted a Linux kernel, supplying all possible number of page table hiearchies.

v1 -> v2:
- "KVM: s390: vsie: Fix region 1 ASCE sanity shadow address checks" -- Fix WARN_ON_ONCE
- "gmap_table_walk() simplifications"
-- Also init "table" directly

David Hildenbrand (5):
KVM: s390: vsie: Fix region 1 ASCE sanity shadow address checks
KVM: s390: vsie: Fix delivery of addressing exceptions
KVM: s390: vsie: Fix possible race when shadowing region 3 tables
KVM: s390: vsie: Move conditional reschedule
KVM: s390: vsie: gmap_table_walk() simplifications

 arch/s390/kvm/vsie.c |  4 ++--
 arch/s390/mm/gmap.c  | 17 +++++++++++------
 2 files changed, 13 insertions(+), 8 deletions(-)
Signature · 1 line
2.25.1