Skip to content

block: Fix blk->in_flight during blk_wait_while_drained()

Kevin Wolf qemu-devel 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest3 patches 6 repliesIn review
  2. v23 patches 15 repliesSuperseded
  3. v12 patches 4 repliesSuperseded

Changes in v3 from the cover letter

- Call blk_inc/dec_in_flight() in blk_prw() rather than inside the coroutines [Max]

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3block-backend: Reorder flush/pdiscard function definitionsblock/block-backend.c+46 -460 replies
2/3block: Increase BB.in_flight for coroutine and sync interfacesblock/block-backend.c include/sysemu/block-backend.h+80 -246 replies
3/3block: Fix blk->in_flight during blk_wait_while_drained()block/block-backend.c+5 -120 replies

Reviews trailers per patch

All 3 patches have a Reviewed-by or Acked-by.

PatchVladimir Sementsov-OgievskiyMax Reitz
1/3R-b R-b
2/3R-b R-b
3/3R-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [PATCH for-5.0 v3 0/3] block: Fix blk->in_flight during blk_wait_while_drained()

This fixes deadlocks when draining a BlockBackend in an iothread that receives new requests at the same time.

v3:
- Call blk_inc/dec_in_flight() in blk_prw() rather than inside the coroutines [Max]

v2:
- Rework the whole thing so that direct callers of blk_co_*() aren't broken after the series [Max]

Kevin Wolf (3):
block-backend: Reorder flush/pdiscard function definitions
block: Increase BB.in_flight for coroutine and sync interfaces
block: Fix blk->in_flight during blk_wait_while_drained()

 include/sysemu/block-backend.h |   1 -
 block/block-backend.c          | 206 ++++++++++++++++++++-------------
 2 files changed, 128 insertions(+), 79 deletions(-)
Signature · 1 line
2.20.1