drop writes to read-only ram device & vfio regions
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v6 Latest3 patches 13 repliesIn review
- v53 patches 4 repliesSuperseded
- v43 patches 7 repliesSuperseded
Earlier versions · 3
| Version | Posted | Patches | Replies | Status |
|---|---|---|---|---|
| v3 | 3 patches | 6 replies | Superseded | |
| v2 posting 2/2 | 0 of 3 patches | 1 reply | Superseded | |
| v2 posting 1/2 | 3 patches | 2 replies | Superseded |
Changes in v6 from the cover letter
-fixed two style alignment problems in patch 1. (Philippe)
Patches in v6 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/3 | memory: drop guest writes to read-only ram device regionsmemory.c | +12 | 13 replies | |
| 2/3 | hw/vfio: drop guest writes to ro regionshw/ | +11 | 0 replies | |
| 3/3 | hw/vfio: let read-only flag take effect for mmap'd regionshw/ | +4 | 0 replies |
Reviews trailers per patch
All 3 patches have a Reviewed-by or Acked-by.
| Patch | Philippe Mathieu-Daudé |
|---|---|
| 1/3 | R-b |
| 2/3 | R-b |
| 3/3 | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH v6 0/3] drop writes to read-only ram device & vfio regions
guest writes to read-only memory regions need to be dropped.
patch 1 modifies handler of ram device memory regions to drop guest writes to read-only ram device memory regions
patch 2 modifies handler of non-mmap'd read-only vfio regions to drop guest writes to those regions
patch 3 set read-only flag to mmap'd read-only vfio regions, so that guest writes to those regions would be trapped.
without patch 1, host qemu would then crash on guest write to those read-only regions.
with patch 1, host qemu would drop the writes.
Changelog:
v6:
-fixed two style alignment problems in patch 1. (Philippe)
v5:
-changed write handler of ram device memory region from .write to .write_with_attrs in patch 1 (Paolo)
(for vfio region in patch 2, I still keep the operations as .read & .write. the reasons are:
1. vfio_region_ops are for mmio/pio regions. the top level read/write dispatcher in kvm just ignores their return values. (the return value of address_space_rw() is just ignored)
2. there are a lot of callers to vfio_region_read() and vfio_region_write(), who actually do not care about the return values )
-minor changes on text format in error logs.
v4:
-instead of modifying tracing log, added qemu_log_mask(LOG_GUEST_ERROR...) to log guest writes to read-only regions (Philippe)
for
v3:
-refreshed and Cc Stefan for reviewing of tracing part
v2:
-split one big patches into smaller ones (Philippe)
-modify existing trace to record guest writes to read-only memory (Alex) -modify vfio_region_write() to drop guest writes to non-mmap'd read-only
region (Alex)
Yan Zhao (3):
memory: drop guest writes to read-only ram device regions hw/vfio: drop guest writes to ro regions hw/vfio: let read-only flag take effect for mmap'd regions
hw/vfio/common.c | 17 +++++++++++++++-- memory.c | 15 ++++++++++++--- 2 files changed, 27 insertions(+), 5 deletions(-)
Signature · 1 line
2.17.1