Skip to content

btrfs-progs: tests: Enahance INSTRUMENT coverage

Qu Wenruo linux-btrfs 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest2 patches 3 repliesIn review
  2. v22 patches 4 repliesSuperseded

Changes in v3 from the cover letter

- Adding proper filtering for run_check_stdout() callers Instead of removing run_check_stdout(), to keep the coverage the same.

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2btrfs-progs: tests: Filter output for run_check_stdouttests/common tests/misc-tests/004-shrink-fs/test.sh tests/misc-tests/009-subvolume-sync-must-wait/test.sh +3 more+33 -203 replies
2/2btrfs-progs: tests: Introduce expand_command() to inject aruguments more accuratelytests/common+87 -890 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v3 yet.

Read the v3 thread

Cover letter [PATCH v3 0/2] btrfs-progs: tests: Enahance INSTRUMENT coverage

This patchset will enhance INSTRUMENT coverage for all btrfs related commands.

Since now INSTRUMENT would also cover a lot of btrfs inspect-dump comands, fix some test cases where INSTRUMENT output could easily pollute them.

Now fsck/convert/misc/mkfs all pass with
INSTRUMENT="valgrind --leak-check=full".

Changelog:
v2:
- Pass INSTRUMENT as space split command

- Unset previous cmmd_array in expand_command()
Instead of unsetting it.

- Use local variable @i in expand_command()
To fix misc/004

- Add extra commands for INSTRUMENT coverage
This incldues btrfstune, btrfs-corrupt-block, btrfs-image, btrfs-select-super, btrfs-find-root.

- Fix test cases which uses run_check_stdout without filtering

v3:
- Adding proper filtering for run_check_stdout() callers Instead of removing run_check_stdout(), to keep the coverage the same.

Qu Wenruo (2):
btrfs-progs: tests: Filter output for run_check_stdout
btrfs-progs: tests: Introduce expand_command() to inject aruguments
more accurately

 tests/common                                  | 189 +++++++++---------
 tests/misc-tests/004-shrink-fs/test.sh        |  11 +-
 .../009-subvolume-sync-must-wait/test.sh      |   2 +-
 .../013-subvolume-sync-crash/test.sh          |   2 +-
 .../024-inspect-internal-rootid/test.sh       |  21 +-
 .../031-qgroup-parent-child-relation/test.sh  |   4 +-
 6 files changed, 120 insertions(+), 109 deletions(-)
Signature · 1 line
2.26.0