Set up generic fbdev after registering device
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v2 Latest10 patches 2 repliesIn review
- v110 patches 16 repliesSuperseded
Changes in v2 from the cover letter
* warn in drm_fbdev_generic_setup() if device is unregistered (Jani)
* document the new behavior (Sam)
* fix mediatek subject (Noralf)
* keep kirin patch for now, even though the patched code will probably be removed
Patches in v2 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/10 | drm/ast: Set up fbdev after registering device; remove error checksdrivers/ drivers/ | +3 | 0 replies | |
| 2/10 | drm/hibmc: Remove error check from fbdev setupdrivers/ | +1 | 0 replies | |
| 3/10 | drm/kirin: Set up fbdev after fully registering devicedrivers/ | +2 | 0 replies | |
| 4/10 | drm/ingenic: Remove error check from fbdev setupdrivers/ | +1 | 0 replies | |
| 5/10 | drm/mediatek: Remove error check from fbdev setupdrivers/ | +1 | 0 replies | |
| 6/10 | drm/mgag200: Set up fbdev after registering device; remove error checksdrivers/ drivers/ | +2 | 0 replies | |
| 7/10 | drm/tilcdc: Set up fbdev after fully registering devicedrivers/ | +1 | 0 replies | |
| 8/10 | drm/udl: Remove error check from fbdev setupdrivers/ | +1 | 0 replies | |
| 9/10 | drm/vboxvideo: Set up fbdev after registering device; remove error checksdrivers/ | +2 | 0 replies | |
| 10/10 | drm/fb-helper: Remove return value from drm_fbdev_generic_setup()drivers/ include/ | +16 | 2 replies |
Reviews trailers per patch
All 10 patches have a Reviewed-by or Acked-by.
| Patch | Noralf Trønnes | Gerd Hoffmann | Paul Cercueil | Jyri Sarha | Sam Ravnborg |
|---|---|---|---|---|---|
| 1/10 | R-b | A-b | |||
| 2/10 | R-b | A-b | |||
| 3/10 | R-b | A-b | |||
| 4/10 | R-b | A-b | R-b | ||
| 5/10 | R-b | A-b | |||
| 6/10 | R-b | A-b | |||
| 7/10 | R-b | A-b | A-b | ||
| 8/10 | R-b | A-b | |||
| 9/10 | R-b | A-b | |||
| 10/10 | R-b | A-b | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 5 reviewers.
Cover letter [PATCH v2 00/10] Set up generic fbdev after registering device
Generic fbdev emulation is a DRM client. If possible, it should behave like userspace clients. Therefore it should not run before the driver registered the new DRM device. If the setup function fails, the driver should not report an error.
This is a follow-up patchset to the discussion at [1]. I went through all calls to drm_fbdev_generic_setup(), moved them to the final operation of their driver's probe function, and removed the return value.
Built on x86-64, aarch64 and arm. Tested with mgag200.
v2:
* warn in drm_fbdev_generic_setup() if device is unregistered (Jani)
* document the new behavior (Sam)
* fix mediatek subject (Noralf)
* keep kirin patch for now, even though the patched code will probably be removed
Thomas Zimmermann (10):
drm/ast: Set up fbdev after registering device; remove error checks drm/hibmc: Remove error check from fbdev setup drm/kirin: Set up fbdev after fully registering device drm/ingenic: Remove error check from fbdev setup drm/mediatek: Remove error check from fbdev setup drm/mgag200: Set up fbdev after registering device; remove error
checks
drm/tilcdc: Set up fbdev after fully registering device drm/udl: Remove error check from fbdev setup drm/vboxvideo: Set up fbdev after registering device; remove error
checks
drm/fb-helper: Remove return value from drm_fbdev_generic_setup()
drivers/gpu/drm/ast/ast_drv.c | 3 +++ drivers/gpu/drm/ast/ast_main.c | 5 ---- drivers/gpu/drm/drm_fb_helper.c | 25 ++++++++++--------- .../gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c | 6 +---- .../gpu/drm/hisilicon/kirin/kirin_drm_drv.c | 4 +-- drivers/gpu/drm/ingenic/ingenic-drm.c | 4 +-- drivers/gpu/drm/mediatek/mtk_drm_drv.c | 4 +-- drivers/gpu/drm/mgag200/mgag200_drv.c | 2 ++ drivers/gpu/drm/mgag200/mgag200_main.c | 4 --- drivers/gpu/drm/tilcdc/tilcdc_drv.c | 3 +-- drivers/gpu/drm/udl/udl_drv.c | 6 +---- drivers/gpu/drm/vboxvideo/vbox_drv.c | 6 ++--- include/drm/drm_fb_helper.h | 5 ++-- 13 files changed, 30 insertions(+), 47 deletions(-)
--
2.26.0
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel