virtio: alignment issues
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v8 Latest19 patches 4 repliesIn review
- v719 patches 2 repliesSuperseded
- v612 patches 1 replySuperseded
Earlier versions · 4
| Version | Posted | Patches | Replies | Status |
|---|---|---|---|---|
| v5 | 12 patches | 1 reply | Superseded | |
| v4 | 12 patches | 0 replies | Superseded | |
| v3 | 2 patches | 0 replies | Superseded | |
| v2 | 2 patches | 2 replies | Superseded |
Changes in v8 from the cover letter
typo fix
Patches in v8 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/19 | tools/virtio: define aligned attributetools/ | +1 | 0 replies | |
| 2/19 | tools/virtio: make asm/barrier.h self containedtools/ | +1 | 0 replies | |
| 3/19 | tools/virtio: define __KERNEL__tools/ | +1 | 0 replies | |
| 4/19 | virtio: add VIRTIO_RING_NO_LEGACYdrivers/ include/ | +5 | 0 replies | |
| 5/19 | virtgpu: pull in uaccess.hdrivers/ | +1 | 0 replies | |
| 6/19 | virtio-rng: pull in slab.hdrivers/ | +1 | 0 replies | |
| 7/19 | remoteproc: pull in slab.hdrivers/ | +1 | 1 reply | |
| 8/19 | virtio_input: pull in slab.hdrivers/ | +1 | 0 replies | |
| 9/19 | virtio: stop using legacy struct vring in kerneldrivers/ include/ include/ +2 more | +28 | 1 reply | |
| 10/19 | vhost: force spec specified alignment on typesdrivers/ include/ | +24 | 0 replies | |
| 11/19 | virtio: add legacy init/size APIsinclude/ | +18 | 0 replies | |
| 12/19 | virtio_ring: switch to virtio_legacy_init/sizedrivers/ | +9 | 0 replies | |
| 13/19 | tools/virtio: switch to virtio_legacy_init/sizetools/ tools/ tools/ | +15 | 0 replies | |
| 14/19 | vop: switch to virtio_legacy_init/sizedrivers/ drivers/ | +8 | 0 replies | |
| 15/19 | remoteproc: switch to virtio_legacy_init/sizedrivers/ drivers/ | +2 | 1 reply | |
| 16/19 | mellanox: switch to virtio_legacy_init/sizedrivers/ | +3 | 0 replies | |
| 17/19 | vhost: option to fetch descriptors through an independent structdrivers/ drivers/ | +312 | 0 replies | |
| 18/19 | vhost: use batched version by defaultdrivers/ drivers/ | +2 | 0 replies | |
| 19/19 | vhost: batching fetchesdrivers/ drivers/ drivers/ | +47 | 0 replies |
Reviews trailers per patch
5 of 19 patches have a Reviewed-by or Acked-by.
| Patch | Andy Shevchenko | Ashutosh Dixit | Bjorn Andersson | Stefan Hajnoczi |
|---|---|---|---|---|
| 1/19 | ||||
| 2/19 | ||||
| 3/19 | ||||
| 4/19 | ||||
| 5/19 | ||||
| 6/19 | ||||
| 7/19 | A-b | |||
| 8/19 | ||||
| 9/19 | R-b | |||
| 10/19 | ||||
| 11/19 | ||||
| 12/19 | ||||
| 13/19 | ||||
| 14/19 | A-b | |||
| 15/19 | A-b | |||
| 16/19 | A-b | |||
| 17/19 | ||||
| 18/19 | ||||
| 19/19 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 4 reviewers.
Cover letter [PATCH v8 00/19] virtio: alignment issues
This is an alternative to
vhost: force spec specified alignment on types
which is a bit safer as it does not change UAPI. I still think it's best to change the UAPI header as well, we can do that as a follow-up cleanup.
changes from v7:
typo fix
changes from v6:
add missing header includes all over the place
changes from v5:
ack for mellanox patch
fixup to remoteproc
changes from v4:
fixup to issues reported by kbuild
changes from v3:
tools/virtio fixes
a bunch more cleanups that now become possible
Changes from v2:
don't change struct name, instead add ifndef so kernel does not see the legacy UAPI version.
Jason, can you pls ack one of the approaches?
Matej Genci (1):
virtio: add VIRTIO_RING_NO_LEGACY
Michael S. Tsirkin (18):
tools/virtio: define aligned attribute
tools/virtio: make asm/barrier.h self contained tools/virtio: define __KERNEL__
virtgpu: pull in uaccess.h
virtio-rng: pull in slab.h
remoteproc: pull in slab.h
virtio_input: pull in slab.h
virtio: stop using legacy struct vring in kernel
vhost: force spec specified alignment on types
virtio: add legacy init/size APIs
virtio_ring: switch to virtio_legacy_init/size tools/virtio: switch to virtio_legacy_init/size
vop: switch to virtio_legacy_init/size
remoteproc: switch to virtio_legacy_init/size
mellanox: switch to virtio_legacy_init/size
vhost: option to fetch descriptors through an independent struct
vhost: use batched version by default
vhost: batching fetches
drivers/block/virtio_blk.c | 1 + drivers/char/hw_random/virtio-rng.c | 1 + drivers/gpu/drm/virtio/virtgpu_ioctl.c | 1 + drivers/misc/mic/vop/vop_main.c | 5 +- drivers/misc/mic/vop/vop_vringh.c | 8 +- drivers/platform/mellanox/mlxbf-tmfifo.c | 6 +- drivers/remoteproc/remoteproc_core.c | 2 +- drivers/remoteproc/remoteproc_sysfs.c | 1 + drivers/remoteproc/remoteproc_virtio.c | 2 +- drivers/vhost/test.c | 2 +- drivers/vhost/vhost.c | 271 +++++++++++++++-------- drivers/vhost/vhost.h | 23 +- drivers/virtio/virtio_input.c | 1 + drivers/virtio/virtio_pci_modern.c | 1 + drivers/virtio/virtio_ring.c | 15 +- include/linux/virtio.h | 1 - include/linux/virtio_ring.h | 46 ++++ include/linux/vringh.h | 1 + include/uapi/linux/virtio_ring.h | 30 ++- tools/virtio/Makefile | 2 +- tools/virtio/asm/barrier.h | 1 + tools/virtio/linux/compiler.h | 1 + tools/virtio/ringtest/virtio_ring_0_9.c | 6 +- tools/virtio/virtio_test.c | 6 +- tools/virtio/vringh_test.c | 18 +- 25 files changed, 311 insertions(+), 141 deletions(-)
Signature · 1 line
MST