Skip to content

btrfs: Reformat and make btrfs_tree.h self-contained

Qu Wenruo linux-btrfs oe-kbuild-all 4 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v4 Latest2 patches 8 repliesIn review
  2. v31 patch 2 repliesSuperseded
  3. v21 patch 0 repliesSuperseded
Earlier versions · 1
VersionPostedPatchesRepliesStatus
v11 patch1 replySuperseded

Changes in v4 from the cover letter

- Update btrfs_tree.h comment style
- Update btrfs_tree.h header define line
- Move enum btrfs_compression_type to btrfs_tree.h

Patches in v4 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2btrfs: Move on-disk structure definition to btrfs_tree.hfs/btrfs/compression.h fs/btrfs/ctree.h include/uapi/linux/btrfs.h +1 more+336 -3316 replies
2/2btrfs: Reformat btrfs_tree.h commentsinclude/uapi/linux/btrfs_tree.h+232 -2232 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v4 yet.

Read the v4 thread

Cover letter [PATCH v4 0/2] btrfs: Reformat and make btrfs_tree.h self-contained

Before this patch, although btrfs_tree.h contains most of needed structures for one to read on-disk btrfs data, it still has some missing parts:
- Missing some structures and flags
Like btrfs_super_block, and BTRFS_INODE_* flags

- Not self-contained
It still needs to include <linux/btrfs.h>

- Uses old/deprecated comment style

This patchset will first move on-disk structure definition to btrfs_tree.h first, making it self-contained.

Then reformat btrfs_tree.h to make it follow current comment style.

This patchset is mostly designed for incoming projects like U-boot to share the kernel definitions more easily.

Changelog:
v2:
- Add the reason why we move the code

v3:
- Move more flags/enum shared with ioctl to btrfs_btree.h This makes ioctl header to rely on btree_btree.h.
But this makes btrfs_tree.h completely self-consistent. This problem is mostly exposed when syncing the header to btrfs-progs.

v4:
- Update btrfs_tree.h comment style
- Update btrfs_tree.h header define line
- Move enum btrfs_compression_type to btrfs_tree.h

Qu Wenruo (2):
btrfs: Move on-disk structure definition to btrfs_tree.h
btrfs: Reformat btrfs_tree.h comments

 fs/btrfs/compression.h          |   9 +-
 fs/btrfs/ctree.h                | 246 -----------
 include/uapi/linux/btrfs.h      |  74 +---
 include/uapi/linux/btrfs_tree.h | 721 +++++++++++++++++++++++---------
 4 files changed, 532 insertions(+), 518 deletions(-)
Signature · 1 line
2.26.0