Skip to content

Improvements to EFI console and terminal drivers for Flicker Free Boot

Javier Martinez Canillas grub-devel 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest6 patches 1 replyIn review
  2. v26 patches 4 repliesSuperseded

Changes in v3 from the cover letter

- Make grub_console_read_key_stroke() return GRUB_ERR_NONE instead of 0.
- Make grub_prepare_for_text_output() return GRUB_ERR_NONE instead of 0.
- Code style cleanups.
- Fix a left over in the documentation.

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/6efi/console: Move grub_console_set{colorstate, cursor} higher in the filegrub-core/term/efi/console.c+41 -410 replies
2/6kern/term: Make grub_getkeystatus helper function available everywheregrub-core/commands/keystatus.c grub-core/kern/term.c include/grub/term.h+19 -180 replies
3/6efi/console: Add grub_console_read_key_stroke() helper functiongrub-core/term/efi/console.c+42 -120 replies
4/6efi/console: Implement getkeystatus() supportgrub-core/term/efi/console.c+34 -00 replies
5/6efi/console: Do not set text-mode until we actually need itgrub-core/term/efi/console.c include/grub/term.h+51 -270 replies
6/6kern/term: Accept ESC, F4 and holding SHIFT as user interrupt keysdocs/grub.texi grub-core/commands/sleep.c grub-core/kern/term.c +2 more+41 -180 replies

Reviews trailers per patch

All 6 patches have a Reviewed-by or Acked-by.

PatchDaniel Kiper
1/6R-b
2/6R-b
3/6R-b
4/6R-b
5/6R-b
6/6R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [PATCH v3 0/6] Improvements to EFI console and terminal drivers for Flicker Free Boot

Hello,

This is a v3 of a patch-set that contains improvements for the EFI console and terminal drivers that allows to avoid the switch to text-mode until is needed.

This is part of the patches we have in Fedora to support the Flicker Free Boot feature [1], which allows to have a seamless boot experience with no graphical transitions that aren't necessary. More info can be found in Hans' blog [2,3].

We have additional patches for this feature, for example template changes that makes hiding the menu only when the previous boot was successful, and to make GRUB less noisy and not print unnecessary output. But those will be posted in the future once the paches on this set land.

[1]: https://fedoraproject.org/wiki/Changes/FlickerFreeBoot
[2]: https://hansdegoede.livejournal.com/19224.html
[3]: https://hansdegoede.livejournal.com/20632.html

Best regards,
Javier

Changes in v3:
- Make grub_console_read_key_stroke() return GRUB_ERR_NONE instead of 0.
- Make grub_prepare_for_text_output() return GRUB_ERR_NONE instead of 0.
- Code style cleanups.
- Fix a left over in the documentation.

Changes in v2:
- Mention in commit message that logic is unchanged after patch #1.
- Add better explanation about why the change in patch #1 is needed.
- Also mention in commit message that logic is unchanged after patch #2.
- Explain why the helper function needs to be available for other modules.
- Move patch #2 earlier in the patch-set since is a proparatory change.
- Explain why the getkeystatus() handler is needed for the EFI console driver.
- Code style cleanups.
- Fix commit message that had left overs from when F8 was used instead of F4.
- Update documentation to explain that F4 and SHIFT are used now besides ESC.
- Also fix comments to reflect that F4 is used now and use proper style.

Hans de Goede (5):
kern/term: Make grub_getkeystatus helper function available everywhere efi/console: Add grub_console_read_key_stroke() helper function efi/console: Implement getkeystatus() support
efi/console: Do not set text-mode until we actually need it kern/term: Accept ESC, F4 and holding SHIFT as user interrupt keys

Javier Martinez Canillas (1):
efi/console: Move grub_console_set{colorstate,cursor} higher in the
file

 docs/grub.texi                 |  33 ++---
 grub-core/commands/keystatus.c |  18 ---
 grub-core/commands/sleep.c     |   2 +-
 grub-core/kern/term.c          |  39 ++++++
 grub-core/normal/menu.c        |   2 +-
 grub-core/term/efi/console.c   | 244 ++++++++++++++++++++++-----------
 include/grub/term.h            |   6 +-
 7 files changed, 228 insertions(+), 116 deletions(-)
Signature · 1 line
2.25.1