Skip to content

iommu: Move iommu_group setup to IOMMU core code

Joerg Roedel linux-arm-msm linux-iommu linux-mediatek linux-rockchip linux-s390 linux-samsung-soc linux-tegra lkml virtualization 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest34 patches 9 repliesIn review
  2. v233 patches 38 repliesSuperseded
  3. v1 RFC34 patches 11 repliesSuperseded

Changes in v3 from the cover letter

* Rebased v5.7-rc3

* Added a missing iommu_group_put() as reported by Lu Baolu.

* Added a patch to consolidate more initialization work in __iommu_probe_device(), fixing a bug where no 'struct device_iommu' was allocated in the hotplug path.

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/34iommu: Move default domain allocation to separate functiondrivers/iommu/iommu.c+45 -290 replies
2/34iommu: Add def_domain_type() callback in iommu_opsdrivers/iommu/iommu.c include/linux/iommu.h+23 -30 replies
3/34iommu/amd: Implement iommu_ops->def_domain_type call-backdrivers/iommu/amd_iommu.c+15 -00 replies
4/34iommu/vt-d: Wire up iommu_ops->def_domain_typedrivers/iommu/intel-iommu.c+1 -01 reply
5/34iommu/amd: Remove dma_mask check from check_device()drivers/iommu/amd_iommu.c+1 -10 replies
6/34iommu/amd: Return -ENODEV in add_device when device is not handled by IOMMUdrivers/iommu/amd_iommu.c+4 -10 replies
7/34iommu: Add probe_device() and release_device() call-backsdrivers/iommu/iommu.c include/linux/iommu.h+66 -62 replies
8/34iommu: Move default domain allocation to iommu_probe_device()drivers/iommu/iommu.c+71 -310 replies
9/34iommu: Keep a list of allocated groups in __iommu_probe_device()drivers/iommu/iommu.c+7 -20 replies
10/34iommu: Move new probe_device path to separate functiondrivers/iommu/iommu.c+46 -230 replies
11/34iommu: Split off default domain allocation from group assignmentdrivers/iommu/iommu.c+151 -30 replies
12/34iommu: Move iommu_group_create_direct_mappings() out of iommu_group_add_device()drivers/iommu/iommu.c+30 -50 replies
13/34iommu: Export bus_iommu_probe() and make is safe for re-probingdrivers/iommu/iommu.c include/linux/iommu.h+10 -10 replies
14/34iommu/amd: Remove dev_data->passthroughdrivers/iommu/amd_iommu.c drivers/iommu/amd_iommu_types.h+5 -60 replies
15/34iommu/amd: Convert to probe/release_device() call-backsdrivers/iommu/amd_iommu.c+22 -490 replies
16/34iommu/vt-d: Convert to probe/release_device() call-backsdrivers/iommu/intel-iommu.c+6 -611 reply
17/34iommu/arm-smmu: Convert to probe/release_device() call-backsdrivers/iommu/arm-smmu-v3.c drivers/iommu/arm-smmu.c+25 -520 replies
18/34iommu/pamu: Convert to probe/release_device() call-backsdrivers/iommu/fsl_pamu_domain.c+5 -170 replies
19/34iommu/s390: Convert to probe/release_device() call-backsdrivers/iommu/s390-iommu.c+6 -160 replies
20/34iommu/virtio: Convert to probe/release_device() call-backsdrivers/iommu/virtio-iommu.c+10 -310 replies
21/34iommu/msm: Convert to probe/release_device() call-backsdrivers/iommu/msm_iommu.c+7 -270 replies
22/34iommu/mediatek: Convert to probe/release_device() call-backsdrivers/iommu/mtk_iommu.c+6 -180 replies
23/34iommu/mediatek-v1 Convert to probe/release_device() call-backsdrivers/iommu/mtk_iommu_v1.c+20 -300 replies
24/34iommu/qcom: Convert to probe/release_device() call-backsdrivers/iommu/qcom_iommu.c+7 -170 replies
25/34iommu/rockchip: Convert to probe/release_device() call-backsdrivers/iommu/rockchip-iommu.c+7 -190 replies
26/34iommu/tegra: Convert to probe/release_device() call-backsdrivers/iommu/tegra-gart.c drivers/iommu/tegra-smmu.c+14 -410 replies
27/34iommu/renesas: Convert to probe/release_device() call-backsdrivers/iommu/ipmmu-vmsa.c+20 -400 replies
28/34iommu/omap: Remove orphan_dev trackingdrivers/iommu/omap-iommu.c+4 -500 replies
29/34iommu/omap: Convert to probe/release_device() call-backsdrivers/iommu/omap-iommu.c+13 -360 replies
30/34iommu/exynos: Use first SYSMMU in controllers list for IOMMU coredrivers/iommu/exynos-iommu.c+10 -00 replies
31/34iommu/exynos: Convert to probe/release_device() call-backsdrivers/iommu/exynos-iommu.c+6 -200 replies
32/34iommu: Remove add_device()/remove_device() code-pathsdrivers/iommu/iommu.c include/linux/iommu.h+38 -1240 replies
33/34iommu: Move more initialization to __iommu_probe_device()drivers/iommu/iommu.c+18 -290 replies
34/34iommu: Unexport iommu_group_get_for_dev()drivers/iommu/iommu.c include/linux/iommu.h+2 -30 replies

Reviews trailers per patch

16 of 34 patches have a Reviewed-by or Acked-by.

PatchMarek SzyprowskiLu Baolu
1/34T-b A-b
2/34T-b A-b
3/34
4/34R-b
5/34
6/34
7/34T-b A-b
8/34T-b A-b
9/34T-b A-b
10/34T-b A-b
11/34T-b A-b
12/34T-b A-b
13/34T-b A-b
14/34
15/34
16/34R-b
17/34
18/34
19/34
20/34
21/34
22/34
23/34
24/34
25/34
26/34
27/34
28/34
29/34
30/34T-b A-b
31/34T-b A-b
32/34T-b A-b
33/34T-b A-b
34/34T-b A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [PATCH v3 00/34] iommu: Move iommu_group setup to IOMMU core code

Hi,

here is the third version of this patch-set. Older versions can be found here:

	v1: https://lore.kernel.org/lkml/20200407183742.4344-1-joro-zLv9SwRftAIdnm+yROfE0A@public.gmane.org/
	    (Has some more introductory text)

	v2: https://lore.kernel.org/lkml/20200414131542.25608-1-joro-zLv9SwRftAIdnm+yROfE0A@public.gmane.org/

Changes v2 -> v3:

* Rebased v5.7-rc3

* Added a missing iommu_group_put() as reported by Lu Baolu.

* Added a patch to consolidate more initialization work in __iommu_probe_device(), fixing a bug where no 'struct device_iommu' was allocated in the hotplug path.

There is also a git-branch available with these patches applied:

https://git.kernel.org/pub/scm/linux/kernel/git/joro/linux.git/log/?h=iommu-probe-device-v3

Please review. If there are no objections I plan to put these patches into the IOMMU tree early next week.

Thanks,

Joerg

Joerg Roedel (33):
iommu: Move default domain allocation to separate function iommu/amd: Implement iommu_ops->def_domain_type call-back iommu/vt-d: Wire up iommu_ops->def_domain_type
iommu/amd: Remove dma_mask check from check_device() iommu/amd: Return -ENODEV in add_device when device is not handled by
IOMMU
iommu: Add probe_device() and release_device() call-backs
iommu: Move default domain allocation to iommu_probe_device()
iommu: Keep a list of allocated groups in __iommu_probe_device()
iommu: Move new probe_device path to separate function
iommu: Split off default domain allocation from group assignment
iommu: Move iommu_group_create_direct_mappings() out of
iommu_group_add_device()
iommu: Export bus_iommu_probe() and make is safe for re-probing iommu/amd: Remove dev_data->passthrough
iommu/amd: Convert to probe/release_device() call-backs iommu/vt-d: Convert to probe/release_device() call-backs iommu/arm-smmu: Convert to probe/release_device() call-backs iommu/pamu: Convert to probe/release_device() call-backs iommu/s390: Convert to probe/release_device() call-backs iommu/virtio: Convert to probe/release_device() call-backs iommu/msm: Convert to probe/release_device() call-backs iommu/mediatek: Convert to probe/release_device() call-backs iommu/mediatek-v1 Convert to probe/release_device() call-backs iommu/qcom: Convert to probe/release_device() call-backs iommu/rockchip: Convert to probe/release_device() call-backs iommu/tegra: Convert to probe/release_device() call-backs iommu/renesas: Convert to probe/release_device() call-backs iommu/omap: Remove orphan_dev tracking
iommu/omap: Convert to probe/release_device() call-backs iommu/exynos: Use first SYSMMU in controllers list for IOMMU core iommu/exynos: Convert to probe/release_device() call-backs
iommu: Remove add_device()/remove_device() code-paths
iommu: Move more initialization to __iommu_probe_device()
iommu: Unexport iommu_group_get_for_dev()

Sai Praneeth Prakhya (1):
iommu: Add def_domain_type() callback in iommu_ops

 drivers/iommu/amd_iommu.c       |  97 ++++----
 drivers/iommu/amd_iommu_types.h |   1 -
 drivers/iommu/arm-smmu-v3.c     |  38 +---
 drivers/iommu/arm-smmu.c        |  39 ++--
 drivers/iommu/exynos-iommu.c    |  24 +-
 drivers/iommu/fsl_pamu_domain.c |  22 +-
 drivers/iommu/intel-iommu.c     |  68 +-----
 drivers/iommu/iommu.c           | 387 +++++++++++++++++++++++++-------
 drivers/iommu/ipmmu-vmsa.c      |  60 ++---
 drivers/iommu/msm_iommu.c       |  34 +--
 drivers/iommu/mtk_iommu.c       |  24 +-
 drivers/iommu/mtk_iommu_v1.c    |  50 ++---
 drivers/iommu/omap-iommu.c      |  99 ++------
 drivers/iommu/qcom_iommu.c      |  24 +-
 drivers/iommu/rockchip-iommu.c  |  26 +--
 drivers/iommu/s390-iommu.c      |  22 +-
 drivers/iommu/tegra-gart.c      |  24 +-
 drivers/iommu/tegra-smmu.c      |  31 +--
 drivers/iommu/virtio-iommu.c    |  41 +---
 include/linux/iommu.h           |  21 +-
 20 files changed, 531 insertions(+), 601 deletions(-)
Signature · 1 line
2.17.1