Skip to content

ceph: fix error handling bugs in async dirops callbacks

Jeff Layton ceph-devel 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest2 patches 8 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2ceph: have ceph_mdsc_free_path ignore ERR_PTR valuesfs/ceph/debugfs.c fs/ceph/mds_client.c fs/ceph/mds_client.h+3 -98 replies
2/2ceph: initialize base and pathlen variables in async dirops cb'sfs/ceph/dir.c fs/ceph/file.c+4 -40 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/2] ceph: fix error handling bugs in async dirops callbacks

This fixes a couple of problems that Dan spotted with a static checker. Additionally the first patch also simplifies some of the error handling in other callers.

Originally, I was going to squash these into the earlier patches that introduced those bugs, but this is new code that isn't enabled by default and Ilya was planning to a PR soon, so it's probably best to just handle them as follow-on fixes to what's currently in ceph-client/master.

Jeff Layton (2):
ceph: have ceph_mdsc_free_path ignore ERR_PTR values
ceph: initialize base and pathlen variables in async dirops cb's

 fs/ceph/debugfs.c    | 4 ----
 fs/ceph/dir.c        | 4 ++--
 fs/ceph/file.c       | 4 ++--
 fs/ceph/mds_client.c | 6 ++----
 fs/ceph/mds_client.h | 2 +-
 5 files changed, 7 insertions(+), 13 deletions(-)
Signature · 1 line
2.25.2