Skip to content

gpio: dwapb: Clean up the driver and a fix

Andy Shevchenko linux-gpio 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest14 patches 19 repliesIn review
  2. v113 patches 17 repliesSuperseded

Changes in v2 from the cover letter

- added Tested-by and Reviewed-by tags (Serge)
- split IRQ refactoring patch to two (Serge)
- update hwirq variable type to be irq_hw_number_t

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/14gpio: dwapb: Append MODULE_ALIAS for platform driverdrivers/gpio/gpio-dwapb.c+6 -30 replies
2/14gpio: dwapb: Refactor IRQ handler to use bit operationsdrivers/gpio/gpio-dwapb.c+7 -80 replies
3/14gpio: dwapb: Use chained IRQ prologue and epiloguedrivers/gpio/gpio-dwapb.c+2 -30 replies
4/14gpio: dwapb: set default handler to be handle_bad_irq()drivers/gpio/gpio-dwapb.c+2 -10 replies
5/14gpio: dwapb: Deduplicate IRQ resource managementdrivers/gpio/gpio-dwapb.c+0 -270 replies
6/14gpio: dwapb: Convert to use irqd_to_hwirq()drivers/gpio/gpio-dwapb.c+9 -71 reply
7/14gpio: dwapb: Use device_get_match_data() to simplify codedrivers/gpio/gpio-dwapb.c+1 -120 replies
8/14gpio: dwapb: Convert to use IRQ core provided macrosdrivers/gpio/gpio-dwapb.c+2 -84 replies
9/14gpio: dwapb: Switch to more usual pattern of RMW in dwapb_gpio_set_debounce()drivers/gpio/gpio-dwapb.c+3 -20 replies
10/14gpio: dwapb: Drop bogus BUG_ON()sdrivers/gpio/gpio-dwapb.c+0 -40 replies
11/14gpio: dwapb: Drop of_match_ptr() & ACPI_PTR() callsdrivers/gpio/gpio-dwapb.c+2 -20 replies
12/14gpio: dwapb: Split out dwapb_get_irq() helperdrivers/gpio/gpio-dwapb.c+29 -270 replies
13/14gpio: dwapb: Use positive conditional in dwapb_configure_irqs()drivers/gpio/gpio-dwapb.c+9 -96 replies
14/14gpio: dwapb: Amend indentation in some casesdrivers/gpio/gpio-dwapb.c+9 -157 replies

Reviews trailers per patch

12 of 14 patches have a Reviewed-by or Acked-by.

PatchSerge Semin
1/14T-b R-b
2/14T-b R-b
3/14T-b R-b
4/14T-b R-b
5/14T-b R-b
6/14T-b R-b
7/14T-b R-b
8/14T-b R-b
9/14T-b R-b
10/14T-b R-b
11/14T-b R-b
12/14T-b R-b
13/14T-b
14/14T-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 00/14] gpio: dwapb: Clean up the driver and a fix

It appears that GPIO DW APB driver wasn't touched for a long time. Here is the fix for long standing issue, i.e. missed module alias to make the driver be loaded automatically.

On top of above a lot small clean ups here and there.

The series based on the v3 by Serge Semin which he sent earlier.

Driver has been tested on Intel Galileo Gen2 with AT25 SPI EEPROM using it for a chip select.

Changelog since v1:
- added Tested-by and Reviewed-by tags (Serge)
- split IRQ refactoring patch to two (Serge)
- update hwirq variable type to be irq_hw_number_t

Cc Serge Semin <[email protected]>

Andy Shevchenko (14):
gpio: dwapb: Append MODULE_ALIAS for platform driver
gpio: dwapb: Refactor IRQ handler to use bit operations
gpio: dwapb: Use chained IRQ prologue and epilogue
gpio: dwapb: set default handler to be handle_bad_irq()
gpio: dwapb: Deduplicate IRQ resource management
gpio: dwapb: Convert to use irqd_to_hwirq()
gpio: dwapb: Use device_get_match_data() to simplify code
gpio: dwapb: Convert to use IRQ core provided macros
gpio: dwapb: Switch to more usual pattern of RMW in
dwapb_gpio_set_debounce()
gpio: dwapb: Drop bogus BUG_ON()s
gpio: dwapb: Drop of_match_ptr() & ACPI_PTR() calls
gpio: dwapb: Split out dwapb_get_irq() helper
gpio: dwapb: Use positive conditional in dwapb_configure_irqs()
gpio: dwapb: Amend indentation in some cases

 drivers/gpio/gpio-dwapb.c | 205 +++++++++++++++-----------------------
 1 file changed, 79 insertions(+), 126 deletions(-)
Signature · 1 line
2.25.1