Skip to content

qemu-option: Fix corner cases and clean up

Markus Armbruster qemu-devel 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest9 patches 4 repliesIn review
  2. v18 patches 32 repliesSuperseded

Changes in v2 from the cover letter

* PATCH 1,4,5: Cover "?" in addition to "help" [Kevin]
* PATCH 4-6: Old PATCH 4 moved after old PATCH 5+6, commit message adjusted
* PATCH 4: Unbreak "?" [Eric]
* PATCH 8: Commit message tweaked
* PATCH 9: New

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/9tests-qemu-opts: Cover has_help_option(), qemu_opt_has_help_opt()tests/test-qemu-opts.c+44 -01 reply
2/9qemu-options: Factor out get_opt_name_value() helperutil/qemu-option.c+56 -460 replies
3/9qemu-option: Fix sloppy recognition of "id=..." after ", , "tests/test-qemu-opts.c util/qemu-option.c+21 -100 replies
4/9qemu-option: Fix has_help_option()'s sloppy parsingtests/test-qemu-opts.c util/qemu-option.c+21 -221 reply
5/9test-qemu-opts: Simplify test_has_help_option() after bug fixtests/test-qemu-opts.c+17 -190 replies
6/9qemu-option: Avoid has_help_option() in qemu_opts_parse_noisily()util/qemu-option.c+10 -100 replies
7/9qemu-img: Factor out accumulate_options() helperqemu-img.c+23 -360 replies
8/9qemu-img: Move is_valid_option_list() to qemu-img.c and rewriteinclude/qemu/option.h qemu-img.c util/qemu-option.c+26 -230 replies
9/9qemu-img: Reject broken -o ""qemu-img.c+4 -21 reply

Reviews trailers per patch

All 9 patches have a Reviewed-by or Acked-by.

PatchEric BlakeKevin Wolf
1/9R-b
2/9R-b R-b
3/9R-b R-b
4/9R-b
5/9R-b R-b
6/9R-b
7/9R-b R-b
8/9R-b
9/9R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 for-5.1 0/9] qemu-option: Fix corner cases and clean up

v2:
* PATCH 1,4,5: Cover "?" in addition to "help" [Kevin]
* PATCH 4-6: Old PATCH 4 moved after old PATCH 5+6, commit message adjusted
* PATCH 4: Unbreak "?" [Eric]
* PATCH 8: Commit message tweaked
* PATCH 9: New

Markus Armbruster (9):
tests-qemu-opts: Cover has_help_option(), qemu_opt_has_help_opt()
qemu-options: Factor out get_opt_name_value() helper
qemu-option: Fix sloppy recognition of "id=..." after ",,"
qemu-option: Fix has_help_option()'s sloppy parsing
test-qemu-opts: Simplify test_has_help_option() after bug fix
qemu-option: Avoid has_help_option() in qemu_opts_parse_noisily()
qemu-img: Factor out accumulate_options() helper
qemu-img: Move is_valid_option_list() to qemu-img.c and rewrite
qemu-img: Reject broken -o ""

 include/qemu/option.h  |   1 -
 qemu-img.c             |  87 ++++++++++-------
 tests/test-qemu-opts.c |  46 ++++++++-
 util/qemu-option.c     | 210 ++++++++++++++++++++---------------------
 4 files changed, 199 insertions(+), 145 deletions(-)
Signature · 1 line
2.21.1