Skip to content

Consolidate the thermal_cdev_update() function

Daniel Lezcano linux-hwmon linux-pm lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest6 patches 4 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/6thermal: hwmon: Replace the call the thermal_cdev_update()drivers/hwmon/pwm-fan.c+1 -24 replies
2/6thermal: core: Move thermal_cdev_update next to updated=falsedrivers/thermal/gov_bang_bang.c drivers/thermal/step_wise.c+2 -180 replies
3/6thermal: core: Remove pointless 'updated' booleandrivers/thermal/fair_share.c drivers/thermal/gov_bang_bang.c drivers/thermal/power_allocator.c +4 more+0 -230 replies
4/6thermal: power_allocator: Remove useless testdrivers/thermal/power_allocator.c+2 -30 replies
5/6thermal: core: Move the call to thermal_cdev_udpate() to the power allocatordrivers/thermal/power_allocator.c drivers/thermal/thermal_core.c+2 -10 replies
6/6thermal: core: Make thermal_cdev_update privatedrivers/thermal/thermal_core.h include/linux/thermal.h+1 -30 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/6] Consolidate the thermal_cdev_update() function

This series does the following changes:

- Moves the calls to thermal_cdev_update() in the throttle governor's path

- Reduce the scope of the function to the thermal framework internals

After these changes, all the calls to thermal_cdev_update() are located in the throttle governor path, setting the scene to move the call to a single place, close to the concentrator function thermal_zone_device_update().

The micro optimization to not invoke multiple times the cooling device update is lost at the moment but it will be regain when the call will be moved to the core.

Daniel Lezcano (6):
thermal: hwmon: Replace the call the thermal_cdev_update()
thermal: core: Move thermal_cdev_update next to updated=false
thermal: core: Remove pointless 'updated' boolean
thermal: power_allocator: Remove useless test
thermal: core: Move the call to thermal_cdev_udpate() to the power
allocator
thermal: core: Make thermal_cdev_update private

 drivers/hwmon/pwm-fan.c           |  3 +--
 drivers/thermal/fair_share.c      |  3 ---
 drivers/thermal/gov_bang_bang.c   | 13 +------------
 drivers/thermal/power_allocator.c | 10 ++++------
 drivers/thermal/step_wise.c       | 13 +------------
 drivers/thermal/thermal_core.c    |  5 -----
 drivers/thermal/thermal_core.h    |  1 +
 drivers/thermal/thermal_helpers.c |  6 ------
 include/linux/thermal.h           |  4 ----
 9 files changed, 8 insertions(+), 50 deletions(-)
Signature · 1 line
2.17.1