Skip to content

Fixes for deferred_probe_timeout cleanup

John Stultz linux-pm linux-samsung-soc linux-tegra lkml netdev 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest3 patches 10 repliesIn review
  2. v22 patches 2 repliesSuperseded

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3driver core: Revert default driver_deferred_probe_timeout value to 0drivers/base/dd.c+2 -118 replies
2/3driver core: Use dev_warn() instead of dev_WARN() for deferred_probe_timeout warningsdrivers/base/dd.c+1 -11 reply
3/3driver core: Ensure wait_for_device_probe() waits until the deferred_probe_timeout firesdrivers/base/dd.c+5 -01 reply

Reviews trailers per patch

1 of 3 patches has a Reviewed-by or Acked-by.

PatchYoshihiro ShimodaGeert Uytterhoeven
1/3T-b T-b
2/3R-b
3/3T-b T-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [PATCH v3 0/3] Fixes for deferred_probe_timeout cleanup

Just wanted to resubmit these three fixes for the deferred_probe_timeout cleanup that landed in the v5.7-rc1 merge window.

The first resets the default timeout value back to zero so we have no behavioral change from 5.6. This avoids regressions on boards that have "optional links" in their device tree.

The second changes the code to use dev_warn() instead of dev_WARN() to address complaints about unnecessary backtraces in the boot log.

The last fixes an issue discovered by Yoshihiro Shimoda and Geert Uytterhoeven, where if a timeout was set, things like NFS root might fail due to wait_for_device_probe() not blocking until the timeout expires.

thanks
-john

New in v3:
* Just included the previously posted dev_warn() fix into the series, so they didn't collide.

Cc "David S. Miller" <[email protected]>
Cc Alexey Kuznetsov <[email protected]>
Cc Hideaki YOSHIFUJI <[email protected]>
Cc Jakub Kicinski <[email protected]>
Cc Greg Kroah-Hartman <[email protected]>
Cc Rafael J. Wysocki <[email protected]>
Cc Rob Herring <[email protected]>
Cc Geert Uytterhoeven <[email protected]>
Cc Yoshihiro Shimoda <[email protected]>
Cc Robin Murphy <[email protected]>
Cc Andy Shevchenko <[email protected]>
Cc Sudeep Holla <[email protected]>
Cc Andy Shevchenko <[email protected]>
Cc Naresh Kamboju <[email protected]>
Cc Basil Eljuse <[email protected]>
Cc Ferry Toth <[email protected]>
Cc Arnd Bergmann <[email protected]>
Cc Anders Roxell <[email protected]>
Cc netdev <[email protected]>

John Stultz (3):
driver core: Revert default driver_deferred_probe_timeout value to 0 driver core: Use dev_warn() instead of dev_WARN() for
deferred_probe_timeout warnings
driver core: Ensure wait_for_device_probe() waits until the
deferred_probe_timeout fires

 drivers/base/dd.c | 20 ++++++++------------
 1 file changed, 8 insertions(+), 12 deletions(-)
Signature · 1 line
2.17.1