KVM: arm: vgic fixes for 5.7
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v3 Latest6 patches 8 repliesIn review
- v26 patches 8 repliesSuperseded
- v13 patches 4 repliesSuperseded
Patches in v3 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/6 | KVM: arm: vgic: Fix limit condition when writing to GICD_I[CS]ACTIVERvirt/ | +2 | 0 replies | |
| 2/6 | KVM: arm: vgic: Synchronize the whole guest on GIC{D,R}_I{S,C}ACTIVER readvirt/ virt/ virt/ +1 more | +75 | 0 replies | |
| 3/6 | KVM: arm: vgic: Only use the virtual state when userspace accesses enable bitsvirt/ virt/ virt/ +1 more | +64 | 0 replies | |
| 4/6 | KVM: arm: vgic-v2: Only use the virtual state when userspace accesses pending bitsvirt/ virt/ virt/ | +76 | 1 reply | |
| 5/6 | KVM: arm64: vgic-v3: Retire all pending LPIs on vcpu destroyvirt/ | +6 | 7 replies | |
| 6/6 | KVM: arm64: vgic-its: Fix memory leak on the error path of vgic_add_lpi()virt/ | +9 | 0 replies |
Reviews trailers per patch
4 of 6 patches have a Reviewed-by or Acked-by.
| Patch | Andre Przywara | James Morse |
|---|---|---|
| 1/6 | ||
| 2/6 | R-b | |
| 3/6 | T-b R-b | |
| 4/6 | R-b | |
| 5/6 | R-b | |
| 6/6 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH v3 0/6] KVM: arm: vgic fixes for 5.7
Here's a few vgic fixes I've been piling on during the merge window, plus a couple that Zenghui contributed, and which I added to the mix.
The first patch is a silly off-by-one bug in the ACTIVE handling code, where we miss fail to stop the guest if writing to the first set of GICv2 SPIs. Oopsie boo.
The second patch improves the handling of the ACTIVE registers, which we never synchronise on the read side (the distributor state can only be updated when the vcpu exits). Let's fix it the same way we do it on the write side (stop-the-world, read, restart). Yes, this is expensive.
The following two patches deal with an issue where we consider the HW state of an interrupt when responding to a userspace access. We should never do this, as the guest shouldn't be running at this stage and if it is, it is absolutely fine to return random bits to userspace. It could also be that there is no active guest context at this stage, and you end up with an Oops, which nobody really enjoys.
The last two patches fix a couple of memory leaks.
* From v2:
- Now handle userspace access to GICv2 GICD_I{S,C}PENDR, which never really worked (pointed out by James)
- Collected tags from Andre and James
Marc Zyngier (4):
KVM: arm: vgic: Fix limit condition when writing to GICD_I[CS]ACTIVER
KVM: arm: vgic: Synchronize the whole guest on GIC{D,R}_I{S,C}ACTIVER
read
KVM: arm: vgic: Only use the virtual state when userspace accesses
enable bits
KVM: arm: vgic-v2: Only use the virtual state when userspace accesses
pending bits
Zenghui Yu (2):
KVM: arm64: vgic-v3: Retire all pending LPIs on vcpu destroy
KVM: arm64: vgic-its: Fix memory leak on the error path of
vgic_add_lpi()
virt/kvm/arm/vgic/vgic-init.c | 6 + virt/kvm/arm/vgic/vgic-its.c | 11 +- virt/kvm/arm/vgic/vgic-mmio-v2.c | 16 ++- virt/kvm/arm/vgic/vgic-mmio-v3.c | 28 ++-- virt/kvm/arm/vgic/vgic-mmio.c | 228 +++++++++++++++++++++++-------- virt/kvm/arm/vgic/vgic-mmio.h | 19 +++ 6 files changed, 230 insertions(+), 78 deletions(-)
Signature · 1 line
2.26.1