Skip to content

Bump of SElinux related libs/tools to 3.0

Thomas Petazzoni buildroot 2 versions – New

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest posting 2/20 of 8 patches 0 repliesNew
  2. v3 posting 1/20 of 8 patches 0 repliesSuperseded

Patches in v3 posting 2/2 No applies recorded yet

None of the 8 patches the cover letter announces are in this archive.

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v3 yet.

Read the v3 thread

Cover letter [Buildroot] [PATCH v3 0/8] Bump of SElinux related libs/tools to 3.0

Hello,

+Yann, Arnout, Adam.

Quoted 6 lines · On Tue, 14 Apr 2020 12:20:40 -0500 Matthew Weber <[email protected]>…
Quoted 2 lines

Is the only benefit of that change the fact that it will match with what release monitoring says ?

Correct. If we do stay with the x.y instead, I think it still makes sense to use the $(LIBSELINUX_VERION) across all those packages as the bumps should always be the same version for those 7 packages.

I never remember what are the rules to share a package <pkg>_VERSION variable with other packages. For example for mesa3d/mesa3d-headers, we do not share the version information, we duplicate it:

# Not possible to directly refer to mesa3d variables, because of

# first/second expansion trickery...
MESA3D_HEADERS_VERSION = 20.0.4

But in protobuf/python-protobuf:

# When bumping this package, make sure to also verify if the

# python-protobuf package still works, as they share the same
# version/site variables.
PROTOBUF_VERSION = 3.11.4

PYTHON_PROTOBUF_VERSION = $(PROTOBUF_VERSION) PYTHON_PROTOBUF_SOURCE = protobuf-python-$(PYTHON_PROTOBUF_VERSION).tar.gz PYTHON_PROTOBUF_SITE = $(PROTOBUF_SITE)

Here we share the version number.

Yann, Arnout, could you re-explain this ? :-)

Quoted 6 lines
Quoted 2 lines

So to me, it seems like we should instead change the versions reported by release-monitoring.org instead.

Is there a way to reorder the versions on release monitoring instead? As it just happens the dates end up at the top of the list
https://release-monitoring.org/project/01717/

I have filled in a bug report at
https://github.com/fedora-infra/anitya/issues/897 about this. I *believe* that with the current description of the project, only semantic versions should be displayed, because a prefix of libselinux- for the tags is specified. So it should filter the tags that have the form libselinux-<something>, and extract the <something>. The other versions that are there might date back from when this was not specified, and need to be purged.

Overall, I'll mark your series as Changes Requested. I would suggest to bump to 3.0, without sharing the version for now, so that we can get the 3.0 version bump merged soon.

Thanks!

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com