Skip to content

perf synthetic events

Ian Rogers linux-perf-users lkml 1 version Applied

Status from this message: Thanks, applied,

Get series with b4
b4 am [email protected]

Versions newest first

  1. v5 Latest3 patches 4 repliesApplied

Patches in v5 Applied

#Subject and filesSizeRepliesApplied
1/3perf bench: add a multi-threaded synthesize benchmarktools/perf/bench/synthesize.c+186 -251 reply
2/3tools api: add a lightweight buffered reading apitools/lib/api/io.h tools/perf/tests/Build tools/perf/tests/api-io.c +2 more+422 -00 replies
3/3perf synthetic events: Remove use of sscanf from /proc readingtools/perf/util/synthetic-events.c+105 -520 replies

Reviews trailers per patch

None of the 3 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchNamhyung KimJiri Olsa
SeriesA-b A-b
1/3
2/3
3/3

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v5 thread

Cover letter [PATCH v5 0/3] perf synthetic events

Add a multi-threaded version of the internals synthesize benchmark. It attempts to compute a time per event synthesized, but as it is reading /proc there are issues:
- permissions if not run as root
- "random" nature of /proc

By default the benchmark is disabled but can be enabled with a flag. It has been useful in gauging the value of multi-threaded improvements not included here as their value appears minimal.

The patch set includes 2 patches that improve synthesis performance and updates the benchmark numbers:
https://lore.kernel.org/lkml/[email protected]/

v4 added a missing test file
v3 improved documenation, return values and added testing to the io framework
following feedback from [email protected].
v2 addressed single threaded synthesize benchmark issues from [email protected]
https://lore.kernel.org/lkml/[email protected]/

Ian Rogers (3):
perf bench: add a multi-threaded synthesize benchmark tools api: add a lightweight buffered reading api perf synthetic events: Remove use of sscanf from /proc reading

 tools/lib/api/io.h                 | 112 +++++++++++
 tools/perf/bench/synthesize.c      | 211 +++++++++++++++++---
 tools/perf/tests/Build             |   1 +
 tools/perf/tests/api-io.c          | 304 +++++++++++++++++++++++++++++
 tools/perf/tests/builtin-test.c    |   4 +
 tools/perf/tests/tests.h           |   1 +
 tools/perf/util/synthetic-events.c | 157 ++++++++++-----
 7 files changed, 713 insertions(+), 77 deletions(-)
 create mode 100644 tools/lib/api/io.h
 create mode 100644 tools/perf/tests/api-io.c
Signature · 1 line
2.26.0.110.g2183baf09c-goog