Skip to content

nvme: small fixes, refactoring and cleanups

Klaus Jensen qemu-devel 6 versions – Applied

Status from this message: Thanks, applied to the block branch.

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v7 Latest22 patches 1 replyApplied
  2. v620 patches 10 repliesApplied
  3. v518 patches 8 repliesSuperseded
Earlier versions · 3
VersionPostedPatchesRepliesStatus
v316 patches4 repliesSuperseded
v216 patches30 repliesSuperseded
v116 patches15 repliesSuperseded

Changes in v7 from the cover letter

~~~~~~~~~~~~~~~~
* Dropped the goofed "hw/block/nvme: allow use of any valid msix vector" patch.

* Included Philippe's "hw/block/nvme: Verify msix_vector_use() returned value" patch for posterity.

* Added two patches (requesting reviews):

1. hw/block/nvme: add msix_qsize parameter
2. hw/block/nvme: verify msix_init_exclusive_bar() return value

Patches in v7 Applied

#Subject and filesSizeRepliesApplied
1/22hw/block/nvme: fix pci doorbell size calculationhw/block/nvme.c+6 -10 replies
2/22hw/block/nvme: rename trace events to pci_nvmehw/block/nvme.c hw/block/trace-events+188 -1900 replies
3/22hw/block/nvme: remove superfluous breakshw/block/nvme.c+0 -40 replies
4/22hw/block/nvme: move device parameters to separate structhw/block/nvme.c hw/block/nvme.h+34 -260 replies
5/22hw/block/nvme: use constants in identifyhw/block/nvme.c include/block/nvme.h+12 -40 replies
6/22hw/block/nvme: refactor nvme_addr_readhw/block/nvme.c+12 -40 replies
7/22hw/block/nvme: fix pin-based interrupt behaviorhw/block/nvme.c hw/block/nvme.h+9 -50 replies
8/22hw/block/nvme: add max_ioqpairs device parameterhw/block/nvme.c hw/block/nvme.h+33 -210 replies
9/22hw/block/nvme: remove redundant cmbloc/cmbsz membershw/block/nvme.c hw/block/nvme.h+2 -70 replies
10/22hw/block/nvme: factor out property/constraint checkshw/block/nvme.c+30 -180 replies
11/22hw/block/nvme: factor out device state setuphw/block/nvme.c+13 -90 replies
12/22hw/block/nvme: factor out block backend setuphw/block/nvme.c+10 -30 replies
13/22hw/block/nvme: add namespace helpershw/block/nvme.c hw/block/nvme.h+18 -20 replies
14/22hw/block/nvme: factor out namespace setuphw/block/nvme.c+26 -200 replies
15/22hw/block/nvme: factor out pci setuphw/block/nvme.c+18 -120 replies
16/22hw/block/nvme: factor out cmb setuphw/block/nvme.c+24 -190 replies
17/22hw/block/nvme: factor out pmr setuphw/block/nvme.c+51 -440 replies
18/22hw/block/nvme: do cmb/pmr init as part of pci inithw/block/nvme.c+6 -60 replies
19/22hw/block/nvme: factor out controller identify setuphw/block/nvme.c+26 -230 replies
20/22hw/block/nvme: Verify msix_vector_use() returned valuehw/block/nvme.c+4 -10 replies
21/22hw/block/nvme: add msix_qsize parameterhw/block/nvme.c hw/block/nvme.h+14 -40 replies
22/22hw/block/nvme: verify msix_init_exclusive_bar() return valuehw/block/nvme.c+10 -30 replies

Reviews trailers per patch

19 of 22 patches have a Reviewed-by or Acked-by.

PatchPhilippe Mathieu-DaudéMaxim LevitskyKeith Busch
1/22R-b R-b R-b
2/22R-b R-b R-b
3/22R-b R-b R-b
4/22R-b R-b
5/22R-b R-b R-b
6/22R-b R-b R-b
7/22R-b
8/22R-b R-b R-b
9/22R-b R-b R-b
10/22R-b R-b R-b
11/22R-b R-b R-b
12/22R-b R-b R-b
13/22R-b R-b R-b
14/22R-b R-b R-b
15/22R-b R-b R-b
16/22R-b R-b R-b
17/22R-b R-b
18/22R-b R-b
19/22R-b R-b R-b
20/22
21/22
22/22

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v7 thread

Cover letter [PATCH v7 00/22] nvme: small fixes, refactoring and cleanups

From: Klaus Jensen <[email protected]>

Hi all,

As per our discussion about how to amend the bug I introduced in "hw/block/nvme: allow use of any valid msix vector", this is a respin without that patch.

Kevin, it applies cleanly on top of your block tree with all current hw/block/bnvme patches removed.

Changes since v6
~~~~~~~~~~~~~~~~
* Dropped the goofed "hw/block/nvme: allow use of any valid msix vector" patch.

* Included Philippe's "hw/block/nvme: Verify msix_vector_use() returned value" patch for posterity.

* Added two patches (requesting reviews):

1. hw/block/nvme: add msix_qsize parameter
2. hw/block/nvme: verify msix_init_exclusive_bar() return value

Kevin, it's up to you if you want to wait for reviews on these two or just pick up the rest of the series. But let's see if we can get a quick review on them.

Klaus Jensen (21):
hw/block/nvme: fix pci doorbell size calculation hw/block/nvme: rename trace events to pci_nvme hw/block/nvme: remove superfluous breaks hw/block/nvme: move device parameters to separate struct hw/block/nvme: use constants in identify hw/block/nvme: refactor nvme_addr_read hw/block/nvme: fix pin-based interrupt behavior hw/block/nvme: add max_ioqpairs device parameter hw/block/nvme: remove redundant cmbloc/cmbsz members hw/block/nvme: factor out property/constraint checks hw/block/nvme: factor out device state setup hw/block/nvme: factor out block backend setup hw/block/nvme: add namespace helpers hw/block/nvme: factor out namespace setup hw/block/nvme: factor out pci setup
hw/block/nvme: factor out cmb setup
hw/block/nvme: factor out pmr setup
hw/block/nvme: do cmb/pmr init as part of pci init hw/block/nvme: factor out controller identify setup hw/block/nvme: add msix_qsize parameter hw/block/nvme: verify msix_init_exclusive_bar() return value

Philippe Mathieu-Daudé (1):
hw/block/nvme: Verify msix_vector_use() returned value

 hw/block/nvme.c       | 576 ++++++++++++++++++++++++------------------
 hw/block/nvme.h       |  34 ++-
 hw/block/trace-events | 180 ++++++-------
 include/block/nvme.h  |   8 +
 4 files changed, 459 insertions(+), 339 deletions(-)
Signature · 1 line
2.27.0