nvme: small fixes, refactoring and cleanups
Status from this message: Thanks, applied to the block branch.
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
Earlier versions · 3
| Version | Posted | Patches | Replies | Status |
|---|---|---|---|---|
| v3 | 16 patches | 4 replies | Superseded | |
| v2 | 16 patches | 30 replies | Superseded | |
| v1 | 16 patches | 15 replies | Superseded |
Changes in v7 from the cover letter
~~~~~~~~~~~~~~~~
* Dropped the goofed "hw/block/nvme: allow use of any valid msix vector" patch.
* Included Philippe's "hw/block/nvme: Verify msix_vector_use() returned value" patch for posterity.
* Added two patches (requesting reviews):
1. hw/block/nvme: add msix_qsize parameter
2. hw/block/nvme: verify msix_init_exclusive_bar() return value
Patches in v7 Applied
Reviews trailers per patch
19 of 22 patches have a Reviewed-by or Acked-by.
| Patch | Philippe Mathieu-Daudé | Maxim Levitsky | Keith Busch |
|---|---|---|---|
| 1/22 | R-b | R-b | R-b |
| 2/22 | R-b | R-b | R-b |
| 3/22 | R-b | R-b | R-b |
| 4/22 | R-b | R-b | |
| 5/22 | R-b | R-b | R-b |
| 6/22 | R-b | R-b | R-b |
| 7/22 | R-b | ||
| 8/22 | R-b | R-b | R-b |
| 9/22 | R-b | R-b | R-b |
| 10/22 | R-b | R-b | R-b |
| 11/22 | R-b | R-b | R-b |
| 12/22 | R-b | R-b | R-b |
| 13/22 | R-b | R-b | R-b |
| 14/22 | R-b | R-b | R-b |
| 15/22 | R-b | R-b | R-b |
| 16/22 | R-b | R-b | R-b |
| 17/22 | R-b | R-b | |
| 18/22 | R-b | R-b | |
| 19/22 | R-b | R-b | R-b |
| 20/22 | |||
| 21/22 | |||
| 22/22 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.
Cover letter [PATCH v7 00/22] nvme: small fixes, refactoring and cleanups
From: Klaus Jensen <[email protected]>
Hi all,
As per our discussion about how to amend the bug I introduced in "hw/block/nvme: allow use of any valid msix vector", this is a respin without that patch.
Kevin, it applies cleanly on top of your block tree with all current hw/block/bnvme patches removed.
Changes since v6
~~~~~~~~~~~~~~~~
* Dropped the goofed "hw/block/nvme: allow use of any valid msix vector" patch.
* Included Philippe's "hw/block/nvme: Verify msix_vector_use() returned value" patch for posterity.
* Added two patches (requesting reviews):
1. hw/block/nvme: add msix_qsize parameter
2. hw/block/nvme: verify msix_init_exclusive_bar() return value
Kevin, it's up to you if you want to wait for reviews on these two or just pick up the rest of the series. But let's see if we can get a quick review on them.
Klaus Jensen (21):
hw/block/nvme: fix pci doorbell size calculation hw/block/nvme: rename trace events to pci_nvme hw/block/nvme: remove superfluous breaks hw/block/nvme: move device parameters to separate struct hw/block/nvme: use constants in identify hw/block/nvme: refactor nvme_addr_read hw/block/nvme: fix pin-based interrupt behavior hw/block/nvme: add max_ioqpairs device parameter hw/block/nvme: remove redundant cmbloc/cmbsz members hw/block/nvme: factor out property/constraint checks hw/block/nvme: factor out device state setup hw/block/nvme: factor out block backend setup hw/block/nvme: add namespace helpers hw/block/nvme: factor out namespace setup hw/block/nvme: factor out pci setup
hw/block/nvme: factor out cmb setup
hw/block/nvme: factor out pmr setup
hw/block/nvme: do cmb/pmr init as part of pci init hw/block/nvme: factor out controller identify setup hw/block/nvme: add msix_qsize parameter hw/block/nvme: verify msix_init_exclusive_bar() return value
Philippe Mathieu-Daudé (1):
hw/block/nvme: Verify msix_vector_use() returned value
hw/block/nvme.c | 576 ++++++++++++++++++++++++------------------ hw/block/nvme.h | 34 ++- hw/block/trace-events | 180 ++++++------- include/block/nvme.h | 8 + 4 files changed, 459 insertions(+), 339 deletions(-)
Signature · 1 line
2.27.0