Skip to content

mptcp: fix splats and crashes

Florian Westphal mptcp 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest7 patches 3 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/7mptcp: fix splat when incoming connection is never accepted before exit/closenet/mptcp/protocol.c net/mptcp/subflow.c+25 -10 replies
2/7mptcp: fix 'Attempt to release TCP socket in state' warningsnet/mptcp/protocol.c net/mptcp/subflow.c+12 -30 replies
3/7mptcp: handle mptcp listener destruction via rcunet/mptcp/protocol.c+3 -00 replies
4/7mptcp: avoid callback invocation when mptcp parent socket doesn't existnet/mptcp/protocol.h net/mptcp/subflow.c+34 -133 replies
5/7mptcp: use rcu helpers to fetch ulp subflow contextnet/mptcp/protocol.c net/mptcp/protocol.h net/mptcp/subflow.c+23 -200 replies
6/7mptcp: reverse order of sk_state_change and is_mptcp checknet/mptcp/subflow.c+3 -30 replies
7/7mptcp: prevent null deref crash on normal tcp socketsnet/mptcp/subflow.c+5 -10 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [MPTCP] [PATCH mptcp 0/7] mptcp: fix splats and crashes

This series resolves a number of crashes in MPTCP.
I'm not 100% sure yet that I managed to fix all of them (I will run the selftest again over night), but I wanted to send it out anyway because its unlikely that any of the fixes is flat out wrong. If anything, there is a different/better solution that I missed so far or another fix needs to be placed on top of this pile.

Florian Westphal (7):
mptcp: fix splat when incoming connection is never accepted before exit/close
mptcp: fix 'Attempt to release TCP socket in state' warnings
mptcp: handle mptcp listener destruction via rcu
mptcp: avoid callback invocation when mptcp parent socket doesn't exist
mptcp: use rcu helpers to fetch ulp subflow context
mptcp: reverse order of sk_state_change and is_mptcp check
mptcp: prevent null deref crash on normal tcp sockets

 protocol.c |   29 +++++++++++++----
 protocol.h |   14 +-------
 subflow.c  |  103 +++++++++++++++++++++++++++++++++++++++++++++++--------------
 3 files changed, 105 insertions(+), 41 deletions(-)