Skip to content

IPU3 ImgU driver parameter struct fixes

Sakari Ailus linux-media 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest3 patches 2 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3Revert "staging: imgu: Address a compiler warning on alignment"drivers/staging/media/ipu3/include/intel-ipu3.h+1 -10 replies
1/3Revert "staging: imgu: Address a compiler warning on alignment"drivers/staging/media/ipu3/include/intel-ipu3.h+1 -10 replies
2/3staging: ipu3-imgu: Move alignment attribute to fielddrivers/staging/media/ipu3/include/intel-ipu3.h+3 -20 replies
3/3staging: ipu3-imgu: Add a sanity check for the parameter struct sizedrivers/staging/media/ipu3/ipu3-css.c+7 -00 replies

Reviews trailers per patch

None of the 4 patches has a Reviewed-by or Acked-by.

PatchBingbu Cao
SeriesT-b
1/3T-b
1/3T-b
2/3
3/3

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/3] IPU3 ImgU driver parameter struct fixes

Hi all,

This set addresses parameter struct memory layout changes introduced by seemingly innocent patches, and adds a sanity check for the struct size to avoid this from happening again. This only touches the uAPI, not the ipu3-abi.h that deals with ABI not visible in the driver uAPI. That should be addressed as well going forward.

The first patch does not probably entirely fix the issues, but with the second patch added, pahole agrees the struct memory layout is unchanged from the previous state.

Sakari Ailus (3):
Revert "staging: imgu: Address a compiler warning on alignment"
staging: ipu3-imgu: Move alignment attribute to field
staging: ipu3-imgu: Add a sanity check for the parameter struct size

 drivers/staging/media/ipu3/include/intel-ipu3.h | 7 ++++---
 drivers/staging/media/ipu3/ipu3-css.c           | 7 +++++++
 2 files changed, 11 insertions(+), 3 deletions(-)
Signature · 1 line
2.20.1