Skip to content

Use crypto library functions for const time memcmp when possible

Arne Schwabe openvpn-devel 1 version In review

Get series with b4
b4 am [email protected]...

Versions newest first

  1. v2 Latest3 patches 16 repliesIn review

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3Use crypto library functions for const time memcmp when possiblesrc/openvpn/crypto.h src/openvpn/crypto_mbedtls.c src/openvpn/crypto_openssl.c+25 -159 replies
1/3Use crypto library functions for const time memcmp when possiblesrc/openvpn/crypto.h src/openvpn/crypto_mbedtls.c src/openvpn/crypto_openssl.c+26 -150 replies
2/3Minor style change to improve code stylesrc/openvpn/buffer.c src/openvpn/socket.h src/openvpn/ssl_mbedtls.c+8 -62 replies
3/3After the last big formatting patch a number of changes have been commited that do not conform with our style/uncrustify config. This has lead to the problem that running uncrustify on before sending PR some of the changes made by uncrustify need to be backed out again.src/compat/compat-strsep.c src/compat/compat.h src/openvpn/crypto.c +23 more+98 -745 replies

Reviews trailers per patch

All 4 patches have a Reviewed-by or Acked-by.

PatchAntonio QuartulliGert Doering
1/3A-b
1/3A-b
2/3A-b
3/3A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread