Skip to content

qemu-img: Add convert --bitmaps

Eric Blake qemu-devel 6 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v6 Latest5 patches 6 repliesIn review
  2. v55 patches 11 repliesSuperseded
  3. v49 patches 20 repliesSuperseded
Earlier versions · 3
VersionPostedPatchesRepliesStatus
v39 patches20 repliesSuperseded
v26 patches14 repliesSuperseded
v13 patches2 repliesSuperseded

Patches in v6 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5iotests: Fix test 178tests/qemu-iotests/178.out.qcow2 tests/qemu-iotests/178.out.raw+2 -20 replies
2/5qcow2: Expose bitmaps' size during measureblock/crypto.c block/qcow2-bitmap.c block/qcow2.c +8 more+157 -131 reply
3/5qemu-img: Factor out code for merging bitmapsqemu-img.c+21 -131 reply
4/5qemu-img: Add convert --bitmaps optiondocs/tools/qemu-img.rst qemu-img-cmds.hx qemu-img.c+82 -62 replies
5/5iotests: Add test 291 to for qemu-img bitmap coveragetests/qemu-iotests/291 tests/qemu-iotests/291.out tests/qemu-iotests/group+193 -02 replies

Reviews trailers per patch

All 5 patches have a Reviewed-by or Acked-by.

PatchVladimir Sementsov-OgievskiyMax Reitz
1/5R-b
2/5R-b
3/5R-b
4/5R-b
5/5R-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v6 thread

Cover letter [PATCH v6 0/5] qemu-img: Add convert --bitmaps

v5 was here:
https://lists.gnu.org/archive/html/qemu-devel/2020-05/msg05958.html
original cover letter here:
https://lists.gnu.org/archive/html/qemu-devel/2020-04/msg03464.html

Hopefully this version is close enough to do a pull request Monday.

Since then:
- patch 2: drop 'measure --bitmaps' sugar on top of QMP [Nir]
- patch 3: add function comment
- patch 4: fallout from patch 2

001/5:[----] [--] 'iotests: Fix test 178'
002/5:[0073] [FC] 'qcow2: Expose bitmaps' size during measure' 003/5:[0001] [FC] 'qemu-img: Factor out code for merging bitmaps' 004/5:[0001] [FC] 'qemu-img: Add convert --bitmaps option' 005/5:[----] [--] 'iotests: Add test 291 to for qemu-img bitmap coverage'

Series can also be downloaded at:
https://repo.or.cz/qemu/ericb.git/shortlog/refs/tags/qemu-img-bitmaps-v6

Eric Blake (5):
iotests: Fix test 178
qcow2: Expose bitmaps' size during measure
qemu-img: Factor out code for merging bitmaps
qemu-img: Add convert --bitmaps option
iotests: Add test 291 to for qemu-img bitmap coverage

 docs/tools/qemu-img.rst          |  13 +++-
 qapi/block-core.json             |  16 +++--
 block/qcow2.h                    |   2 +
 block/crypto.c                   |   2 +-
 block/qcow2-bitmap.c             |  36 ++++++++++
 block/qcow2.c                    |  14 +++-
 block/raw-format.c               |   2 +-
 qemu-img.c                       | 115 ++++++++++++++++++++++++++-----
 qemu-img-cmds.hx                 |   4 +-
 tests/qemu-iotests/178.out.qcow2 |  18 ++++-
 tests/qemu-iotests/178.out.raw   |   2 +-
 tests/qemu-iotests/190           |  45 +++++++++++-
 tests/qemu-iotests/190.out       |  27 +++++++-
 tests/qemu-iotests/291           | 112 ++++++++++++++++++++++++++++++
 tests/qemu-iotests/291.out       |  80 +++++++++++++++++++++
 tests/qemu-iotests/group         |   1 +
 16 files changed, 455 insertions(+), 34 deletions(-)
 create mode 100755 tests/qemu-iotests/291
 create mode 100644 tests/qemu-iotests/291.out
Signature · 1 line
2.26.2