Skip to content

rtw88: 8723d: add basic chip functions

[email protected] linux-wireless 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest8 patches 2 repliesIn review
  2. v140 patches 16 repliesSuperseded

Changes in v2 from the cover letter

* make a patchset contains less patches for review

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/8rtw88: 8723d: Add basic chip capabilitiesdrivers/net/wireless/realtek/rtw88/main.h drivers/net/wireless/realtek/rtw88/pci.c drivers/net/wireless/realtek/rtw88/rtw8723d.c +3 more+72 -01 reply
2/8rtw88: 8723d: add beamform wrapper functionsdrivers/net/wireless/realtek/rtw88/bf.c drivers/net/wireless/realtek/rtw88/bf.h drivers/net/wireless/realtek/rtw88/mac80211.c +2 more+33 -130 replies
3/8rtw88: 8723d: Add power sequencedrivers/net/wireless/realtek/rtw88/main.h drivers/net/wireless/realtek/rtw88/rtw8723d.c+404 -00 replies
4/8rtw88: 8723d: Add RF read/write opsdrivers/net/wireless/realtek/rtw88/main.c drivers/net/wireless/realtek/rtw88/main.h drivers/net/wireless/realtek/rtw88/phy.c +2 more+85 -40 replies
5/8rtw88: 8723d: Add mac/bb/rf/agc/power_limit tablesdrivers/net/wireless/realtek/rtw88/rtw8723d.c drivers/net/wireless/realtek/rtw88/rtw8723d_table.c drivers/net/wireless/realtek/rtw88/rtw8723d_table.h+1207 -00 replies
6/8rtw88: 8723d: Add cfg_ldo25 to control LDO25drivers/net/wireless/realtek/rtw88/reg.h drivers/net/wireless/realtek/rtw88/rtw8723d.c drivers/net/wireless/realtek/rtw88/rtw8822b.c+21 -10 replies
7/8rtw88: 8723d: Add new chip op efuse_grant() to control efuse accessdrivers/net/wireless/realtek/rtw88/efuse.c drivers/net/wireless/realtek/rtw88/main.h drivers/net/wireless/realtek/rtw88/reg.h +1 more+39 -00 replies
8/8rtw88: 8723d: Add read_efuse to recognize efuse info from mapdrivers/net/wireless/realtek/rtw88/rtw8723d.c drivers/net/wireless/realtek/rtw88/rtw8723d.h+82 -01 reply

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.

Read the v2 thread

Cover letter [PATCH v2 0/8] rtw88: 8723d: add basic chip functions

From: Yan-Hsuan Chuang <[email protected]>

Add basic chip functions for new 802.11n devices RTL8723DE.

RTL8723DE is an 802.11n device, while rtw88 aimed to support 802.11ac devices, the 8723DE devices' architecture is close to them. The PCI TRX paths are mostly the same, except that the 8723DE does not have H2CQ for sending H2C commands. And it also uses a different way to download firmware, but it's not a big deal, as we can add a legacy firmware download routine for it.

So, we can easily get 8723DE supported by rtw88. For easier to review them, the 8723DE implementation is split into multiple patches. First add the basic chip functionalities for it.

To make a new type of chip work, the chip capabilities should be filled correctly. And it will have its own parameter tables, including MAC/PHY and power squence tables. Note that 8723DE introduces a slightly different way to access to the RF regs. Beamform is not supported as well, assign NULL to them, and check the chip_ops before we use.

v1 -> v2
* make a patchset contains less patches for review

Ping-Ke Shih (8):
rtw88: 8723d: Add basic chip capabilities
rtw88: 8723d: add beamform wrapper functions
rtw88: 8723d: Add power sequence
rtw88: 8723d: Add RF read/write ops
rtw88: 8723d: Add mac/bb/rf/agc/power_limit tables
rtw88: 8723d: Add cfg_ldo25 to control LDO25
rtw88: 8723d: Add new chip op efuse_grant() to control efuse access
rtw88: 8723d: Add read_efuse to recognize efuse info from map

 drivers/net/wireless/realtek/rtw88/bf.c       |    7 +-
 drivers/net/wireless/realtek/rtw88/bf.h       |   22 +
 drivers/net/wireless/realtek/rtw88/efuse.c    |    4 +
 drivers/net/wireless/realtek/rtw88/mac80211.c |    7 +-
 drivers/net/wireless/realtek/rtw88/main.c     |   12 +-
 drivers/net/wireless/realtek/rtw88/main.h     |   26 +
 drivers/net/wireless/realtek/rtw88/pci.c      |    3 +
 drivers/net/wireless/realtek/rtw88/phy.c      |   56 +-
 drivers/net/wireless/realtek/rtw88/phy.h      |    6 +
 drivers/net/wireless/realtek/rtw88/reg.h      |   14 +
 drivers/net/wireless/realtek/rtw88/rtw8723d.c |  544 ++++++++
 drivers/net/wireless/realtek/rtw88/rtw8723d.h |   47 +
 .../wireless/realtek/rtw88/rtw8723d_table.c   | 1196 +++++++++++++++++
 .../wireless/realtek/rtw88/rtw8723d_table.h   |   15 +
 drivers/net/wireless/realtek/rtw88/rtw8822b.c |    2 +-
 15 files changed, 1943 insertions(+), 18 deletions(-)
 create mode 100644 drivers/net/wireless/realtek/rtw88/rtw8723d.c
 create mode 100644 drivers/net/wireless/realtek/rtw88/rtw8723d.h
 create mode 100644 drivers/net/wireless/realtek/rtw88/rtw8723d_table.c
 create mode 100644 drivers/net/wireless/realtek/rtw88/rtw8723d_table.h
Signature · 1 line
2.17.1