Skip to content

Add support to get xmit slave

Maor Gottlieb linux-rdma netdev 10 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v8 Latest16 patches 3 repliesIn review
  2. v7 posting 2/25 of 16 patches 4 repliesSuperseded
  3. v7 posting 1/211 patches 0 repliesSuperseded
Earlier versions · 7
VersionPostedPatchesRepliesStatus
v615 of 16 patches11 repliesSuperseded
v5 posting 2/20 of 15 patches0 repliesSuperseded
v5 posting 1/216 patches4 repliesSuperseded
v415 patches9 repliesSuperseded
v315 patches10 repliesSuperseded
v210 patches20 repliesSuperseded
v10 of 10 patches1 replySuperseded

Change log from the cover letter

v8: Fix bad numbering of v7.
v7: Change only in RDMA part:
- return slave and as output
- Don't hold lock while allocating skb.
In addition, reorder patches, so mlx5 patches are before RDMA.
v6: patch 1 - Fix commit message and add function description.
patch 10 - Keep udata as function argument.
v5: patch 1 - Remove rcu lock.
patch 10 - Refactor patch that group the AH attributes in struct. patch 11 - call the ndo while holding the rcu and initialize xmit_slave. patch 12 - Store the xmit slave in rdma_ah_init_attr and qp_attr.

Patches in v8 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/16net/core: Introduce netdev_get_xmit_slaveinclude/linux/netdevice.h net/core/dev.c+34 -00 replies
2/16bonding: Export skip slave logic to functiondrivers/net/bonding/bond_main.c+26 -210 replies
3/16bonding: Rename slave_arr to usable_slavesdrivers/net/bonding/bond_alb.c drivers/net/bonding/bond_main.c include/net/bonding.h+23 -230 replies
4/16bonding/alb: Add helper functions to get the xmit slavedrivers/net/bonding/bond_alb.c include/net/bond_alb.h+30 -90 replies
5/16bonding: Add helper function to get the xmit slave based on hashdrivers/net/bonding/bond_main.c+21 -70 replies
6/16bonding: Add helper function to get the xmit slave in rr modedrivers/net/bonding/bond_main.c+30 -260 replies
7/16bonding: Add function to get the xmit slave in active-backup modedrivers/net/bonding/bond_main.c+7 -10 replies
8/16bonding: Add array of all slavesdrivers/net/bonding/bond_main.c include/net/bonding.h+61 -200 replies
9/16bonding: Implement ndo_get_xmit_slavedrivers/net/bonding/bond_main.c+43 -00 replies
10/16net/mlx5: Change lag mutex lock to spin lockdrivers/net/ethernet/mellanox/mlx5/core/lag.c+21 -210 replies
11/16net/mlx5: Add support to get lag physical portdrivers/net/ethernet/mellanox/mlx5/core/lag.c include/linux/mlx5/driver.h+26 -00 replies
12/16RDMA: Group create AH arguments in structdrivers/infiniband/core/verbs.c drivers/infiniband/hw/bnxt_re/ib_verbs.c drivers/infiniband/hw/bnxt_re/ib_verbs.h +19 more+66 -470 replies
13/16RDMA/core: Add LAG functionalitydrivers/infiniband/core/Makefile drivers/infiniband/core/lag.c include/rdma/ib_verbs.h +1 more+161 -10 replies
14/16RDMA/core: Get xmit slave for LAGdrivers/infiniband/core/verbs.c include/rdma/ib_verbs.h+45 -180 replies
15/16RDMA/mlx5: Refactor affinity related codedrivers/infiniband/hw/mlx5/qp.c+53 -370 replies
16/16RDMA/mlx5: Set lag tx affinity according to slavedrivers/infiniband/hw/mlx5/ah.c drivers/infiniband/hw/mlx5/gsi.c drivers/infiniband/hw/mlx5/main.c +4 more+76 -270 replies

Reviews trailers per patch

All 16 patches have a Reviewed-by or Acked-by.

PatchJiri PirkoJay VosburghDavid AhernLeon RomanovskyDevesh SharmaGal PressmanWeihang LiJason Gunthorpe
1/16R-b R-b
2/16R-b R-b
3/16R-b R-b
4/16R-b R-b
5/16R-b R-b
6/16R-b R-b
7/16R-b R-b
8/16R-b R-b
9/16R-b R-b
10/16R-b
11/16R-b
12/16A-b A-b A-b R-b
13/16R-b
14/16R-b
15/16R-b
16/16R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 8 reviewers.

Read the v8 thread

Cover letter [PATCH V8 mlx5-next 00/16] Add support to get xmit slave

Hi Dave,

This series is a combination of netdev and RDMA, so in order to avoid conflicts, we would like to ask you to route this series through mlx5-next shared branch. It is based on v5.7-rc2 tag.

---------------------------------------------------------------------

The following series adds support to get the LAG master xmit slave by introducing new .ndo - ndo_get_xmit_slave. Every LAG module can implement it and it first implemented in the bond driver. This is follow-up to the RFC discussion [1].

The main motivation for doing this is for drivers that offload part of the LAG functionality. For example, Mellanox Connect-X hardware implements RoCE LAG which selects the TX affinity when the resources are created and port is remapped when it goes down.

The first part of this patchset introduces the new .ndo and add the support to the bonding module.

The second part adds support to get the RoCE LAG xmit slave by building skb of the RoCE packet based on the AH attributes and call to the new .ndo.

The third part change the mlx5 driver driver to set the QP's affinity port according to the slave which found by the .ndo.

Thanks

[1]
https://lore.kernel.org/netdev/20200126132126.9981-1-maorg@xxxxxxxxxxxx/

Change log:
v8: Fix bad numbering of v7.
v7: Change only in RDMA part:
- return slave and as output
- Don't hold lock while allocating skb.
In addition, reorder patches, so mlx5 patches are before RDMA.
v6: patch 1 - Fix commit message and add function description.
patch 10 - Keep udata as function argument.
v5: patch 1 - Remove rcu lock.
patch 10 - Refactor patch that group the AH attributes in struct. patch 11 - call the ndo while holding the rcu and initialize xmit_slave. patch 12 - Store the xmit slave in rdma_ah_init_attr and qp_attr.

v4: 1. Rename master_get_xmit_slave to netdev_get_xmit_slave and move the implementation to dev.c
2. Remove unnecessary check of NULL pointer.
3. Fix typo.
v3: 1. Move master_get_xmit_slave to netdevice.h and change the flags arg.
to bool.
2. Split helper functions commit to multiple commits for each bond
mode.
3. Extract refcotring changes to seperate commits.
v2: The first patch wasn't sent in v1.
v1:
https://lore.kernel.org/netdev/ac373456-b838-29cf-645f-b1ea1a93e3b0@xxxxxxxxx/T/#t

Maor Gottlieb (16):
net/core: Introduce netdev_get_xmit_slave
bonding: Export skip slave logic to function
bonding: Rename slave_arr to usable_slaves bonding/alb: Add helper functions to get the xmit slave
bonding: Add helper function to get the xmit slave based on hash
bonding: Add helper function to get the xmit slave in rr mode
bonding: Add function to get the xmit slave in active-backup mode
bonding: Add array of all slaves
bonding: Implement ndo_get_xmit_slave
net/mlx5: Change lag mutex lock to spin lock
net/mlx5: Add support to get lag physical port
RDMA: Group create AH arguments in struct
RDMA/core: Add LAG functionality
RDMA/core: Get xmit slave for LAG
RDMA/mlx5: Refactor affinity related code
RDMA/mlx5: Set lag tx affinity according to slave

 drivers/infiniband/core/Makefile              |   2 +-
 drivers/infiniband/core/lag.c                 | 136 +++++++++
 drivers/infiniband/core/verbs.c               |  66 +++--
 drivers/infiniband/hw/bnxt_re/ib_verbs.c      |   8 +-
 drivers/infiniband/hw/bnxt_re/ib_verbs.h      |   2 +-
 drivers/infiniband/hw/efa/efa.h               |   3 +-
 drivers/infiniband/hw/efa/efa_verbs.c         |   6 +-
 drivers/infiniband/hw/hns/hns_roce_ah.c       |   5 +-
 drivers/infiniband/hw/hns/hns_roce_device.h   |   4 +-
 drivers/infiniband/hw/mlx4/ah.c               |  11 +-
 drivers/infiniband/hw/mlx4/mlx4_ib.h          |   2 +-
 drivers/infiniband/hw/mlx5/ah.c               |  14 +-
 drivers/infiniband/hw/mlx5/gsi.c              |  33 ++-
 drivers/infiniband/hw/mlx5/main.c             |   2 +
 drivers/infiniband/hw/mlx5/mlx5_ib.h          |   3 +-
 drivers/infiniband/hw/mlx5/qp.c               | 122 +++++---
 drivers/infiniband/hw/mthca/mthca_provider.c  |   9 +-
 drivers/infiniband/hw/ocrdma/ocrdma_ah.c      |   3 +-
 drivers/infiniband/hw/ocrdma/ocrdma_ah.h      |   2 +-
 drivers/infiniband/hw/qedr/verbs.c            |   4 +-
 drivers/infiniband/hw/qedr/verbs.h            |   2 +-
 .../infiniband/hw/vmw_pvrdma/pvrdma_verbs.c   |   5 +-
 .../infiniband/hw/vmw_pvrdma/pvrdma_verbs.h   |   2 +-
 drivers/infiniband/sw/rdmavt/ah.c             |  11 +-
 drivers/infiniband/sw/rdmavt/ah.h             |   4 +-
 drivers/infiniband/sw/rxe/rxe_verbs.c         |   9 +-
 drivers/net/bonding/bond_alb.c                |  39 ++-
 drivers/net/bonding/bond_main.c               | 268 +++++++++++++-----
 drivers/net/ethernet/mellanox/mlx5/core/lag.c |  66 +++--
 include/linux/mlx5/driver.h                   |   2 +
 include/linux/mlx5/mlx5_ifc.h                 |   4 +-
 include/linux/mlx5/qp.h                       |   2 +
 include/linux/netdevice.h                     |  12 +
 include/net/bond_alb.h                        |   4 +
 include/net/bonding.h                         |   3 +-
 include/rdma/ib_verbs.h                       |  12 +-
 include/rdma/lag.h                            |  23 ++
 net/core/dev.c                                |  22 ++
 38 files changed, 696 insertions(+), 231 deletions(-)
 create mode 100644 drivers/infiniband/core/lag.c
 create mode 100644 include/rdma/lag.h
Signature · 1 line
2.17.2