Skip to content

Add a new LOOP_CONFIGURE ioctl

Martijn Coenen linux-api linux-block lkml 5 versions – Applied

Status from this message: Thanks, applied for 5.8.

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v5 Latest11 patches 3 repliesApplied
  2. v410 patches 24 repliesSuperseded
  3. v39 patches 14 repliesSuperseded
Earlier versions · 2
VersionPostedPatchesRepliesStatus
v25 patches5 repliesSuperseded
v14 patches12 repliesSuperseded

Changes in v5 from the cover letter

- Added "loop: Call loop_config_discard() ..." as a first patch to this series, as the rest of the refactoring done depends on it.
- Removed sector_t truncation checks, as suggested by Ming Lei.

Patches in v5 Applied

#Subject and filesSizeRepliesApplied
1/11loop: Call loop_config_discard() only after new config is applieddrivers/block/loop.c+2 -20 replies
2/11loop: Remove sector_t truncation checksdrivers/block/loop.c+7 -141 reply
3/11loop: Factor out setting loop device sizedrivers/block/loop.c+21 -90 replies
4/11loop: Switch to set_capacity_revalidate_and_notify()drivers/block/loop.c+2 -30 replies
5/11loop: Refactor loop_set_status() size calculationdrivers/block/loop.c+19 -180 replies
6/11loop: Remove figure_loop_size()drivers/block/loop.c+4 -90 replies
7/11loop: Factor out configuring loop from statusdrivers/block/loop.c+67 -500 replies
8/11loop: Move loop_set_status_from_info() and friends updrivers/block/loop.c+103 -1030 replies
9/11loop: Rework lo_ioctl() __user argument castingdrivers/block/loop.c+5 -60 replies
10/11loop: Clean up LOOP_SET_STATUS lo_flags handlingdrivers/block/loop.c include/uapi/linux/loop.h+21 -80 replies
11/11loop: Add LOOP_CONFIGURE ioctldrivers/block/loop.c include/uapi/linux/loop.h+97 -281 reply

Reviews trailers per patch

All 11 patches have a Reviewed-by or Acked-by.

PatchChristoph HellwigBob LiuBart Van Assche
1/11R-b R-b R-b
2/11R-b
3/11R-b
4/11R-b
5/11R-b
6/11R-b
7/11R-b
8/11R-b
9/11R-b
10/11R-b
11/11R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v5 thread

Cover letter [PATCH v5 00/11] Add a new LOOP_CONFIGURE ioctl

This series introduces a new ioctl that makes it possible to atomically configure a loop device. Previously, if you wanted to set parameters such as the offset on a loop device, this required calling LOOP_SET_FD to set the backing file, and then LOOP_SET_STATUS to set the offset. However, in between these two calls, the loop device is available and would accept requests, which is generally not desirable. Similar issues exist around setting the block size (LOOP_SET_BLOCK_SIZE) and requesting direct I/O mode (LOOP_SET_DIRECT_IO).

There are also performance benefits with combining these ioctls into one, which are described in more detail in the last change in the series.

---
v5:
- Added "loop: Call loop_config_discard() ..." as a first patch to this series, as the rest of the refactoring done depends on it.
- Removed sector_t truncation checks, as suggested by Ming Lei.

v4:
- Addressed review comments from Christoph Hellwig:
-- Minor code cleanups
-- Clarified what lo_flags LOOP_SET_STATUS can set and clear, and
made that more explicit in the code (see [10/11])
-- LOOP_CONFIGURE can now also be used to configure the block size
and to explicitly request Direct I/O and read-only mode.
-- Explicitly reject lo_flags we don't know about in LOOP_CONFIGURE -- Renamed LOOP_SET_FD_AND_STATUS to LOOP_CONFIGURE, since the ioctl
can now do things LOOP_SET_STATUS couldn't do.
v3:
- Addressed review comments from Christoph Hellwig:
-- Factored out loop_validate_size()
-- Split up the largish first patch in a few smaller ones -- Use set_capacity_revalidate_and_notify()
- Fixed a variable wrongly using size_t instead of loff_t
v2:
- Addressed review comments from Bart van Assche:
-- Use SECTOR_SHIFT constant
-- Renamed loop_set_from_status() to loop_set_status_from_info() -- Added kerneldoc for loop_set_status_from_info()
-- Removed dots in patch subject lines
- Addressed review comments from Christoph Hellwig:
-- Added missing padding in struct loop_fd_and_status
-- Cleaned up some __user pointer handling in lo_ioctl -- Pass in a stack-initialized loop_info64 for the legacy
LOOP_SET_FD case

Martijn Coenen (11):
loop: Call loop_config_discard() only after new config is applied
loop: Remove sector_t truncation checks
loop: Factor out setting loop device size
loop: Switch to set_capacity_revalidate_and_notify()
loop: Refactor loop_set_status() size calculation
loop: Remove figure_loop_size()
loop: Factor out configuring loop from status
loop: Move loop_set_status_from_info() and friends up
loop: Rework lo_ioctl() __user argument casting
loop: Clean up LOOP_SET_STATUS lo_flags handling
loop: Add LOOP_CONFIGURE ioctl

 drivers/block/loop.c      | 381 ++++++++++++++++++++++----------------
 include/uapi/linux/loop.h |  31 +++-
 2 files changed, 255 insertions(+), 157 deletions(-)
Signature · 1 line
2.26.2.645.ge9eca65c58-goog