Skip to content

Miscellaneous error handling fixes

Markus Armbruster qemu-arm qemu-devel xen-devel 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest14 patches 14 repliesIn review
  2. v111 patches 10 repliesSuperseded

Changes in v2 from the cover letter

* PATCH 12-14: New

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/14cryptodev: Fix cryptodev_builtin_cleanup() error API violationbackends/cryptodev-builtin.c+2 -80 replies
2/14block/file-posix: Fix check_cache_dropped() error handlingblock/file-posix.c+4 -10 replies
3/14cpus: Fix configure_icount() error API violationcpus.c+30 -210 replies
4/14cpus: Proper range-checking for -icount shift=Ncpus.c+3 -40 replies
5/14arm/virt: Fix virt_machine_device_plug_cb() error API violationhw/arm/virt.c+2 -20 replies
6/14fdc: Fix fallback=auto error handlinghw/block/fdc.c+1 -00 replies
7/14bochs-display: Fix vgamem=SIZE error handlinghw/display/bochs-display.c+4 -21 reply
8/14virtio-net: Fix duplex=... and speed=... error handlinghw/net/virtio-net.c+4 -11 reply
9/14xen/pt: Fix flawed conversion to realize()hw/xen/xen_pt.c+6 -60 replies
10/14io: Fix qio_channel_socket_close() error handlingio/channel-socket.c+3 -20 replies
11/14migration/colo: Fix qmp_xen_colo_do_checkpoint() error handlingmigration/colo.c+7 -10 replies
12/14tests/test-logging: Fix test for -dfilter 0..0xfffffffffffffffftests/test-logging.c+2 -25 replies
13/14qga: Fix qmp_guest_get_memory_blocks() error handlingqga/commands-posix.c+3 -01 reply
14/14qga: Fix qmp_guest_suspend_{disk, ram}() error handlingqga/commands-win32.c+14 -05 replies

Reviews trailers per patch

11 of 14 patches have a Reviewed-by or Acked-by.

PatchPaul DurrantPhilippe Mathieu-DaudéEric BlakeDaniel P. BerrangézhanghailiangZhang ChenMichael S. TsirkinGerd Hoffmann
1/14
2/14R-b
3/14
4/14
5/14R-b
6/14R-b
7/14R-b R-b
8/14R-b A-b
9/14R-b
10/14R-b
11/14R-b R-b R-b
12/14R-b
13/14R-b
14/14R-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 8 reviewers.

Read the v2 thread

Cover letter [PATCH v2 00/14] Miscellaneous error handling fixes

Maintainers decide whether any of these are serious enough to still go into 5.0. I doubt it.

v2:
* PATCH 12-14: New

Markus Armbruster (14):
cryptodev: Fix cryptodev_builtin_cleanup() error API violation block/file-posix: Fix check_cache_dropped() error handling
cpus: Fix configure_icount() error API violation
cpus: Proper range-checking for -icount shift=N arm/virt: Fix virt_machine_device_plug_cb() error API violation
fdc: Fix fallback=auto error handling
bochs-display: Fix vgamem=SIZE error handling
virtio-net: Fix duplex=... and speed=... error handling xen/pt: Fix flawed conversion to realize()
io: Fix qio_channel_socket_close() error handling migration/colo: Fix qmp_xen_colo_do_checkpoint() error handling tests/test-logging: Fix test for -dfilter 0..0xffffffffffffffff
qga: Fix qmp_guest_get_memory_blocks() error handling
qga: Fix qmp_guest_suspend_{disk,ram}() error handling

 backends/cryptodev-builtin.c | 10 ++-----
 block/file-posix.c           |  5 +++-
 cpus.c                       | 52 +++++++++++++++++++++---------------
 hw/arm/virt.c                |  4 +--
 hw/block/fdc.c               |  1 +
 hw/display/bochs-display.c   |  6 +++--
 hw/net/virtio-net.c          |  5 +++-
 hw/xen/xen_pt.c              | 12 ++++-----
 io/channel-socket.c          |  5 ++--
 migration/colo.c             |  8 +++++-
 qga/commands-posix.c         |  3 +++
 qga/commands-win32.c         | 14 ++++++++++
 tests/test-logging.c         |  4 +--
 13 files changed, 82 insertions(+), 47 deletions(-)
Signature · 1 line
2.21.1