Skip to content

Refactor mlx5_ib_create_qp (Part I)

Leon Romanovsky linux-rdma lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest18 patches 5 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/18RDMA/mlx5: Organize QP types checks in one placedrivers/infiniband/hw/mlx5/qp.c+68 -610 replies
2/18RDMA/mlx5: Delete impossible GSI port checkdrivers/infiniband/hw/mlx5/gsi.c+0 -100 replies
3/18RDMA/mlx5: Perform check if QP creation flow is validdrivers/infiniband/hw/mlx5/qp.c+61 -670 replies
4/18RDMA/mlx5: Prepare QP allocation for future removaldrivers/infiniband/hw/mlx5/qp.c+20 -250 replies
5/18RDMA/mlx5: Avoid setting redundant NULL for XRC QPsdrivers/infiniband/hw/mlx5/qp.c+1 -70 replies
6/18RDMA/mlx5: Set QP subtype immediately when it is knowndrivers/infiniband/hw/mlx5/qp.c+2 -40 replies
7/18RDMA/mlx5: Separate create QP flows to be based on typedrivers/infiniband/hw/mlx5/qp.c+39 -150 replies
8/18RDMA/mlx5: Split scatter CQE configuration for DCT QPdrivers/infiniband/hw/mlx5/qp.c+6 -90 replies
9/18RDMA/mlx5: Update all DRIVER QP places to use QP subtypedrivers/infiniband/hw/mlx5/qp.c+15 -330 replies
10/18RDMA/mlx5: Move DRIVER QP flags check into separate functiondrivers/infiniband/hw/mlx5/qp.c+43 -480 replies
11/18RDMA/mlx5: Remove second copy from user for non RSS RAW QPsdrivers/infiniband/hw/mlx5/qp.c+27 -290 replies
12/18RDMA/mlx5: Initial separation of RAW_PACKET QP from common flowdrivers/infiniband/hw/mlx5/qp.c+17 -50 replies
13/18RDMA/mlx5: Delete create QP flags obfuscationdrivers/infiniband/hw/mlx5/devx.c drivers/infiniband/hw/mlx5/flow.c drivers/infiniband/hw/mlx5/main.c +2 more+49 -650 replies
14/18RDMA/mlx5: Process create QP flags in one placedrivers/infiniband/hw/mlx5/qp.c+101 -993 replies
15/18RDMA/mlx5: Use flags_en mechanism to mark QP created with WQE signaturedrivers/infiniband/hw/mlx5/mlx5_ib.h drivers/infiniband/hw/mlx5/odp.c drivers/infiniband/hw/mlx5/qp.c+23 -160 replies
16/18RDMA/mlx5: Change scatter CQE flag to be set like other vendor flagsdrivers/infiniband/hw/mlx5/mlx5_ib.h drivers/infiniband/hw/mlx5/qp.c+10 -80 replies
17/18RDMA/mlx5: Return all configured create flags through query QPdrivers/infiniband/hw/mlx5/mlx5_ib.h drivers/infiniband/hw/mlx5/qp.c+2 -120 replies
18/18RDMA/mlx5: Process all vendor flags in one placedrivers/infiniband/hw/mlx5/qp.c+71 -850 replies

Reviews trailers per patch

All 18 patches have a Reviewed-by or Acked-by.

PatchMaor Gottlieb
1/18R-b
2/18R-b
3/18R-b
4/18R-b
5/18R-b
6/18R-b
7/18R-b
8/18R-b
9/18R-b
10/18R-b
11/18R-b
12/18R-b
13/18R-b
14/18R-b
15/18R-b
16/18R-b
17/18R-b
18/18R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH rdma-next 00/18] Refactor mlx5_ib_create_qp (Part I)

From: Leon Romanovsky <[email protected]>

Hi,

This is first part of series which tries to return some sanity to mlx5_ib_create_qp() function. Such refactoring is required to make extension of that function with less worries of breaking driver.

Extra goal of such refactoring is to ensure that QP is allocated at the beginning of function and released at the end. It will allow us to move QP allocation to be under IB/core responsibility.

It is based on previously sent [1] "[PATCH mlx5-next 00/24] Mass conversion to light mlx5 command interface"

Thanks

[1] https://lore.kernel.org/linux-rdma/[email protected]

Leon Romanovsky (18):
RDMA/mlx5: Organize QP types checks in one place RDMA/mlx5: Delete impossible GSI port check
RDMA/mlx5: Perform check if QP creation flow is valid RDMA/mlx5: Prepare QP allocation for future removal RDMA/mlx5: Avoid setting redundant NULL for XRC QPs RDMA/mlx5: Set QP subtype immediately when it is known RDMA/mlx5: Separate create QP flows to be based on type RDMA/mlx5: Split scatter CQE configuration for DCT QP RDMA/mlx5: Update all DRIVER QP places to use QP subtype RDMA/mlx5: Move DRIVER QP flags check into separate function RDMA/mlx5: Remove second copy from user for non RSS RAW QPs RDMA/mlx5: Initial separation of RAW_PACKET QP from common flow RDMA/mlx5: Delete create QP flags obfuscation
RDMA/mlx5: Process create QP flags in one place RDMA/mlx5: Use flags_en mechanism to mark QP created with WQE
signature
RDMA/mlx5: Change scatter CQE flag to be set like other vendor flags RDMA/mlx5: Return all configured create flags through query QP RDMA/mlx5: Process all vendor flags in one place

 drivers/infiniband/hw/mlx5/devx.c    |   2 +-
 drivers/infiniband/hw/mlx5/flow.c    |   2 +-
 drivers/infiniband/hw/mlx5/gsi.c     |  10 -
 drivers/infiniband/hw/mlx5/main.c    |   9 +-
 drivers/infiniband/hw/mlx5/mlx5_ib.h |  24 +-
 drivers/infiniband/hw/mlx5/odp.c     |   2 +-
 drivers/infiniband/hw/mlx5/qp.c      | 928 +++++++++++++--------------
 7 files changed, 467 insertions(+), 510 deletions(-)

--
2.25.2