Skip to content

Rework iotests/check

Vladimir Sementsov-Ogievskiy qemu-devel 7 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v9 Latest6 patches 14 repliesIn review
  2. v85 patches 10 repliesSuperseded
  3. v711 patches 34 repliesSuperseded
Earlier versions · 4
VersionPostedPatchesRepliesStatus
v611 patches31 repliesSuperseded
v512 patches0 repliesSuperseded
v49 patches9 repliesSuperseded
v310 patches19 repliesSuperseded

Changes in v9 from the cover letter

01: new, one more whitespace-fixing patch
testenv: allow case when we don't have system-arch emulator, but have several for another architectures
change direct os.access(..., os.X_OK) calls to new helper function which also check that path is a file
testrunner: s/fail/not run/ for 'No qualified output'
drop elapsed time arg for one of 'not run' results (now no elapsed time for any 'not run' result)

Patches in v9 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/6iotests: 146: drop extra whitespaces from .out filetests/qemu-iotests/146.out+390 -3901 reply
2/6iotests: add findtests.pydocs/devel/testing.rst tests/qemu-iotests/findtests.py+208 -10 replies
3/6iotests: add testenv.pytests/qemu-iotests/testenv.py+279 -01 reply
4/6iotests: add testrunner.pytests/qemu-iotests/testrunner.py+366 -01 reply
5/6iotests: rewrite check into pythonMakefile tests/check-block.sh tests/qemu-iotests/check +4 more+138 -12950 replies
6/6iotests: rename and move 169 and 199 teststests/qemu-iotests/tests/migrate-bitmaps-postcopy-test tests/qemu-iotests/tests/migrate-bitmaps-postcopy-test.out tests/qemu-iotests/tests/migrate-bitmaps-test +1 more+0 -02 replies

Reviews trailers per patch

2 of 6 patches have a Reviewed-by or Acked-by.

PatchEric Blake
1/6R-b
2/6R-b
3/6
4/6
5/6
6/6

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v9 thread

Cover letter [PATCH v9 0/6] Rework iotests/check

v9:
01: new, one more whitespace-fixing patch
testenv: allow case when we don't have system-arch emulator, but have several for another architectures
change direct os.access(..., os.X_OK) calls to new helper function which also check that path is a file
testrunner: s/fail/not run/ for 'No qualified output'
drop elapsed time arg for one of 'not run' results (now no elapsed time for any 'not run' result)

Vladimir Sementsov-Ogievskiy (6):
iotests: 146: drop extra whitespaces from .out file
iotests: add findtests.py
iotests: add testenv.py
iotests: add testrunner.py
iotests: rewrite check into python
iotests: rename and move 169 and 199 tests

 docs/devel/testing.rst                        |   50 +-
 Makefile                                      |    1 -
 tests/check-block.sh                          |    2 +-
 tests/qemu-iotests/146.out                    |  780 ++++++------
 tests/qemu-iotests/check                      | 1095 ++---------------
 tests/qemu-iotests/common.env.in              |    3 -
 tests/qemu-iotests/findtests.py               |  159 +++
 tests/qemu-iotests/group                      |  321 -----
 tests/qemu-iotests/iotests.py                 |    8 +
 tests/qemu-iotests/meson.build                |    3 -
 tests/qemu-iotests/testenv.py                 |  279 +++++
 tests/qemu-iotests/testrunner.py              |  366 ++++++
 .../migrate-bitmaps-postcopy-test}            |    0
 .../migrate-bitmaps-postcopy-test.out}        |    0
 .../{169 => tests/migrate-bitmaps-test}       |    0
 .../migrate-bitmaps-test.out}                 |    0
 16 files changed, 1381 insertions(+), 1686 deletions(-)
 delete mode 100644 tests/qemu-iotests/common.env.in
 create mode 100644 tests/qemu-iotests/findtests.py
 delete mode 100644 tests/qemu-iotests/group
 create mode 100644 tests/qemu-iotests/testenv.py
 create mode 100644 tests/qemu-iotests/testrunner.py
 rename tests/qemu-iotests/{199 => tests/migrate-bitmaps-postcopy-test} (100%)
 rename tests/qemu-iotests/{199.out => tests/migrate-bitmaps-postcopy-test.out} (100%)
 rename tests/qemu-iotests/{169 => tests/migrate-bitmaps-test} (100%)
 rename tests/qemu-iotests/{169.out => tests/migrate-bitmaps-test.out} (100%)
Signature · 1 line
2.29.2