Skip to content

memory: Sanity checks memory transaction when releasing BQL

Peter Xu qemu-devel 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest8 patches 1 replyIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/8memory: Introduce memory_region_transaction_{push|pop}()memory.c+12 -20 replies
2/8memory: Don't do topology update in memory finalize()memory.c+21 -20 replies
3/8cpus: Use qemu_cond_wait_iothread() where propercpus.c+6 -60 replies
4/8cpus: Introduce qemu_cond_timedwait_iothread()cpus.c include/qemu/main-loop.h+14 -20 replies
5/8cpus: Remove the mutex parameter from do_run_on_cpu()cpus-common.c cpus.c include/hw/core/cpu.h+4 -70 replies
6/8cpus: Introduce qemu_mutex_unlock_iothread_prepare()cpus.c+7 -00 replies
7/8memory: Assert on no ongoing memory transaction before release BQLcpus.c include/exec/memory-internal.h memory.c+9 -00 replies
8/8memory: Delay the transaction pop() until commit completedmemory.c+9 -30 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/8] memory: Sanity checks memory transaction when releasing BQL

This is a continuous work of previous discussion on memory transactions [1]. It should be helpful to fail QEMU far earlier if there's misuse of BQL against the QEMU memory model.

One example is run_on_cpu() during memory commit. That'll work previously, but it'll fail with very strange errors (like KVM ioctl failure due to memslot already existed, and it's not guaranteed to trigger constantly). Now it'll directly fail when run_on_cpu() is called.

Please have a look, thanks.

[1] https://lists.gnu.org/archive/html/qemu-devel/2020-04/msg03205.html

Peter Xu (8):
memory: Introduce memory_region_transaction_{push|pop}()
memory: Don't do topology update in memory finalize()
cpus: Use qemu_cond_wait_iothread() where proper
cpus: Introduce qemu_cond_timedwait_iothread()
cpus: Remove the mutex parameter from do_run_on_cpu()
cpus: Introduce qemu_mutex_unlock_iothread_prepare()
memory: Assert on no ongoing memory transaction before release BQL
memory: Delay the transaction pop() until commit completed

 cpus-common.c                  |  5 ++--
 cpus.c                         | 32 ++++++++++++++------
 include/exec/memory-internal.h |  1 +
 include/hw/core/cpu.h          |  4 +--
 include/qemu/main-loop.h       |  7 +++++
 memory.c                       | 53 ++++++++++++++++++++++++++++++----
 6 files changed, 81 insertions(+), 21 deletions(-)
Signature · 1 line
2.24.1