perf metric fixes and test
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v4 Latest12 patches 10 repliesIn review
- v312 patches 5 repliesSuperseded
- v211 patches 24 repliesSuperseded
Earlier versions · 1
| Version | Posted | Patches | Replies | Status |
|---|---|---|---|---|
| v1 | 8 patches | 10 replies | Superseded |
Patches in v4 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/12 | perf expr: unlimited escaped characters in a symboltools/ | +1 | 1 reply | |
| 2/12 | perf metrics: fix parse errors in cascade lake metricstools/ | +5 | 0 replies | |
| 3/12 | perf metrics: fix parse errors in skylake metricstools/ | +2 | 0 replies | |
| 4/12 | perf expr: allow ',' to be an other tokentools/ | +1 | 0 replies | |
| 5/12 | perf expr: increase max othertools/ | +1 | 0 replies | |
| 6/12 | perf expr: parse numbers as doublestools/ | +7 | 1 reply | |
| 7/12 | perf expr: debug lex if debugging yacctools/ | +1 | 0 replies | |
| 8/12 | perf metrics: fix parse errors in power8 metricstools/ | +1 | 0 replies | |
| 9/12 | perf metrics: fix parse errors in power9 metricstools/ | +1 | 0 replies | |
| 10/12 | perf expr: print a debug message for division by zerotools/ | +12 | 0 replies | |
| 11/12 | perf parse-events: expand add PMU error/verbose messagestools/ tools/ tools/ +2 more | +72 | 0 replies | |
| 12/12 | perf test: improve pmu event metric testingtools/ tools/ tools/ +1 more | +158 | 3 replies |
Reviews trailers per patch
3 of 12 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.
| Patch | Paul A. Clarke | Jiri Olsa |
|---|---|---|
| Series | A-b | |
| 1/12 | ||
| 2/12 | ||
| 3/12 | ||
| 4/12 | ||
| 5/12 | ||
| 6/12 | ||
| 7/12 | ||
| 8/12 | R-b | |
| 9/12 | R-b | |
| 10/12 | ||
| 11/12 | ||
| 12/12 | A-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH v4 00/12] perf metric fixes and test
Add a test that all perf metrics (for your architecture) are parsable with the simple expression parser. Attempt to parse all events in metrics but only fail if the metric is for the current CPU. Fix bugs in the expr parser, x86 and powerpc metrics. Improve debug messages around add PMU config term failures.
v4 rebases after Kajol Jain's patches and fixes an asprintf warning. v3 adds parse event testing of ids and improves debug messages for add
PMU. These messages are paticular visible with 'perf test 10 -vvv'. It moves the testing logic from tests/expr.c to tests/pmu-events.c as suggested by John Garry <[email protected]>.
v2 adds Fixes tags to commit messages for when broken metrics were
first added. Adds a debug warning for division by zero in expr, and adds a workaround for id values in the expr test necessary for powerpc. It also fixes broken power8 and power9 metrics.
Ian Rogers (12):
perf expr: unlimited escaped characters in a symbol perf metrics: fix parse errors in cascade lake metrics perf metrics: fix parse errors in skylake metrics perf expr: allow ',' to be an other token
perf expr: increase max other
perf expr: parse numbers as doubles
perf expr: debug lex if debugging yacc
perf metrics: fix parse errors in power8 metrics perf metrics: fix parse errors in power9 metrics perf expr: print a debug message for division by zero perf parse-events: expand add PMU error/verbose messages perf test: improve pmu event metric testing
tools/perf/arch/x86/util/intel-pt.c | 32 ++-- .../arch/powerpc/power8/metrics.json | 2 +- .../arch/powerpc/power9/metrics.json | 2 +- .../arch/x86/cascadelakex/clx-metrics.json | 10 +- .../arch/x86/skylakex/skx-metrics.json | 4 +- tools/perf/tests/builtin-test.c | 5 + tools/perf/tests/expr.c | 1 + tools/perf/tests/pmu-events.c | 156 +++++++++++++++++- tools/perf/tests/pmu.c | 4 +- tools/perf/tests/tests.h | 2 + tools/perf/util/expr.c | 1 + tools/perf/util/expr.h | 2 +- tools/perf/util/expr.l | 16 +- tools/perf/util/expr.y | 16 +- tools/perf/util/parse-events.c | 29 +++- tools/perf/util/pmu.c | 33 ++-- tools/perf/util/pmu.h | 2 +- 17 files changed, 262 insertions(+), 55 deletions(-)
Signature · 1 line
2.26.2.526.g744177e7f7-goog