Skip to content

perf metric fixes and test

Ian Rogers linux-perf-users lkml 4 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v4 Latest12 patches 10 repliesIn review
  2. v312 patches 5 repliesSuperseded
  3. v211 patches 24 repliesSuperseded
Earlier versions · 1
VersionPostedPatchesRepliesStatus
v18 patches10 repliesSuperseded

Patches in v4 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/12perf expr: unlimited escaped characters in a symboltools/perf/util/expr.l+1 -11 reply
2/12perf metrics: fix parse errors in cascade lake metricstools/perf/pmu-events/arch/x86/cascadelakex/clx-metrics.json+5 -50 replies
3/12perf metrics: fix parse errors in skylake metricstools/perf/pmu-events/arch/x86/skylakex/skx-metrics.json+2 -20 replies
4/12perf expr: allow ',' to be an other tokentools/perf/util/expr.y+1 -10 replies
5/12perf expr: increase max othertools/perf/util/expr.h+1 -10 replies
6/12perf expr: parse numbers as doublestools/perf/util/expr.l+7 -71 reply
7/12perf expr: debug lex if debugging yacctools/perf/util/expr.c+1 -00 replies
8/12perf metrics: fix parse errors in power8 metricstools/perf/pmu-events/arch/powerpc/power8/metrics.json+1 -10 replies
9/12perf metrics: fix parse errors in power9 metricstools/perf/pmu-events/arch/powerpc/power9/metrics.json+1 -10 replies
10/12perf expr: print a debug message for division by zerotools/perf/util/expr.y+12 -20 replies
11/12perf parse-events: expand add PMU error/verbose messagestools/perf/arch/x86/util/intel-pt.c tools/perf/tests/pmu.c tools/perf/util/parse-events.c +2 more+72 -280 replies
12/12perf test: improve pmu event metric testingtools/perf/tests/builtin-test.c tools/perf/tests/expr.c tools/perf/tests/pmu-events.c +1 more+158 -63 replies

Reviews trailers per patch

3 of 12 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchPaul A. ClarkeJiri Olsa
SeriesA-b
1/12
2/12
3/12
4/12
5/12
6/12
7/12
8/12R-b
9/12R-b
10/12
11/12
12/12A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v4 thread

Cover letter [PATCH v4 00/12] perf metric fixes and test

Add a test that all perf metrics (for your architecture) are parsable with the simple expression parser. Attempt to parse all events in metrics but only fail if the metric is for the current CPU. Fix bugs in the expr parser, x86 and powerpc metrics. Improve debug messages around add PMU config term failures.

v4 rebases after Kajol Jain's patches and fixes an asprintf warning. v3 adds parse event testing of ids and improves debug messages for add
PMU. These messages are paticular visible with 'perf test 10 -vvv'. It moves the testing logic from tests/expr.c to tests/pmu-events.c as suggested by John Garry <[email protected]>.
v2 adds Fixes tags to commit messages for when broken metrics were
first added. Adds a debug warning for division by zero in expr, and adds a workaround for id values in the expr test necessary for powerpc. It also fixes broken power8 and power9 metrics.

Ian Rogers (12):
perf expr: unlimited escaped characters in a symbol perf metrics: fix parse errors in cascade lake metrics perf metrics: fix parse errors in skylake metrics perf expr: allow ',' to be an other token
perf expr: increase max other
perf expr: parse numbers as doubles
perf expr: debug lex if debugging yacc
perf metrics: fix parse errors in power8 metrics perf metrics: fix parse errors in power9 metrics perf expr: print a debug message for division by zero perf parse-events: expand add PMU error/verbose messages perf test: improve pmu event metric testing

 tools/perf/arch/x86/util/intel-pt.c           |  32 ++--
 .../arch/powerpc/power8/metrics.json          |   2 +-
 .../arch/powerpc/power9/metrics.json          |   2 +-
 .../arch/x86/cascadelakex/clx-metrics.json    |  10 +-
 .../arch/x86/skylakex/skx-metrics.json        |   4 +-
 tools/perf/tests/builtin-test.c               |   5 +
 tools/perf/tests/expr.c                       |   1 +
 tools/perf/tests/pmu-events.c                 | 156 +++++++++++++++++-
 tools/perf/tests/pmu.c                        |   4 +-
 tools/perf/tests/tests.h                      |   2 +
 tools/perf/util/expr.c                        |   1 +
 tools/perf/util/expr.h                        |   2 +-
 tools/perf/util/expr.l                        |  16 +-
 tools/perf/util/expr.y                        |  16 +-
 tools/perf/util/parse-events.c                |  29 +++-
 tools/perf/util/pmu.c                         |  33 ++--
 tools/perf/util/pmu.h                         |   2 +-
 17 files changed, 262 insertions(+), 55 deletions(-)
Signature · 1 line
2.26.2.526.g744177e7f7-goog