Skip to content

elf: add better bootm support

Clement Leger barebox 6 versions – Applied

Status from this message: Applied, thanks

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v6 Latest8 patches 3 repliesApplied
  2. v57 patches 3 repliesSuperseded
  3. v47 patches 7 repliesSuperseded
Earlier versions · 3
VersionPostedPatchesRepliesStatus
v37 patches2 repliesSuperseded
v26 patches7 repliesSuperseded
v16 patches3 repliesSuperseded

Changes in v6 from the cover letter

- Add missing elf boundaries computation patch

Patches in v6 Applied

#Subject and filesSizeRepliesApplied
1/8common: elf: add computation of elf boundariescommon/elf.c include/elf.h+14 -00 replies
2/8common: elf: fix warning on 32 bits architecturescommon/elf.c+1 -10 replies
3/8common: elf: use calloc instead of xzalloccommon/elf.c+4 -10 replies
4/8common: elf: check number of elf program headerscommon/elf.c+5 -00 replies
5/8common: elf: load elf directly from filearch/mips/lib/bootm.c common/elf.c include/elf.h+191 -440 replies
6/8common: elf: add elf_open, elf_close and elf_loadarch/mips/lib/bootm.c common/elf.c include/elf.h+16 -170 replies
7/8common: bootm: add support for elf file loadingcommon/Kconfig common/bootm.c include/bootm.h+44 -00 replies
8/8mips: lib: bootm: use bootm elf loading capabilitiesarch/mips/lib/bootm.c+7 -130 replies

Reviews trailers per patch

None of the 8 patches has a Reviewed-by or Acked-by.

PatchOleksij Rempel
SeriesT-b
1/8
2/8
3/8
4/8
5/8
6/8
7/8
8/8

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v6 thread

Cover letter [PATCH v6 0/8] elf: add better bootm support

Currently, when booting an elf file using "bootm /dev/mtdx", bootm will simply pass the file to the bootm handler and the read done on it will read the entire flash partition. This series starts by some cleanup and then modify the elf loader to load the elf file without copying the whole elf file to an intermediate buffer. Only the elf header is copied in order to parse the elf file into a list of segment and then, the segments are loaded directly from the file.

A special handling for the elf file is also added in bootm data to allow using directly the elf file structure. Finally the mips bootm handler is modified to use bootm_load_os directly instead of manual elf loading.

Compilation for both mips and arm has been tested but run on qemu-malta was not possible. Changes have been tested on kvx architecture for which bootm support has been added and will be submitted.

Changes v5 -> v6
- Add missing elf boundaries computation patch

Changes v4 -> v5
- Rework elf loading to load from file rather than a buffer
- Use calloc instead of xzalloc in elf file loading
- Add check of program headers in elf check

Changes v3 -> v4
- Fix init of elf entry address to be used by bootm_load_elf

Changes v2 -> v3
- Integrate elf loading in bootm_load_os
- Add patch to remove now unused elf_load_image/elf_release_image
- Use malloc instead of xmalloc and check return value

Changes v1 -> v2
- Add BOOTM_ELF config to select elf support and add checks in code
- Add an elf_get_mem_size function to avoid computing elf size in bootm.c
- Use xmalloc and read_full in elf_open instead of xzalloc/read
- Fix data->elf NULL reset
- Remove elf struct entirely from mips bootm code

Clement Leger (8):
common: elf: add computation of elf boundaries
common: elf: fix warning on 32 bits architectures
common: elf: use calloc instead of xzalloc
common: elf: check number of elf program headers
common: elf: load elf directly from file
common: elf: add elf_open, elf_close and elf_load
common: bootm: add support for elf file loading
mips: lib: bootm: use bootm elf loading capabilities

 arch/mips/lib/bootm.c |  25 ++---
 common/Kconfig        |   8 ++
 common/bootm.c        |  33 ++++++
 common/elf.c          | 231 +++++++++++++++++++++++++++++++++++-------
 include/bootm.h       |   3 +
 include/elf.h         |  16 ++-
 6 files changed, 261 insertions(+), 55 deletions(-)
Signature · 7 lines
2.17.1


_______________________________________________
barebox mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/barebox