Skip to content

objtool vs retpoline

Peter Zijlstra lkml 2 versions – Applied

Status from this message: The following commit has been merged into the objtool/core branch of tip:

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest14 patches 12 repliesApplied
  2. v18 patches 15 repliesSuperseded

Patches in v2 Applied

#Subject and filesSizeRepliesApplied
1/14objtool: Allow branches within the same alternative.tools/objtool/check.c tools/objtool/check.h+22 -71 reply
2/14objtool: Fix ORC vs alternativestools/objtool/Documentation/stack-validation.txt tools/objtool/check.c+40 -14 replies
3/14x86,smap: Fix smap_{save,restore}() alternativesarch/x86/include/asm/smap.h+7 -44 replies
4/14objtool: is_fentry_call() crashes if call has no destinationtools/objtool/check.c+1 -10 replies
5/14objtool: UNWIND_HINT_RET_OFFSET should not check registerstools/objtool/check.c+8 -00 replies
6/14objtool: Rework allocating stack_ops on decodetools/objtool/arch/x86/decode.c+147 -1040 replies
7/14objtool: Make handle_insn_ops() unconditionaltools/objtool/check.c+3 -51 reply
8/14objtool: Remove INSN_STACKtools/objtool/arch.h tools/objtool/arch/x86/decode.c tools/objtool/check.c+0 -270 replies
9/14objtool: Move the IRET hack into the arch decodertools/objtool/arch.h tools/objtool/arch/x86/decode.c tools/objtool/check.c +2 more+21 -250 replies
10/14objtool: Add support for intra-function callsinclude/linux/frame.h tools/objtool/Documentation/stack-validation.txt tools/objtool/arch/x86/decode.c +1 more+102 -40 replies
11/14x86/speculation: Change FILL_RETURN_BUFFER to work with objtoolarch/x86/include/asm/nospec-branch.h+10 -60 replies
12/14x86: Simplify retpoline declarationarch/x86/include/asm/GEN-for-each-reg.h arch/x86/include/asm/asm-prototypes.h arch/x86/lib/retpoline.S+48 -400 replies
13/14x86: Change {JMP,CALL}_NOSPEC argumentarch/x86/crypto/aesni-intel_asm.S arch/x86/crypto/camellia-aesni-avx-asm_64.S arch/x86/crypto/camellia-aesni-avx2-asm_64.S +8 more+35 -350 replies
14/14x86/retpoline: Fix retpoline unwindarch/x86/include/asm/asm-prototypes.h arch/x86/include/asm/nospec-branch.h arch/x86/lib/retpoline.S+38 -510 replies

Reviews trailers per patch

3 of 14 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchAlexandre ChartreJosh PoimboeufMiroslav Benes
SeriesA-b R-b
1/14
2/14A-b
3/14
4/14
5/14
6/14R-b
7/14
8/14
9/14
10/14
11/14R-b
12/14
13/14
14/14

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v2 thread

Cover letter [PATCH v2 00/14] objtool vs retpoline

Hi,

Based on Alexandre's patches, here's a few that go on top of tip/objtool/core.

With these patches on objtool can completely understand retpolines and RSB stuffing, which means it can emit valid ORC unwind information for them, which in turn means we can now unwind through a retpoline.

New since last time:

- 1-3, alternatives vs ORC unwind
- 7-9: implement some suggestions from Julien
- addressed feedback