Skip to content

qapi: Spring cleaning

Markus Armbruster qemu-devel 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest15 patches 7 repliesIn review
  2. v113 patches 16 repliesSuperseded

Changes in v2 from the cover letter

* PATCH 10: Redone to avoid memory leak [Eric]
* PATCH 14+15: New

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/15qapi: Belatedly update visitor.h's big comment for QAPI modulesinclude/qapi/visitor.h+5 -50 replies
2/15qapi: Fix the virtual walk example in visitor.h's big commentinclude/qapi/visitor.h+3 -10 replies
3/15qapi: Fix typo in visit_start_list()'s contractinclude/qapi/visitor.h+2 -20 replies
4/15qapi: Document @errp usage more thoroughly in visitor.hinclude/qapi/visitor.h+23 -140 replies
5/15qapi: Polish prose in visitor.hinclude/qapi/visitor.h+54 -500 replies
6/15qapi: Assert incomplete object occurs only in dealloc visitordocs/devel/qapi-code-gen.txt include/qapi/visitor.h qapi/qapi-visit-core.c +1 more+16 -02 replies
7/15qapi: Fix Visitor contract for start_alternate()include/qapi/visitor-impl.h qapi/qapi-dealloc-visitor.c+2 -100 replies
8/15qapi: Assert output visitors see only valid enum valuesqapi/qapi-visit-core.c tests/test-qobject-output-visitor.c tests/test-string-output-visitor.c+0 -670 replies
9/15qapi: Assert non-input visitors see only valid narrow integersqapi/qapi-visit-core.c+6 -00 replies
10/15qapi: Clean up visitor's recovery from input with invalid typescripts/qapi/visit.py+3 -01 reply
11/15qapi: Assert non-input visitors see only valid alternate tagsscripts/qapi/visit.py+1 -00 replies
12/15qapi: Only input visitors can actually failblock.c block/sheepdog.c blockdev.c +4 more+35 -480 replies
13/15qom: Simplify object_property_get_enum()qom/object.c+1 -30 replies
14/15qapi: Disallow qmp_marshal_FOO(NULL, ...)docs/devel/qapi-code-gen.txt monitor/qmp.c scripts/qapi/commands.py+7 -261 reply
15/15qapi: Generate simpler marshalling code when no argumentsscripts/qapi/commands.py+24 -161 reply

Reviews trailers per patch

All 15 patches have a Reviewed-by or Acked-by.

PatchEric Blake
1/15R-b
2/15R-b
3/15R-b
4/15R-b
5/15R-b
6/15R-b
7/15R-b
8/15R-b
9/15R-b
10/15R-b
11/15R-b
12/15R-b
13/15R-b
14/15R-b
15/15R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 00/15] qapi: Spring cleaning

v2:
* PATCH 10: Redone to avoid memory leak [Eric]
* PATCH 14+15: New

Since PATCH 14 depends on "[PATCH 2/3] fuzz: Simplify how we compute available machines and types":
Based-on: <[email protected]>

Markus Armbruster (15):
qapi: Belatedly update visitor.h's big comment for QAPI modules
qapi: Fix the virtual walk example in visitor.h's big comment
qapi: Fix typo in visit_start_list()'s contract
qapi: Document @errp usage more thoroughly in visitor.h
qapi: Polish prose in visitor.h
qapi: Assert incomplete object occurs only in dealloc visitor
qapi: Fix Visitor contract for start_alternate()
qapi: Assert output visitors see only valid enum values
qapi: Assert non-input visitors see only valid narrow integers
qapi: Clean up visitor's recovery from input with invalid type
qapi: Assert non-input visitors see only valid alternate tags
qapi: Only input visitors can actually fail
qom: Simplify object_property_get_enum()
qapi: Disallow qmp_marshal_FOO(NULL, ...)
qapi: Generate simpler marshalling code when no arguments

 docs/devel/qapi-code-gen.txt        |   4 +-
 include/qapi/visitor-impl.h         |   9 +-
 include/qapi/visitor.h              | 192 ++++++++++++++++------------
 block.c                             |   9 +-
 block/sheepdog.c                    |   9 +-
 blockdev.c                          |  16 +--
 hw/core/machine-hmp-cmds.c          |   2 +-
 monitor/hmp-cmds.c                  |   3 +-
 monitor/qmp.c                       |   5 +-
 qapi/qapi-dealloc-visitor.c         |   7 -
 qapi/qapi-visit-core.c              |  20 +--
 qom/object.c                        |   4 +-
 tests/test-qobject-output-visitor.c |  39 ------
 tests/test-string-output-visitor.c  |  19 ---
 scripts/qapi/commands.py            |  62 ++++-----
 scripts/qapi/visit.py               |   8 ++
 16 files changed, 174 insertions(+), 234 deletions(-)
Signature · 1 line
2.21.1