qapi: Spring cleaning
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v2 Latest15 patches 7 repliesIn review
- v113 patches 16 repliesSuperseded
Changes in v2 from the cover letter
* PATCH 10: Redone to avoid memory leak [Eric]
* PATCH 14+15: New
Patches in v2 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/15 | qapi: Belatedly update visitor.h's big comment for QAPI modulesinclude/ | +5 | 0 replies | |
| 2/15 | qapi: Fix the virtual walk example in visitor.h's big commentinclude/ | +3 | 0 replies | |
| 3/15 | qapi: Fix typo in visit_start_list()'s contractinclude/ | +2 | 0 replies | |
| 4/15 | qapi: Document @errp usage more thoroughly in visitor.hinclude/ | +23 | 0 replies | |
| 5/15 | qapi: Polish prose in visitor.hinclude/ | +54 | 0 replies | |
| 6/15 | qapi: Assert incomplete object occurs only in dealloc visitordocs/ include/ qapi/ +1 more | +16 | 2 replies | |
| 7/15 | qapi: Fix Visitor contract for start_alternate()include/ qapi/ | +2 | 0 replies | |
| 8/15 | qapi: Assert output visitors see only valid enum valuesqapi/ tests/ tests/ | +0 | 0 replies | |
| 9/15 | qapi: Assert non-input visitors see only valid narrow integersqapi/ | +6 | 0 replies | |
| 10/15 | qapi: Clean up visitor's recovery from input with invalid typescripts/ | +3 | 1 reply | |
| 11/15 | qapi: Assert non-input visitors see only valid alternate tagsscripts/ | +1 | 0 replies | |
| 12/15 | qapi: Only input visitors can actually failblock.c block/ blockdev.c +4 more | +35 | 0 replies | |
| 13/15 | qom: Simplify object_property_get_enum()qom/ | +1 | 0 replies | |
| 14/15 | qapi: Disallow qmp_marshal_FOO(NULL, ...)docs/ monitor/ scripts/ | +7 | 1 reply | |
| 15/15 | qapi: Generate simpler marshalling code when no argumentsscripts/ | +24 | 1 reply |
Reviews trailers per patch
All 15 patches have a Reviewed-by or Acked-by.
| Patch | Eric Blake |
|---|---|
| 1/15 | R-b |
| 2/15 | R-b |
| 3/15 | R-b |
| 4/15 | R-b |
| 5/15 | R-b |
| 6/15 | R-b |
| 7/15 | R-b |
| 8/15 | R-b |
| 9/15 | R-b |
| 10/15 | R-b |
| 11/15 | R-b |
| 12/15 | R-b |
| 13/15 | R-b |
| 14/15 | R-b |
| 15/15 | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH v2 00/15] qapi: Spring cleaning
v2:
* PATCH 10: Redone to avoid memory leak [Eric]
* PATCH 14+15: New
Since PATCH 14 depends on "[PATCH 2/3] fuzz: Simplify how we compute available machines and types":
Based-on: <[email protected]>
Markus Armbruster (15):
qapi: Belatedly update visitor.h's big comment for QAPI modules
qapi: Fix the virtual walk example in visitor.h's big comment
qapi: Fix typo in visit_start_list()'s contract
qapi: Document @errp usage more thoroughly in visitor.h
qapi: Polish prose in visitor.h
qapi: Assert incomplete object occurs only in dealloc visitor
qapi: Fix Visitor contract for start_alternate()
qapi: Assert output visitors see only valid enum values
qapi: Assert non-input visitors see only valid narrow integers
qapi: Clean up visitor's recovery from input with invalid type
qapi: Assert non-input visitors see only valid alternate tags
qapi: Only input visitors can actually fail
qom: Simplify object_property_get_enum()
qapi: Disallow qmp_marshal_FOO(NULL, ...)
qapi: Generate simpler marshalling code when no arguments
docs/devel/qapi-code-gen.txt | 4 +- include/qapi/visitor-impl.h | 9 +- include/qapi/visitor.h | 192 ++++++++++++++++------------ block.c | 9 +- block/sheepdog.c | 9 +- blockdev.c | 16 +-- hw/core/machine-hmp-cmds.c | 2 +- monitor/hmp-cmds.c | 3 +- monitor/qmp.c | 5 +- qapi/qapi-dealloc-visitor.c | 7 - qapi/qapi-visit-core.c | 20 +-- qom/object.c | 4 +- tests/test-qobject-output-visitor.c | 39 ------ tests/test-string-output-visitor.c | 19 --- scripts/qapi/commands.py | 62 ++++----- scripts/qapi/visit.py | 8 ++ 16 files changed, 174 insertions(+), 234 deletions(-)
Signature · 1 line
2.21.1