Enable FSGSBASE instructions
Status from this message: The following commit has been merged into the x86/fsgsbase branch of tip:
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v13 Latest16 patches 5 repliesApplied
- v1218 patches 57 repliesSuperseded
- v1118 patches 4 repliesSuperseded
Earlier versions · 1
| Version | Posted | Patches | Replies | Status |
|---|---|---|---|---|
| v10 | 18 patches | 8 replies | Superseded |
Changes in v13 from the cover letter
- Reformat the series to be closer to the reverted codebase for easier review.
- Drop a few of the changes introduced in v8 and v9.
Patches in v13 Applied
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/16 | x86/ptrace: Prevent ptrace from clearing the FS/GS selectorarch/ | +2 | 0 replies | |
| 2/16 | x86/cpu: Add 'unsafe_fsgsbase' to enable CR4.FSGSBASEDocumentation/ arch/ | +27 | 0 replies | |
| 3/16 | x86/fsgsbase/64: Add intrinsics for FSGSBASE instructionsarch/ | +30 | 0 replies | |
| 4/16 | x86/fsgsbase/64: Enable FSGSBASE instructions in helper functionsarch/ arch/ | +76 | 0 replies | |
| 5/16 | x86/process/64: Use FSBSBASE in switch_to() if availablearch/ | +28 | 0 replies | |
| 6/16 | x86/process/64: Make save_fsgs() public availablearch/ arch/ arch/ | +11 | 0 replies | |
| 7/16 | x86/process/64: Use FSGSBASE instructions on thread copy and ptracearch/ arch/ | +10 | 0 replies | |
| 8/16 | x86/speculation/swapgs: Check FSGSBASE in enabling SWAPGS mitigationarch/ | +2 | 0 replies | |
| 9/16 | x86/entry/64: Switch CR3 before SWAPGS in paranoid entryarch/ | +24 | 0 replies | |
| 10/16 | x86/entry/64: Introduce the FIND_PERCPU_BASE macroarch/ arch/ | +49 | 0 replies | |
| 11/16 | x86/entry/64: Handle FSGSBASE enabled paranoid entry/exitarch/ arch/ | +91 | 0 replies | |
| 12/16 | x86/cpu: Enable FSGSBASE on 64bit by default and add a chicken bitDocumentation/ arch/ | +15 | 0 replies | |
| 13/16 | x86/elf: Enumerate kernel FSGSBASE capability in AT_HWCAP2arch/ arch/ | +6 | 1 reply | |
| 14/16 | Documentation/x86/64: Add documentation for GS/FS addressing modeDocumentation/ Documentation/ | +200 | 0 replies | |
| 15/16 | selftests/x86/fsgsbase: Test GS selector on ptracer-induced GS base writetools/ | +15 | 1 reply | |
| 16/16 | selftests/x86/fsgsbase: Test ptracer-induced GS base write with FSGSBASEtools/ | +9 | 1 reply |
Reviews trailers per patch
8 of 16 patches have a Reviewed-by or Acked-by.
| Patch | Andy Lutomirski | Andi Kleen | Tony Luck | Dave Hansen |
|---|---|---|---|---|
| 1/16 | ||||
| 2/16 | R-b | R-b | ||
| 3/16 | R-b | R-b | ||
| 4/16 | ||||
| 5/16 | R-b | |||
| 6/16 | ||||
| 7/16 | ||||
| 8/16 | ||||
| 9/16 | ||||
| 10/16 | ||||
| 11/16 | ||||
| 12/16 | R-b | |||
| 13/16 | A-b | |||
| 14/16 | Originally-by | R-b | ||
| 15/16 | Originally-by | R-b | ||
| 16/16 | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 4 reviewers.
Cover letter [PATCH v13 00/16] Enable FSGSBASE instructions
Benefits:
Currently a user process that wishes to read or write the FS/GS base must make a system call. But recent X86 processors have added new instructions for use in 64-bit mode that allow direct access to the FS and GS segment base addresses. The operating system controls whether applications can use these instructions with a %cr4 control bit.
In addition to benefits to applications, performance improvements to the OS context switch code are possible by making use of these instructions. A third party reported out promising performance numbers out of their initial benchmarking of the previous version of this patch series.
Enablement check:
The kernel provides information about the enabled state of FSGSBASE to applications using the ELF_AUX vector. If the HWCAP2_FSGSBASE bit is set in the AUX vector, the kernel has FSGSBASE instructions enabled and applications can use them.
Kernel changes:
Major changes made in the kernel are in context switch, paranoid path, and ptrace. In a context switch, a task's FS/GS base will be secured regardless of its selector. In the paranoid path, GS base is unconditionally overwritten to the kernel GS base on entry and the original GS base is restored on exit. Ptrace includes divergence of FS/GS index and base values.
Security:
For mitigating the Spectre v1 SWAPGS issue, LFENCE instructions were added on most kernel entries. Those patches are dependent on previous behaviors that users couldn't load a kernel address into the GS base. These patches change that assumption since the user can load any address into GS base. The changes to the kernel entry path in this patch series take account of the SWAPGS issue.
Changes from v12:
- Reformat the series to be closer to the reverted codebase for easier review.
- Drop a few of the changes introduced in v8 and v9.
Andi Kleen (2):
x86/fsgsbase/64: Add intrinsics for FSGSBASE instructions x86/elf: Enumerate kernel FSGSBASE capability in AT_HWCAP2
Andy Lutomirski (3):
x86/cpu: Add 'unsafe_fsgsbase' to enable CR4.FSGSBASE x86/process/64: Use FSBSBASE in switch_to() if available x86/cpu: Enable FSGSBASE on 64bit by default and add a chicken bit
Chang S. Bae (8):
x86/ptrace: Prevent ptrace from clearing the FS/GS selector x86/fsgsbase/64: Enable FSGSBASE instructions in helper functions x86/process/64: Use FSGSBASE instructions on thread copy and ptrace x86/entry/64: Switch CR3 before SWAPGS in paranoid entry x86/entry/64: Introduce the FIND_PERCPU_BASE macro x86/entry/64: Handle FSGSBASE enabled paranoid entry/exit selftests/x86/fsgsbase: Test GS selector on ptracer-induced GS base
write
selftests/x86/fsgsbase: Test ptracer-induced GS base write with
FSGSBASE
Thomas Gleixner (2):
x86/process/64: Make save_fsgs() public available Documentation/x86/64: Add documentation for GS/FS addressing mode
Tony Luck (1):
x86/speculation/swapgs: Check FSGSBASE in enabling SWAPGS mitigation
.../admin-guide/kernel-parameters.txt | 2 + Documentation/x86/x86_64/fsgs.rst | 199 ++++++++++++++++++ Documentation/x86/x86_64/index.rst | 1 + arch/x86/entry/calling.h | 40 ++++ arch/x86/entry/entry_64.S | 135 +++++++++--- arch/x86/include/asm/fsgsbase.h | 45 +++- arch/x86/include/asm/inst.h | 15 ++ arch/x86/include/asm/processor.h | 4 +- arch/x86/include/uapi/asm/hwcap2.h | 3 + arch/x86/kernel/cpu/bugs.c | 6 +- arch/x86/kernel/cpu/common.c | 22 ++ arch/x86/kernel/process.c | 10 +- arch/x86/kernel/process_64.c | 119 +++++++++-- arch/x86/kernel/ptrace.c | 17 +- arch/x86/kvm/vmx/vmx.c | 2 +- tools/testing/selftests/x86/fsgsbase.c | 24 ++- 16 files changed, 562 insertions(+), 82 deletions(-) create mode 100644 Documentation/x86/x86_64/fsgs.rst
Signature · 1 line
2.25.1