Skip to content

Yordan Karadzhov (VMware) linux-trace-devel 3 versions – New

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest3 patches 0 repliesNew
  2. v23 patches 0 repliesSuperseded
  3. v12 patches 3 repliesSuperseded

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3kernel-shark: Add methods for selecting the plots to be shownkernel-shark/src/KsMainWindow.cpp kernel-shark/src/KsMainWindow.hpp+43 -00 replies
2/3kernel-shark: Add command line options for selecting plots to be shownkernel-shark/src/KsUtils.cpp kernel-shark/src/KsUtils.hpp kernel-shark/src/kernelshark.cpp+64 -30 replies
3/3kernel-shark: Set a maximum number of plots to be shown by defaultkernel-shark/src/KsGLWidget.cpp+11 -20 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v3 yet.

Read the v3 thread

Cover letter [PATCH v3 0/3]

The patch-set implements new commandline options for KernelShark that can be used to pre-select the CPU and Task plots to be shown, before opening the GUI. The idea was suggested by Julia Lawall.

Changes is v2:
- Fixing a bug in the parsing of the string representing the list of IDs, given to the command line options.

- New Patch 3/3 that limits the number of CPU plots shown by default when KernelShark starts.

Changes is v3:
- Switching to using comma instead of space for separating the Ids (Pid or CPU) of the plots. This way we don't need to worry about quoting the arguments.

- Adding to patch [2/3] logic to handle the case when the user uses the "--cpu" or "--pid" options multiple times.

Yordan Karadzhov (VMware) (3):
kernel-shark: Add methods for selecting the plots to be shown
kernel-shark: Add command line options for selecting plots to be shown
kernel-shark: Set a maximum number of plots to be shown by default

 kernel-shark/src/KsGLWidget.cpp   | 13 +++++++++--
 kernel-shark/src/KsMainWindow.cpp | 39 +++++++++++++++++++++++++++++++
 kernel-shark/src/KsMainWindow.hpp |  4 ++++
 kernel-shark/src/KsUtils.cpp      | 24 +++++++++++++++++++
 kernel-shark/src/KsUtils.hpp      |  2 ++
 kernel-shark/src/kernelshark.cpp  | 34 ++++++++++++++++++++++++---
 6 files changed, 111 insertions(+), 5 deletions(-)
Signature · 1 line
2.20.1