mm/slub: Fix sysfs circular locking dependency
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v2 Latest4 patches 11 repliesIn review
- v12 patches 5 repliesSuperseded
Changes in v2 from the cover letter
- Use regular cmpxchg() instead of x86-only try_cmpxchg() in patch 2.
- Add patches 3 and 4 to fix circular locking dependency showing up at shutdown time.
Patches in v2 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/4 | mm, slab: Revert "extend slab/shrink to shrink all memcg caches"mm/ mm/ mm/ | +1 | 0 replies | |
| 2/4 | mm/slub: Fix slab_mutex circular locking problem in slab_attr_store()mm/ | +50 | 0 replies | |
| 3/4 | mm/slub: Fix another circular locking dependency in slab_attr_store()include/ mm/ mm/ | +29 | 3 replies | |
| 4/4 | mm/slub: Fix sysfs shrink circular locking dependencyinclude/ mm/ mm/ | +22 | 7 replies |
Reviews trailers per patch
1 of 4 patches has a Reviewed-by or Acked-by.
| Patch | Qian Cai |
|---|---|
| Series | T-b |
| 1/4 | |
| 2/4 | |
| 3/4 | |
| 4/4 | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH v2 0/4] mm/slub: Fix sysfs circular locking dependency
v2:
- Use regular cmpxchg() instead of x86-only try_cmpxchg() in patch 2.
- Add patches 3 and 4 to fix circular locking dependency showing up at shutdown time.
With lockdep enabled, issuing the following command to the slub sysfs files will cause splat about circular locking dependency to show up either immediately afterwards or at shutdown time.
# echo 1 > validate # echo 1 > shrink
This patchset fixes these lockdep splats by replacing slab_mutex with memcg_cache_ids_sem as well as changing some of the lock operations with trylock.
Waiman Long (4):
mm, slab: Revert "extend slab/shrink to shrink all memcg caches" mm/slub: Fix slab_mutex circular locking problem in slab_attr_store() mm/slub: Fix another circular locking dependency in slab_attr_store() mm/slub: Fix sysfs shrink circular locking dependency
include/linux/memcontrol.h | 1 + include/linux/memory_hotplug.h | 2 + mm/memcontrol.c | 5 ++ mm/memory_hotplug.c | 5 ++ mm/slab.h | 1 - mm/slab_common.c | 37 ------------- mm/slub.c | 98 +++++++++++++++++++++++++++++----- 7 files changed, 99 insertions(+), 50 deletions(-)
Signature · 1 line
2.18.1