Skip to content

More miscellaneous error handling fixes

Markus Armbruster qemu-devel xen-devel 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest10 patches 6 repliesIn review
  2. v111 patches 19 repliesSuperseded

Changes in v2 from the cover letter

* PATCH 2: missing return [Paul]
* PATCH 3: commit message typo [David]
* PATCH 5: error message tidied up [Eric, Philippe]
* PATCH 7: commit message pasto
* Old PATCH 4 dropped [Matthew]

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/10nvdimm: Plug memory leak in uuid property setterhw/mem/nvdimm.c+0 -11 reply
2/10xen: Fix and improve handling of device_add usb-host errorshw/usb/xen-usb.c+9 -101 reply
3/10s390x/cpumodel: Fix harmless misuse of visit_check_struct()target/s390x/cpu_models.c+1 -10 replies
4/10tests/migration: Tighten error checkingtests/qtest/migration-test.c+2 -21 reply
5/10error: Use error_reportf_err() where appropriatechardev/char-socket.c hw/sd/pxa2xx_mmci.c hw/sd/sd.c +3 more+17 -160 replies
6/10mips/malta: Fix create_cps() error handlinghw/mips/mips_malta.c+6 -91 reply
7/10mips/boston: Fix boston_mach_init() error handlinghw/mips/boston.c+5 -81 reply
8/10mips/boston: Plug memory leak in boston_mach_init()hw/mips/boston.c+2 -21 reply
9/10arm/sabrelite: Consistently use &error_fatal in sabrelite_init()hw/arm/sabrelite.c+1 -60 replies
10/10i386: Fix x86_cpu_load_model() error API violationtarget/i386/cpu.c+16 -90 replies

Reviews trailers per patch

9 of 10 patches have a Reviewed-by or Acked-by.

PatchEric BlakePhilippe Mathieu-DaudéDavid HildenbrandCornelia HuckAleksandar MarkovicPaul DurrantShivaprasad G Bhat
1/10T-b R-b
2/10A-b
3/10R-b R-b
4/10R-b
5/10R-b R-b
6/10R-b T-b R-b
7/10R-b
8/10R-b
9/10R-b
10/10

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 7 reviewers.

Read the v2 thread

Cover letter [PATCH v2 00/10] More miscellaneous error handling fixes

v2:
* PATCH 2: missing return [Paul]
* PATCH 3: commit message typo [David]
* PATCH 5: error message tidied up [Eric, Philippe]
* PATCH 7: commit message pasto
* Old PATCH 4 dropped [Matthew]

Cc Paul Durrant <[email protected]>
Cc David Hildenbrand <[email protected]>
Cc Eric Blake <[email protected]>
Cc Philippe Mathieu-Daudé <[email protected]>

Markus Armbruster (10):
nvdimm: Plug memory leak in uuid property setter
xen: Fix and improve handling of device_add usb-host errors s390x/cpumodel: Fix harmless misuse of visit_check_struct() tests/migration: Tighten error checking
error: Use error_reportf_err() where appropriate mips/malta: Fix create_cps() error handling mips/boston: Fix boston_mach_init() error handling mips/boston: Plug memory leak in boston_mach_init() arm/sabrelite: Consistently use &error_fatal in sabrelite_init()
i386: Fix x86_cpu_load_model() error API violation

 chardev/char-socket.c        |  5 +++--
 hw/arm/sabrelite.c           |  7 +------
 hw/mem/nvdimm.c              |  1 -
 hw/mips/boston.c             | 17 +++++++----------
 hw/mips/mips_malta.c         | 15 ++++++---------
 hw/sd/pxa2xx_mmci.c          |  4 ++--
 hw/sd/sd.c                   |  4 ++--
 hw/usb/dev-mtp.c             |  9 +++++----
 hw/usb/xen-usb.c             | 19 +++++++++----------
 qemu-nbd.c                   |  7 +++----
 scsi/qemu-pr-helper.c        |  4 ++--
 target/i386/cpu.c            | 25 ++++++++++++++++---------
 target/s390x/cpu_models.c    |  2 +-
 tests/qtest/migration-test.c |  4 ++--
 14 files changed, 59 insertions(+), 64 deletions(-)
Signature · 1 line
2.21.1