Skip to content

igc: Fixes to NFC support code

Andre Guedes intel-wired-lan 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest19 patches 0 repliesNew

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/19igc: Remove unused field from igc_nfc_filterdrivers/net/ethernet/intel/igc/igc.h+0 -11 reply
2/19igc: Get rid of igc_max_channels()drivers/net/ethernet/intel/igc/igc_ethtool.c drivers/net/ethernet/intel/igc/igc_main.c+3 -131 reply
3/19igc: Cleanup _get|set_rxnfc ethtool opsdrivers/net/ethernet/intel/igc/igc_ethtool.c+10 -231 reply
4/19igc: Early return in igc_get_ethtool_nfc_entry()drivers/net/ethernet/intel/igc/igc_ethtool.c+28 -301 reply
5/19igc: Add 'igc_ethtool_' prefix to functions in igc_ethtool.cdrivers/net/ethernet/intel/igc/igc.h drivers/net/ethernet/intel/igc/igc_ethtool.c drivers/net/ethernet/intel/igc/igc_main.c+112 -1081 reply
6/19igc: Align terms used in NFC support codedrivers/net/ethernet/intel/igc/igc.h drivers/net/ethernet/intel/igc/igc_ethtool.c drivers/net/ethernet/intel/igc/igc_main.c+114 -1171 reply
7/19igc: Change byte order in struct igc_nfc_filterdrivers/net/ethernet/intel/igc/igc.h drivers/net/ethernet/intel/igc/igc_ethtool.c+13 -221 reply
8/19igc: Refactor igc_ethtool_add_nfc_rule()drivers/net/ethernet/intel/igc/igc_ethtool.c+92 -581 reply
9/19igc: Fix 'sw_idx' type in struct igc_nfc_ruledrivers/net/ethernet/intel/igc/igc.h drivers/net/ethernet/intel/igc/igc_ethtool.c+9 -91 reply
10/19igc: Fix locking issue when retrieving NFC rulesdrivers/net/ethernet/intel/igc/igc_ethtool.c+16 -31 reply
11/19igc: Fix NFC rule overwrite casesdrivers/net/ethernet/intel/igc/igc_ethtool.c+1 -21 reply
12/19igc: Fix NFC rules with multicast addressesdrivers/net/ethernet/intel/igc/igc_main.c+0 -61 reply
13/19igc: Fix NFC rules restorationdrivers/net/ethernet/intel/igc/igc.h drivers/net/ethernet/intel/igc/igc_ethtool.c drivers/net/ethernet/intel/igc/igc_main.c+19 -201 reply
14/19igc: Refactor igc_ethtool_update_nfc_rule()drivers/net/ethernet/intel/igc/igc.h drivers/net/ethernet/intel/igc/igc_ethtool.c drivers/net/ethernet/intel/igc/igc_main.c+195 -1661 reply
15/19igc: Fix NFC rules leak when driver is unloadeddrivers/net/ethernet/intel/igc/igc_main.c+16 -131 reply
16/19igc: Fix NFC rule validationdrivers/net/ethernet/intel/igc/igc_ethtool.c+4 -31 reply
17/19igc: Change return type from igc_disable_nfc_rule()drivers/net/ethernet/intel/igc/igc_main.c+9 -171 reply
18/19igc: Change adapter->nfc_rule_lock to mutexdrivers/net/ethernet/intel/igc/igc.h drivers/net/ethernet/intel/igc/igc_ethtool.c drivers/net/ethernet/intel/igc/igc_main.c+20 -202 replies
19/19igc: Remove igc_nfc_rule_exit()drivers/net/ethernet/intel/igc/igc_main.c+0 -141 reply

Reviews trailers per patch

None of the 19 patches has a Reviewed-by or Acked-by.

PatchAaron Brown
1/19T-b
2/19T-b
3/19T-b
4/19T-b
5/19T-b
6/19T-b
7/19T-b
8/19T-b
9/19T-b
10/19T-b
11/19T-b
12/19T-b
13/19T-b
14/19T-b
15/19T-b
16/19T-b
17/19T-b
18/19T-b T-b
19/19T-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [Intel-wired-lan] [PATCH 00/19] igc: Fixes to NFC support code

Hi all,

Previous patch series [1-4] addressed issues with IGC filtering support individually (MAC address, VLAN priority, and ethertype filtering). This patch series fixes issues with the Network Flow Classification (NFC) support, which is built on top of those individual filters.

This series is organized as follows:

* Initial patches (1 to 4) do trivial code cleanup like remove unused code, useless wrappers, simplify logic, etc.

* Midsection patches (5 to 8) refactor the NFC support code to improve code reuse and organization. It also makes some upcoming bug fixes simpler.

* The rest of the series (9 to 19) fixes multiple bugs related to rules insertion, overwrite, and restoration as well as other issues like memory leak and locking.

Best regards,

Andre

[1] https://patchwork.ozlabs.org/project/intel-wired-lan/cover/20200318230102.36952-1-andre.guedes at intel.com/
[2] https://patchwork.ozlabs.org/project/intel-wired-lan/cover/20200403181743.23447-1-andre.guedes at intel.com/
[3] https://patchwork.ozlabs.org/project/intel-wired-lan/cover/20200407210711.24371-1-andre.guedes at intel.com/
[4] https://patchwork.ozlabs.org/project/intel-wired-lan/cover/20200411002834.13916-1-andre.guedes at intel.com/

Andre Guedes (19):
igc: Remove unused field from igc_nfc_filter
igc: Get rid of igc_max_channels()
igc: Cleanup _get|set_rxnfc ethtool ops
igc: Early return in igc_get_ethtool_nfc_entry()
igc: Add 'igc_ethtool_' prefix to functions in igc_ethtool.c
igc: Align terms used in NFC support code
igc: Change byte order in struct igc_nfc_filter
igc: Refactor igc_ethtool_add_nfc_rule()
igc: Fix 'sw_idx' type in struct igc_nfc_rule
igc: Fix locking issue when retrieving NFC rules
igc: Fix NFC rule overwrite cases
igc: Fix NFC rules with multicast addresses
igc: Fix NFC rules restoration
igc: Refactor igc_ethtool_update_nfc_rule()
igc: Fix NFC rules leak when driver is unloaded
igc: Fix NFC rule validation
igc: Change return type from igc_disable_nfc_rule()
igc: Change adapter->nfc_rule_lock to mutex
igc: Remove igc_nfc_rule_exit()

 drivers/net/ethernet/intel/igc/igc.h         |  57 +-
 drivers/net/ethernet/intel/igc/igc_ethtool.c | 608 ++++++++-----------
 drivers/net/ethernet/intel/igc/igc_main.c    | 257 +++++---
 3 files changed, 469 insertions(+), 453 deletions(-)
Signature · 1 line
2.26.0