igc: Fixes to NFC support code
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest19 patches 0 repliesNew
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/19 | igc: Remove unused field from igc_nfc_filterdrivers/ | +0 | 1 reply | |
| 2/19 | igc: Get rid of igc_max_channels()drivers/ drivers/ | +3 | 1 reply | |
| 3/19 | igc: Cleanup _get|set_rxnfc ethtool opsdrivers/ | +10 | 1 reply | |
| 4/19 | igc: Early return in igc_get_ethtool_nfc_entry()drivers/ | +28 | 1 reply | |
| 5/19 | igc: Add 'igc_ethtool_' prefix to functions in igc_ethtool.cdrivers/ drivers/ drivers/ | +112 | 1 reply | |
| 6/19 | igc: Align terms used in NFC support codedrivers/ drivers/ drivers/ | +114 | 1 reply | |
| 7/19 | igc: Change byte order in struct igc_nfc_filterdrivers/ drivers/ | +13 | 1 reply | |
| 8/19 | igc: Refactor igc_ethtool_add_nfc_rule()drivers/ | +92 | 1 reply | |
| 9/19 | igc: Fix 'sw_idx' type in struct igc_nfc_ruledrivers/ drivers/ | +9 | 1 reply | |
| 10/19 | igc: Fix locking issue when retrieving NFC rulesdrivers/ | +16 | 1 reply | |
| 11/19 | igc: Fix NFC rule overwrite casesdrivers/ | +1 | 1 reply | |
| 12/19 | igc: Fix NFC rules with multicast addressesdrivers/ | +0 | 1 reply | |
| 13/19 | igc: Fix NFC rules restorationdrivers/ drivers/ drivers/ | +19 | 1 reply | |
| 14/19 | igc: Refactor igc_ethtool_update_nfc_rule()drivers/ drivers/ drivers/ | +195 | 1 reply | |
| 15/19 | igc: Fix NFC rules leak when driver is unloadeddrivers/ | +16 | 1 reply | |
| 16/19 | igc: Fix NFC rule validationdrivers/ | +4 | 1 reply | |
| 17/19 | igc: Change return type from igc_disable_nfc_rule()drivers/ | +9 | 1 reply | |
| 18/19 | igc: Change adapter->nfc_rule_lock to mutexdrivers/ drivers/ drivers/ | +20 | 2 replies | |
| 19/19 | igc: Remove igc_nfc_rule_exit()drivers/ | +0 | 1 reply |
Reviews trailers per patch
None of the 19 patches has a Reviewed-by or Acked-by.
| Patch | Aaron Brown |
|---|---|
| 1/19 | T-b |
| 2/19 | T-b |
| 3/19 | T-b |
| 4/19 | T-b |
| 5/19 | T-b |
| 6/19 | T-b |
| 7/19 | T-b |
| 8/19 | T-b |
| 9/19 | T-b |
| 10/19 | T-b |
| 11/19 | T-b |
| 12/19 | T-b |
| 13/19 | T-b |
| 14/19 | T-b |
| 15/19 | T-b |
| 16/19 | T-b |
| 17/19 | T-b |
| 18/19 | T-b T-b |
| 19/19 | T-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [Intel-wired-lan] [PATCH 00/19] igc: Fixes to NFC support code
Hi all,
Previous patch series [1-4] addressed issues with IGC filtering support individually (MAC address, VLAN priority, and ethertype filtering). This patch series fixes issues with the Network Flow Classification (NFC) support, which is built on top of those individual filters.
This series is organized as follows:
* Initial patches (1 to 4) do trivial code cleanup like remove unused code, useless wrappers, simplify logic, etc.
* Midsection patches (5 to 8) refactor the NFC support code to improve code reuse and organization. It also makes some upcoming bug fixes simpler.
* The rest of the series (9 to 19) fixes multiple bugs related to rules insertion, overwrite, and restoration as well as other issues like memory leak and locking.
Best regards,
Andre
[1] https://patchwork.ozlabs.org/project/intel-wired-lan/cover/20200318230102.36952-1-andre.guedes at intel.com/
[2] https://patchwork.ozlabs.org/project/intel-wired-lan/cover/20200403181743.23447-1-andre.guedes at intel.com/
[3] https://patchwork.ozlabs.org/project/intel-wired-lan/cover/20200407210711.24371-1-andre.guedes at intel.com/
[4] https://patchwork.ozlabs.org/project/intel-wired-lan/cover/20200411002834.13916-1-andre.guedes at intel.com/
Andre Guedes (19):
igc: Remove unused field from igc_nfc_filter
igc: Get rid of igc_max_channels()
igc: Cleanup _get|set_rxnfc ethtool ops
igc: Early return in igc_get_ethtool_nfc_entry()
igc: Add 'igc_ethtool_' prefix to functions in igc_ethtool.c
igc: Align terms used in NFC support code
igc: Change byte order in struct igc_nfc_filter
igc: Refactor igc_ethtool_add_nfc_rule()
igc: Fix 'sw_idx' type in struct igc_nfc_rule
igc: Fix locking issue when retrieving NFC rules
igc: Fix NFC rule overwrite cases
igc: Fix NFC rules with multicast addresses
igc: Fix NFC rules restoration
igc: Refactor igc_ethtool_update_nfc_rule()
igc: Fix NFC rules leak when driver is unloaded
igc: Fix NFC rule validation
igc: Change return type from igc_disable_nfc_rule()
igc: Change adapter->nfc_rule_lock to mutex
igc: Remove igc_nfc_rule_exit()
drivers/net/ethernet/intel/igc/igc.h | 57 +- drivers/net/ethernet/intel/igc/igc_ethtool.c | 608 ++++++++----------- drivers/net/ethernet/intel/igc/igc_main.c | 257 +++++--- 3 files changed, 469 insertions(+), 453 deletions(-)
Signature · 1 line
2.26.0