Skip to content

xfs: Backport two fixes

Suraj Jitindar Singh linux-xfs stable 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest2 patches 2 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2xfs: validate sb_logsunit is a multiple of the fs blocksizefs/xfs/xfs_log.c+13 -10 replies
2/2xfs: Fix deadlock between AGI and AGF with RENAME_WHITEOUTfs/xfs/xfs_inode.c+42 -432 replies

Reviews trailers per patch

All 2 patches have a Reviewed-by or Acked-by.

PatchBrian FosterDarrick J. Wong
1/2R-b
2/2R-b R-b R-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH STABLE v4.14.y 0/2] xfs: Backport two fixes

This series backports two patches which fix known bugs in the xfs filesystem code to the v4.14.y stable tree.

They are each verified by the xfs tests xfs/439 and generic/585 respectively.

The first patch applies cleanly.

The second patch required slight massage due to the last code block being removed having changed slightly upstream due to rework. I think the backport is functionally equivalent.
Only thing is I request comment that it is correct to use the following error path:

	ASSERT(VFS_I(wip)->i_nlink == 0);
	error = xfs_iunlink_remove(tp, wip);
	if (error)
Quoted 1 line
	       goto out_trans_cancel;

The old error patch out_bmap_cancel still exists here. However as nothing can have modified the deferred ops struct at this point I believe it is sufficient to go to the "out_trans_cancel" error label.

Darrick J. Wong (1):
xfs: validate sb_logsunit is a multiple of the fs blocksize

kaixuxia (1):
xfs: Fix deadlock between AGI and AGF with RENAME_WHITEOUT

 fs/xfs/xfs_inode.c | 85 +++++++++++++++++++++++-----------------------
 fs/xfs/xfs_log.c   | 14 +++++++-
 2 files changed, 55 insertions(+), 44 deletions(-)
Signature · 1 line
2.17.1