Skip to content

cocci: Add parameter attributes to SmPL

Jaskaran Singh cocci linux-kernel-mentees 2 versions – New

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest23 patches 0 repliesNew
  2. v123 patches 7 repliesSuperseded

Changes in v3 from the cover letter

--------------

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/23parsing_cocci: ast0_cocci: Add parameter attributesparsing_cocci/ast0_cocci.ml parsing_cocci/ast0_cocci.mli+4 -40 replies
2/23parsing_cocci: parser: Parse Parameter attributesparsing_cocci/parser_cocci_menhir.mly+4 -30 replies
3/23parsing_cocci: visitor_ast0: Visit Parameter attributesparsing_cocci/visitor_ast0.ml+10 -60 replies
4/23parsing_cocci: arity: Reflect Parameter attributesparsing_cocci/arity.ml+10 -70 replies
5/23parsing_cocci: check_meta: Reflect Parameter attributesparsing_cocci/check_meta.ml+2 -10 replies
6/23parsing_cocci: compute_lines: Reflect Parameter attributesparsing_cocci/compute_lines.ml+24 -60 replies
7/23parsing_cocci: context_neg: Reflect Parameter attributesparsing_cocci/context_neg.ml+6 -40 replies
8/23parsing_cocci: function_prototypes: Reflect Parameter attributesparsing_cocci/function_prototypes.ml+4 -40 replies
9/23parsing_cocci: index: Reflect Parameter attributesparsing_cocci/index.ml+2 -20 replies
10/23parsing_cocci: iso_pattern: Reflect Parameter attributesparsing_cocci/iso_pattern.ml+16 -40 replies
11/23parsing_cocci: type_infer: Reflect Parameter attributesparsing_cocci/type_infer.ml+1 -10 replies
12/23parsing_cocci: unparse_ast0: Reflect Parameter attributesparsing_cocci/unparse_ast0.ml+12 -30 replies
13/23parsing_c: unparse_cocci: Reflect Parameter attributesparsing_c/unparse_cocci.ml+12 -40 replies
14/23parsing_cocci: ast_cocci: Add Parameter attributesparsing_cocci/ast_cocci.ml parsing_cocci/ast_cocci.mli+4 -40 replies
15/23parsing_cocci: visitor_ast: Visit Parameter attributesparsing_cocci/visitor_ast.ml+17 -50 replies
16/23parsing_cocci: ast0toast: Reflect Parameter attributesparsing_cocci/ast0toast.ml+4 -30 replies
17/23parsing_cocci: disjdistr: Reflect Parameter attributesparsing_cocci/disjdistr.ml+3 -30 replies
18/23parsing_cocci: pretty_print_cocci: Reflect Parameter attributesparsing_cocci/pretty_print_cocci.ml+12 -30 replies
19/23parsing_cocci: unify_ast: Reflect Parameter attributesparsing_cocci/unify_ast.ml+10 -40 replies
20/23engine: cocci_vs_c: Match Parameter attributesengine/cocci_vs_c.ml+9 -90 replies
21/23ocaml: coccilib: Reflect Parameter attributesocaml/coccilib.mli+4 -40 replies
22/23tests: Add test case for removing parameter attributestests/remove_param_attrs.c tests/remove_param_attrs.cocci tests/remove_param_attrs.res+35 -00 replies
23/23tests: Add test case to detect parameter attributestests/detect_param_attr.c tests/detect_param_attr.cocci tests/detect_param_attr.res+19 -00 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v3 yet.

Read the v3 thread

Cover letter [Cocci] [PATCH v3 00/23] cocci: Add parameter attributes to SmPL

This patch series aims to add parameter attributes to SmPL, and is a continuation of the series "cocci: Improve C parsing of attributes"[1]. In [1], parameter attributes were added to the C AST of Coccinelle, but not to SmPL.

Two test cases are included:

- detect_param_attr: Test case to detect a parameter attribute.

- remove_param_attr: Test case to remove a parameter attribute as per the given SmPL.

[1]https://www.mail-archive.com/[email protected]/msg07133.html

Changes in v3:
--------------

parsing_cocci: check_meta: Reflect Parameter attributes
- Add comment about the absence of a meta attribute.

parsing_cocci: compute_lines: Reflect Parameter attributes
- Pass the correct last element to mkres.

parsing_cocci: iso_pattern: Reflect Parameter attributes
- Place opening paranthesis to the right of the if.

parsing_cocci: unparse_ast0: Reflect Parameter attributes
- Fix wacky indentation.

parsing_cocci: visitor_ast: Visit Parameter attributes
- Fix wacky indentation.

Changes in v2:
--------------

parsing_cocci: function_prototypes: Reflect Parameter attributes
- Remove unnecessary function name change.

Jaskaran Singh (23):
parsing_cocci: ast0_cocci: Add parameter attributes
parsing_cocci: parser: Parse Parameter attributes
parsing_cocci: visitor_ast0: Visit Parameter attributes
parsing_cocci: arity: Reflect Parameter attributes
parsing_cocci: check_meta: Reflect Parameter attributes
parsing_cocci: compute_lines: Reflect Parameter attributes
parsing_cocci: context_neg: Reflect Parameter attributes
parsing_cocci: function_prototypes: Reflect Parameter attributes
parsing_cocci: index: Reflect Parameter attributes
parsing_cocci: iso_pattern: Reflect Parameter attributes
parsing_cocci: type_infer: Reflect Parameter attributes
parsing_cocci: unparse_ast0: Reflect Parameter attributes
parsing_c: unparse_cocci: Reflect Parameter attributes
parsing_cocci: ast_cocci: Add Parameter attributes
parsing_cocci: visitor_ast: Visit Parameter attributes
parsing_cocci: ast0toast: Reflect Parameter attributes
parsing_cocci: disjdistr: Reflect Parameter attributes
parsing_cocci: pretty_print_cocci: Reflect Parameter attributes
parsing_cocci: unify_ast: Reflect Parameter attributes
engine: cocci_vs_c: Match Parameter attributes
ocaml: coccilib: Reflect Parameter attributes
tests: Add test case for removing parameter attributes
tests: Add test case to detect parameter attributes

 engine/cocci_vs_c.ml                  |   18 +++++++++---------
 ocaml/coccilib.mli                    |    8 ++++----
 parsing_c/unparse_cocci.ml            |   16 ++++++++++++----
 parsing_cocci/arity.ml                |   17 ++++++++++-------
 parsing_cocci/ast0_cocci.ml           |    4 ++--
 parsing_cocci/ast0_cocci.mli          |    4 ++--
 parsing_cocci/ast0toast.ml            |    7 ++++---
 parsing_cocci/ast_cocci.ml            |    4 ++--
 parsing_cocci/ast_cocci.mli           |    4 ++--
 parsing_cocci/check_meta.ml           |    3 ++-
 parsing_cocci/compute_lines.ml        |   30 ++++++++++++++++++++++++------
 parsing_cocci/context_neg.ml          |   10 ++++++----
 parsing_cocci/disjdistr.ml            |    6 +++---
 parsing_cocci/function_prototypes.ml  |    8 ++++----
 parsing_cocci/index.ml                |    4 ++--
 parsing_cocci/iso_pattern.ml          |   20 ++++++++++++++++----
 parsing_cocci/parser_cocci_menhir.mly |    7 ++++---
 parsing_cocci/pretty_print_cocci.ml   |   15 ++++++++++++---
 parsing_cocci/type_infer.ml           |    2 +-
 parsing_cocci/unify_ast.ml            |   14 ++++++++++----
 parsing_cocci/unparse_ast0.ml         |   15 ++++++++++++---
 parsing_cocci/visitor_ast.ml          |   22 +++++++++++++++++-----
 parsing_cocci/visitor_ast0.ml         |   16 ++++++++++------
 tests/detect_param_attr.c             |    3 +++
 tests/detect_param_attr.cocci         |   13 +++++++++++++
 tests/detect_param_attr.res           |    3 +++
 tests/remove_param_attrs.c            |   11 +++++++++++
 tests/remove_param_attrs.cocci        |   13 +++++++++++++
 tests/remove_param_attrs.res          |   11 +++++++++++
 29 files changed, 224 insertions(+), 84 deletions(-)

_______________________________________________
Linux-kernel-mentees mailing list
[email protected]
https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees